* [dm-devel] [PATCH] libmultipath: fix find_multipaths_timeout for unknown hardware
@ 2022-07-12 22:02 Benjamin Marzinski
2022-07-13 9:20 ` Martin Wilck
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2022-07-12 22:02 UTC (permalink / raw)
To: Christophe Varoqui; +Cc: device-mapper development, Martin Wilck
pp->hwe is now a vector that will always be allocated for all path
devices. Instead of checking if it is NULL, check if it is empty.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/propsel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
index 50d0b5c8..f782f251 100644
--- a/libmultipath/propsel.c
+++ b/libmultipath/propsel.c
@@ -1293,7 +1293,7 @@ out:
*/
if (pp->find_multipaths_timeout < 0) {
pp->find_multipaths_timeout = -pp->find_multipaths_timeout;
- if (!pp->hwe) {
+ if (VECTOR_SIZE(pp->hwe) == 0) {
pp->find_multipaths_timeout =
DEFAULT_UNKNOWN_FIND_MULTIPATHS_TIMEOUT;
origin = "(default for unknown hardware)";
--
2.17.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dm-devel] [PATCH] libmultipath: fix find_multipaths_timeout for unknown hardware
2022-07-12 22:02 [dm-devel] [PATCH] libmultipath: fix find_multipaths_timeout for unknown hardware Benjamin Marzinski
@ 2022-07-13 9:20 ` Martin Wilck
0 siblings, 0 replies; 2+ messages in thread
From: Martin Wilck @ 2022-07-13 9:20 UTC (permalink / raw)
To: bmarzins, christophe.varoqui; +Cc: dm-devel
On Tue, 2022-07-12 at 17:02 -0500, Benjamin Marzinski wrote:
> pp->hwe is now a vector that will always be allocated for all path
> devices. Instead of checking if it is NULL, check if it is empty.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
> ---
> libmultipath/propsel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libmultipath/propsel.c b/libmultipath/propsel.c
> index 50d0b5c8..f782f251 100644
> --- a/libmultipath/propsel.c
> +++ b/libmultipath/propsel.c
> @@ -1293,7 +1293,7 @@ out:
> */
> if (pp->find_multipaths_timeout < 0) {
> pp->find_multipaths_timeout = -pp-
> >find_multipaths_timeout;
> - if (!pp->hwe) {
> + if (VECTOR_SIZE(pp->hwe) == 0) {
> pp->find_multipaths_timeout =
> DEFAULT_UNKNOWN_FIND_MULTIPATHS_TIMEO
> UT;
> origin = "(default for unknown hardware)";
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-13 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 22:02 [dm-devel] [PATCH] libmultipath: fix find_multipaths_timeout for unknown hardware Benjamin Marzinski
2022-07-13 9:20 ` Martin Wilck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).