From: lixiaokeng <lixiaokeng@huawei.com>
To: Martin Wilck <mwilck@suse.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: linfeilong <linfeilong@huawei.com>,
dm-devel@redhat.com, hexiaowen@huawei.com
Subject: Re: [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup()
Date: Fri, 19 Feb 2021 09:36:59 +0800 [thread overview]
Message-ID: <139b81ce-e6d7-e386-2666-447ecd2da315@huawei.com> (raw)
In-Reply-To: <11c072c152937004e5f08ecff8dd9ded7d915af6.camel@suse.com>
On 2021/2/10 1:30, Martin Wilck wrote:
> On Tue, 2021-02-09 at 09:36 +0800, lixiaokeng wrote:
>>
>>>
>>> I still don't fully understand. Above you said "this coredump
>>> doesn't
>>> seem to appear any more". Am I understanding correctly that you
>>> observed *other* core dumps instead?
>
>>>
>>
>> No, it is not "instead".
>> As shown in https://www.spinics.net/lists/dm-devel/msg45293.html,
>> there are some different crashes in multipathd with no code change.
>> When blocking of thread cancellation during
>> udev_monitor_receive_device(),
>> no crash in udev_monitor_receive_device happens but others still
>> exist.
>
> Now I got it, eventually :-) Thanks for the clarification. Would it be
> ossible for you to categorize the different issues and provide core
> dumps?
>
> You mentioned in the systemd issue that you were playing around with
> the gcc -fexceptions flag. As I remarked there - how did it get set in
> the first place? What distro are you using?
>>>
>>> The "best" solution would probably be to generally disallow
>>> cancellation, and only run pthread_testcancel() at certain points
>>> in
>>> the code where we might block (and know that being cancelled would
>>> be
>>> safe). That would not only make multipathd safer from crashing, it
>>> would also enable us to remove hundreds of ugly
>>> pthread_cleanup_push()/pop() calls from our code.
>>>
>>> Finding all these points would be a challenge though, and if we
>>> don't
>>> find them, we risk hanging on exit again, which is bad too, and was
>>> just recently improved.
>>
>> Do you mean some patches have been made to solve these problem?
>
> No. I could hack up some, but it will take some time.
>
Hi Martin,
How is this problem going?
Regards
Lixiaokeng
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-02-19 1:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 21:08 [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup() mwilck
2021-02-02 20:52 ` Martin Wilck
2021-02-03 10:48 ` lixiaokeng
2021-02-03 13:57 ` Martin Wilck
2021-02-04 1:40 ` lixiaokeng
2021-02-04 15:06 ` Martin Wilck
2021-02-05 11:08 ` Martin Wilck
2021-02-05 11:09 ` Martin Wilck
2021-02-07 7:05 ` lixiaokeng
2021-03-01 14:53 ` lixiaokeng
2021-03-02 8:41 ` lixiaokeng
2021-03-02 11:07 ` Martin Wilck
2021-03-02 15:49 ` lixiaokeng
2021-03-02 9:56 ` Martin Wilck
2021-03-02 12:44 ` lixiaokeng
2021-03-02 15:29 ` Martin Wilck
2021-03-02 16:55 ` Martin Wilck
2021-03-03 10:42 ` lixiaokeng
2021-03-08 9:40 ` Martin Wilck
2021-03-15 13:00 ` Martin Wilck
2021-03-16 11:12 ` lixiaokeng
2021-03-17 16:59 ` Martin Wilck
2021-03-19 1:49 ` lixiaokeng
2021-02-08 7:41 ` lixiaokeng
2021-02-08 9:50 ` Martin Wilck
2021-02-08 10:49 ` lixiaokeng
2021-02-08 11:03 ` Martin Wilck
2021-02-09 1:36 ` lixiaokeng
2021-02-09 17:30 ` Martin Wilck
2021-02-10 2:02 ` lixiaokeng
2021-02-10 2:29 ` Hexiaowen (Hex, EulerOS)
2021-02-19 10:35 ` Martin Wilck
2021-02-19 1:36 ` lixiaokeng [this message]
2021-02-02 22:23 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=139b81ce-e6d7-e386-2666-447ecd2da315@huawei.com \
--to=lixiaokeng@huawei.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=hexiaowen@huawei.com \
--cc=linfeilong@huawei.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).