From: Martin Wilck <mwilck@suse.com>
To: lixiaokeng@huawei.com, Benjamin Marzinski <bmarzins@redhat.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup()
Date: Tue, 02 Feb 2021 21:52:55 +0100 [thread overview]
Message-ID: <c1dddccecfe0e12a2fe2dca66faad740a30acd53.camel@suse.com> (raw)
In-Reply-To: <20210128210852.23207-1-mwilck@suse.com>
lixiaokeng,
did this fix your "crash on exit" issue?
Martin
On Thu, 2021-01-28 at 22:08 +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> Crashes have been observed in the unwinder stack of uevent_listen().
> This can only be explained by "udev" not being a valid object at that
> time. Be sure to pass a valid pointer, and don't call udev_unref() if
> it has been set to NULL already.
>
> I'm not quite sure how this would come to pass, as we join the
> threads
> before setting udev to NULL, but this is unwinder code, so I guess it
> might actually be executed after the thread has terminated.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> libmultipath/uevent.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/libmultipath/uevent.c b/libmultipath/uevent.c
> index d3061bf..4e662ff 100644
> --- a/libmultipath/uevent.c
> +++ b/libmultipath/uevent.c
> @@ -397,10 +397,11 @@ service_uevq(struct list_head *tmpq)
>
> static void uevent_cleanup(void *arg)
> {
> - struct udev *udev = arg;
> + struct udev **pudev = arg;
>
> + if (*pudev)
> + udev_unref(*pudev);
> condlog(3, "Releasing uevent_listen() resources");
> - udev_unref(udev);
> }
>
> static void monitor_cleanup(void *arg)
> @@ -560,7 +561,7 @@ int uevent_listen(struct udev *udev)
> return 1;
> }
> udev_ref(udev);
> - pthread_cleanup_push(uevent_cleanup, udev);
> + pthread_cleanup_push(uevent_cleanup, &udev);
>
> monitor = udev_monitor_new_from_netlink(udev, "udev");
> if (!monitor) {
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-02-02 20:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 21:08 [dm-devel] [PATCH] multipathd: avoid crash in uevent_cleanup() mwilck
2021-02-02 20:52 ` Martin Wilck [this message]
2021-02-03 10:48 ` lixiaokeng
2021-02-03 13:57 ` Martin Wilck
2021-02-04 1:40 ` lixiaokeng
2021-02-04 15:06 ` Martin Wilck
2021-02-05 11:08 ` Martin Wilck
2021-02-05 11:09 ` Martin Wilck
2021-02-07 7:05 ` lixiaokeng
2021-03-01 14:53 ` lixiaokeng
2021-03-02 8:41 ` lixiaokeng
2021-03-02 11:07 ` Martin Wilck
2021-03-02 15:49 ` lixiaokeng
2021-03-02 9:56 ` Martin Wilck
2021-03-02 12:44 ` lixiaokeng
2021-03-02 15:29 ` Martin Wilck
2021-03-02 16:55 ` Martin Wilck
2021-03-03 10:42 ` lixiaokeng
2021-03-08 9:40 ` Martin Wilck
2021-03-15 13:00 ` Martin Wilck
2021-03-16 11:12 ` lixiaokeng
2021-03-17 16:59 ` Martin Wilck
2021-03-19 1:49 ` lixiaokeng
2021-02-08 7:41 ` lixiaokeng
2021-02-08 9:50 ` Martin Wilck
2021-02-08 10:49 ` lixiaokeng
2021-02-08 11:03 ` Martin Wilck
2021-02-09 1:36 ` lixiaokeng
2021-02-09 17:30 ` Martin Wilck
2021-02-10 2:02 ` lixiaokeng
2021-02-10 2:29 ` Hexiaowen (Hex, EulerOS)
2021-02-19 10:35 ` Martin Wilck
2021-02-19 1:36 ` lixiaokeng
2021-02-02 22:23 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1dddccecfe0e12a2fe2dca66faad740a30acd53.camel@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
--cc=lixiaokeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).