dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: mwilck@suse.com
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
	Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com, Martin Wilck <mwilck@suse.com>
Subject: [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
Date: Wed, 10 Feb 2021 13:24:57 +0100	[thread overview]
Message-ID: <20210210122457.3415-1-mwilck@suse.com> (raw)

From: Martin Wilck <mwilck@suse.com>

gcc-11 throws an error compiling alias.c and dmevents.c:

In file included from ../libmultipath/checkers.h:4,
                 from ../libmultipath/prio.h:7,
                 from ../libmultipath/structs.h:8,
                 from dmevents.c:29:
../multipathd/dmevents.c: In function 'dmevent_loop':
../multipathd/dmevents.c:357:17: error: '__sigsetjmp' accessing 200 bytes in a region of size 72 [-Werror=stringop-overflow=]
  357 |                 pthread_cleanup_push(cleanup_lock, &waiter->vecs->lock);
      |                 ^~~~~~~~~~~~~~~~~~~~
../multipathd/dmevents.c:357:17: note: referencing argument 1 of type 'struct __jmp_buf_tag *'
/usr/include/pthread.h:734:12: note: in a call to function '__sigsetjmp'
  734 | extern int __sigsetjmp (struct __jmp_buf_tag *__env, int __savemask) __THROWNL;
      |            ^~~~~~~~~~~

The reason seems to be a mismatch between the __sigsetjmp() prototype
in <setjmp.h> and <pthread.h>. Until this is fixed in the toolchain,
work around it by including <pthread.h> first.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---
 tests/alias.c    | 1 +
 tests/dmevents.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/tests/alias.c b/tests/alias.c
index 0311faa..5e0bfea 100644
--- a/tests/alias.c
+++ b/tests/alias.c
@@ -1,3 +1,4 @@
+#include <pthread.h>
 #include <stdint.h>
 #include <setjmp.h>
 #include <stdio.h>
diff --git a/tests/dmevents.c b/tests/dmevents.c
index b7c5122..29eaa6d 100644
--- a/tests/dmevents.c
+++ b/tests/dmevents.c
@@ -16,6 +16,7 @@
  *
  */
 
+#include <pthread.h>
 #include <stdint.h>
 #include <stdbool.h>
 #include <stdarg.h>
-- 
2.29.2


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


             reply	other threads:[~2021-02-10 12:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 12:24 mwilck [this message]
2021-02-10 14:18 ` [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11 Martin Wilck
2021-02-10 14:21   ` Martin Wilck
2021-02-10 16:46 ` Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210210122457.3415-1-mwilck@suse.com \
    --to=mwilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).