From: Martin Wilck <mwilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11
Date: Wed, 10 Feb 2021 15:18:43 +0100 [thread overview]
Message-ID: <9514cd1dfe58cddc1146601b17835cbbd67bdd6e.camel@suse.com> (raw)
In-Reply-To: <20210210122457.3415-1-mwilck@suse.com>
On Wed, 2021-02-10 at 13:24 +0100, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> gcc-11 throws an error compiling alias.c and dmevents.c:
>
> In file included from ../libmultipath/checkers.h:4,
> from ../libmultipath/prio.h:7,
> from ../libmultipath/structs.h:8,
> from dmevents.c:29:
> ../multipathd/dmevents.c: In function 'dmevent_loop':
> ../multipathd/dmevents.c:357:17: error: '__sigsetjmp' accessing 200
> bytes in a region of size 72 [-Werror=stringop-overflow=]
> 357 | pthread_cleanup_push(cleanup_lock, &waiter-
> >vecs->lock);
> | ^~~~~~~~~~~~~~~~~~~~
> ../multipathd/dmevents.c:357:17: note: referencing argument 1 of type
> 'struct __jmp_buf_tag *'
> /usr/include/pthread.h:734:12: note: in a call to function
> '__sigsetjmp'
> 734 | extern int __sigsetjmp (struct __jmp_buf_tag *__env, int
> __savemask) __THROWNL;
> | ^~~~~~~~~~~
>
> The reason seems to be a mismatch between the __sigsetjmp() prototype
> in <setjmp.h> and <pthread.h>. Until this is fixed in the toolchain,
> work around it by including <pthread.h> first.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
I'm told that this issue is related to this glibc bug:
https://sourceware.org/bugzilla/show_bug.cgi?id=26647
and should be fixed in glibc 2.33. Yet adding this patch doesn't hurt
us and can serve as a workaround for environments with gcc 11.
Regards
Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-02-10 14:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 12:24 [dm-devel] [PATCH] multipath-tools tests: fix stringop-overflow build errors with gcc 11 mwilck
2021-02-10 14:18 ` Martin Wilck [this message]
2021-02-10 14:21 ` Martin Wilck
2021-02-10 16:46 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9514cd1dfe58cddc1146601b17835cbbd67bdd6e.camel@suse.com \
--to=mwilck@suse.com \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).