From: Dan Williams <dan.j.williams@intel.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: Linux NVDIMM <nvdimm@lists.linux.dev>,
Mike Snitzer <snitzer@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>,
david <david@fromorbit.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH RESEND v6 4/9] pmem, mm: Implement ->memory_failure in pmem driver
Date: Fri, 20 Aug 2021 13:51:22 -0700 [thread overview]
Message-ID: <CAPcyv4hQgSV6n0nuiqm-cv7pvpwDgBgZMezW7TkdR9SaAiCNHg@mail.gmail.com> (raw)
In-Reply-To: <20210730100158.3117319-5-ruansy.fnst@fujitsu.com>
On Fri, Jul 30, 2021 at 3:02 AM Shiyang Ruan <ruansy.fnst@fujitsu.com> wrote:
>
> With dax_holder notify support, we are able to notify the memory failure
> from pmem driver to upper layers. If there is something not support in
> the notify routine, memory_failure will fall back to the generic hanlder.
How about:
"Any layer can return -EOPNOTSUPP to force memory_failure() to fall
back to its generic implementation."
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> ---
> drivers/nvdimm/pmem.c | 13 +++++++++++++
> mm/memory-failure.c | 14 ++++++++++++++
> 2 files changed, 27 insertions(+)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 1e0615b8565e..fea4ffc333b8 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -362,9 +362,22 @@ static void pmem_release_disk(void *__pmem)
> del_gendisk(pmem->disk);
> }
>
> +static int pmem_pagemap_memory_failure(struct dev_pagemap *pgmap,
> + unsigned long pfn, unsigned long nr_pfns, int flags)
> +{
> + struct pmem_device *pmem =
> + container_of(pgmap, struct pmem_device, pgmap);
> + loff_t offset = PFN_PHYS(pfn) - pmem->phys_addr - pmem->data_offset;
> +
> + return dax_holder_notify_failure(pmem->dax_dev, offset,
> + page_size(pfn_to_page(pfn)) * nr_pfns,
I do not understand the usage of page_size() here? memory_failure()
assumes PAGE_SIZE pages. DAX pages also do not populate the compound
metadata yet, but even if they did I would expect memory_failure() to
be responsible for doing something like:
pgmap->ops->memory_failure(pgmap, pfn, size >> PAGE_SHIFT, flags);
...where @size is calculated from dev_pagemap_mapping_shift().
> + &flags);
Why is the local flags variable passed by reference? At a minimum the
memory_failure() flags should be translated to a new set dax-notify
flags, because memory_failure() will not be the only user of this
notification interface. See NVDIMM_REVALIDATE_POISON, and the
discussion Dave and I had about using this notification to signal
unsafe hot-removal of a memory device.
> +}
> +
> static const struct dev_pagemap_ops fsdax_pagemap_ops = {
> .kill = pmem_pagemap_kill,
> .cleanup = pmem_pagemap_cleanup,
> + .memory_failure = pmem_pagemap_memory_failure,
> };
>
> static int pmem_attach_disk(struct device *dev,
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 3bdfcb45f66e..ab3eda335acd 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1600,6 +1600,20 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags,
> */
> SetPageHWPoison(page);
>
> + /*
> + * Call driver's implementation to handle the memory failure, otherwise
> + * fall back to generic handler.
> + */
> + if (pgmap->ops->memory_failure) {
> + rc = pgmap->ops->memory_failure(pgmap, pfn, 1, flags);
> + /*
> + * Fall back to generic handler too if operation is not
> + * supported inside the driver/device/filesystem.
> + */
> + if (rc != EOPNOTSUPP)
> + goto out;
> + }
> +
> mf_generic_kill_procs(pfn, flags);
> out:
> /* drop pgmap ref acquired in caller */
> --
> 2.32.0
>
>
>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-20 20:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 10:01 [dm-devel] [PATCH RESEND v6 0/9] fsdax: introduce fs query to support reflink Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() Shiyang Ruan
2021-08-06 1:17 ` Jane Chu
2021-08-16 17:20 ` Jane Chu
2021-08-17 1:44 ` ruansy.fnst
2021-08-18 5:43 ` Jane Chu
2021-08-18 6:08 ` Jane Chu
2021-08-18 7:52 ` ruansy.fnst
2021-08-18 17:10 ` Dan Williams
2021-08-23 13:21 ` hch
2021-08-18 15:52 ` Darrick J. Wong
2021-08-19 7:18 ` Jane Chu
2021-08-19 8:11 ` Jane Chu
2021-08-19 9:10 ` ruansy.fnst
2021-08-19 20:50 ` Jane Chu
2021-08-20 16:07 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device Shiyang Ruan
2021-08-06 1:02 ` Jane Chu
2021-08-17 1:45 ` ruansy.fnst
2021-08-20 16:06 ` Dan Williams
2021-08-20 20:19 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2021-08-06 1:00 ` Jane Chu
2021-08-20 16:54 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 4/9] pmem, mm: Implement ->memory_failure in pmem driver Shiyang Ruan
2021-08-20 20:51 ` Dan Williams [this message]
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2021-08-06 0:59 ` Jane Chu
2021-08-20 22:40 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2021-08-06 0:50 ` Jane Chu
2021-08-20 22:56 ` Dan Williams
2021-08-20 22:59 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan
2021-08-20 23:46 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 8/9] md: Implement dax_holder_operations Shiyang Ruan
2021-08-06 0:48 ` Jane Chu
2021-08-17 1:59 ` ruansy.fnst
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 9/9] fsdax: add exception for reflinked files Shiyang Ruan
2021-08-06 0:46 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hQgSV6n0nuiqm-cv7pvpwDgBgZMezW7TkdR9SaAiCNHg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=agk@redhat.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).