From: "ruansy.fnst@fujitsu.com" <ruansy.fnst@fujitsu.com>
To: Jane Chu <jane.chu@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Cc: "snitzer@redhat.com" <snitzer@redhat.com>,
"djwong@kernel.org" <djwong@kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"hch@lst.de" <hch@lst.de>, "agk@redhat.com" <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device
Date: Tue, 17 Aug 2021 01:45:28 +0000 [thread overview]
Message-ID: <OSBPR01MB292042C10A7AA95CB6862F08F4FE9@OSBPR01MB2920.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <e844fc54-113f-239d-da23-fa140aeea9d7@oracle.com>
> -----Original Message-----
> From: Jane Chu <jane.chu@oracle.com>
> Subject: Re: [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device
>
>
> On 7/30/2021 3:01 AM, Shiyang Ruan wrote:
> > --- a/drivers/dax/super.c
> > +++ b/drivers/dax/super.c
> > @@ -214,6 +214,8 @@ enum dax_device_flags {
> > * @cdev: optional character interface for "device dax"
> > * @host: optional name for lookups where the device path is not available
> > * @private: dax driver private data
> > + * @holder_rwsem: prevent unregistration while holder_ops is in progress
> > + * @holder_data: holder of a dax_device: could be filesystem or mapped
> device
> > * @flags: state and boolean properties
>
> Perhaps add two documentary lines for @ops and @holder_ops?
OK. I'll add them in next version.
--
Thanks,
Ruan.
> > */
> > struct dax_device {
> > @@ -222,8 +224,11 @@ struct dax_device {
> > struct cdev cdev;
> > const char *host;
> > void *private;
> > + struct rw_semaphore holder_rwsem;
> > + void *holder_data;
> > unsigned long flags;
> > const struct dax_operations *ops;
> > + const struct dax_holder_operations *holder_ops;
> > };
>
> thanks,
> -jane
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-08-17 1:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 10:01 [dm-devel] [PATCH RESEND v6 0/9] fsdax: introduce fs query to support reflink Shiyang Ruan
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 1/9] pagemap: Introduce ->memory_failure() Shiyang Ruan
2021-08-06 1:17 ` Jane Chu
2021-08-16 17:20 ` Jane Chu
2021-08-17 1:44 ` ruansy.fnst
2021-08-18 5:43 ` Jane Chu
2021-08-18 6:08 ` Jane Chu
2021-08-18 7:52 ` ruansy.fnst
2021-08-18 17:10 ` Dan Williams
2021-08-23 13:21 ` hch
2021-08-18 15:52 ` Darrick J. Wong
2021-08-19 7:18 ` Jane Chu
2021-08-19 8:11 ` Jane Chu
2021-08-19 9:10 ` ruansy.fnst
2021-08-19 20:50 ` Jane Chu
2021-08-20 16:07 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 2/9] dax: Introduce holder for dax_device Shiyang Ruan
2021-08-06 1:02 ` Jane Chu
2021-08-17 1:45 ` ruansy.fnst [this message]
2021-08-20 16:06 ` Dan Williams
2021-08-20 20:19 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 3/9] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2021-08-06 1:00 ` Jane Chu
2021-08-20 16:54 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 4/9] pmem, mm: Implement ->memory_failure in pmem driver Shiyang Ruan
2021-08-20 20:51 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 5/9] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2021-08-06 0:59 ` Jane Chu
2021-08-20 22:40 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 6/9] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2021-08-06 0:50 ` Jane Chu
2021-08-20 22:56 ` Dan Williams
2021-08-20 22:59 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 7/9] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan
2021-08-20 23:46 ` Dan Williams
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 8/9] md: Implement dax_holder_operations Shiyang Ruan
2021-08-06 0:48 ` Jane Chu
2021-08-17 1:59 ` ruansy.fnst
2021-07-30 10:01 ` [dm-devel] [PATCH RESEND v6 9/9] fsdax: add exception for reflinked files Shiyang Ruan
2021-08-06 0:46 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB292042C10A7AA95CB6862F08F4FE9@OSBPR01MB2920.jpnprd01.prod.outlook.com \
--to=ruansy.fnst@fujitsu.com \
--cc=agk@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=jane.chu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).