* [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock()
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
@ 2020-02-23 23:17 ` Jules Irenge
0 siblings, 0 replies; only message in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
To: boqun.feng
Cc: jbi.octave, linux-kernel, Sudeep Dutt, Ashutosh Dixit,
Vinod Koul, Dan Williams,
open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM
Sparse reports a warning dma_cookie_t mic_dma_tx_submit_unlock()
warning: context imbalance in mic_dma_tx_submit_unlock()
- unexpected unlock
The root cause is the missing annotation at mic_dma_tx_submit_unlock()
Add the missing annotation __releases(&mic_ch->prep_lock)
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/dma/mic_x100_dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
index fea8608a7810..d15c41151d09 100644
--- a/drivers/dma/mic_x100_dma.c
+++ b/drivers/dma/mic_x100_dma.c
@@ -236,6 +236,7 @@ static inline void mic_dma_update_pending(struct mic_dma_chan *ch)
}
static dma_cookie_t mic_dma_tx_submit_unlock(struct dma_async_tx_descriptor *tx)
+ __releases(&mic_ch->prep_lock)
{
struct mic_dma_chan *mic_ch = to_mic_dma_chan(tx->chan);
dma_cookie_t cookie;
--
2.24.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-23 23:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <0/30>
[not found] ` <20200223231711.157699-1-jbi.octave@gmail.com>
2020-02-23 23:17 ` [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock() Jules Irenge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).