From: David Marchand <david.marchand@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: Jim Harris <james.r.harris@intel.com>, dev <dev@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Zhihong Wang <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file
Date: Tue, 20 Aug 2019 15:08:17 +0200 [thread overview]
Message-ID: <CAJFAV8xEwLYh-Sv-m2VecE-r+=2CUBWnRWO=n7MhLygPKAA+JQ@mail.gmail.com> (raw)
In-Reply-To: <20190820051417.GA12986@___>
On Tue, Aug 20, 2019 at 7:16 AM Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> On Mon, Aug 19, 2019 at 05:58:08AM -0700, Jim Harris wrote:
> > This function is declared __rte_always_inline so it
> > seems unnecessary to include it in the map file. In
> > addition, it was included in the EXPERIMENTAL section
> > even though the function itself is not marked
> > __rte_experimental.
> >
> > Found by check-experimental-syms.sh when trying to compile
> > DPDK with -finstrument-functions.
> >
> > Signed-off-by: Jim Harris <james.r.harris@intel.com>
> > ---
> > lib/librte_vhost/rte_vhost_version.map | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map
> > index 5f1d4a75c..4908b9b21 100644
> > --- a/lib/librte_vhost/rte_vhost_version.map
> > +++ b/lib/librte_vhost/rte_vhost_version.map
> > @@ -82,7 +82,6 @@ EXPERIMENTAL {
> > rte_vhost_crypto_fetch_requests;
> > rte_vhost_crypto_finalize_requests;
> > rte_vhost_crypto_set_zero_copy;
> > - rte_vhost_va_from_guest_pa;
> > rte_vhost_host_notifier_ctrl;
> > rte_vdpa_relay_vring_used;
> > rte_vhost_extern_callback_register;
> >
>
> It might be better to mark this function with __rte_experimental
> to fix the build with -finstrument-functions, as in this way we can
> also get warned when using it with ALLOW_EXPERIMENTAL_API undefined.
> And we can have another patch to promote it to stable.
+1.
--
David Marchand
prev parent reply other threads:[~2019-08-20 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 12:58 [dpdk-dev] [PATCH] vhost: remove rte_vhost_va_from_guest_pa from map file Jim Harris
2019-08-20 5:14 ` Tiwei Bie
2019-08-20 13:08 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xEwLYh-Sv-m2VecE-r+=2CUBWnRWO=n7MhLygPKAA+JQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).