* [PATCH libdrm 0/3] remove build warnings for exynos
[not found] <CGME20170331033036epcas5p40d5c3f7244c93cf9b3088e27b53ec9db@epcas5p4.samsung.com>
@ 2017-03-31 3:30 ` Seung-Woo Kim
[not found] ` <CGME20170331033036epcas5p43ab05758c1a16c8b754d65b5d8578c43@epcas5p4.samsung.com>
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Seung-Woo Kim @ 2017-03-31 3:30 UTC (permalink / raw)
To: dri-devel, inki.dae, emil.l.velikov; +Cc: tjakobi, sw0312.kim, robclark
For exynos module for libdrm, there are some build warnings, so this patch
series remove them.
Seung-Woo Kim (3):
exynos: fix type-punned pointer build warning
exynos/fimg2d: remove unused-function build warning
tests/exynos: remove unused-function build warning
exynos/exynos_drm.c | 2 +-
exynos/exynos_fimg2d.c | 14 --------------
tests/exynos/exynos_fimg2d_test.c | 4 +++-
3 files changed, 4 insertions(+), 16 deletions(-)
--
1.7.4.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH libdrm 1/3] exynos: fix type-punned pointer build warning
[not found] ` <CGME20170331033036epcas5p43ab05758c1a16c8b754d65b5d8578c43@epcas5p4.samsung.com>
@ 2017-03-31 3:30 ` Seung-Woo Kim
2017-03-31 9:58 ` Tobias Jakobi
0 siblings, 1 reply; 7+ messages in thread
From: Seung-Woo Kim @ 2017-03-31 3:30 UTC (permalink / raw)
To: dri-devel, inki.dae, emil.l.velikov; +Cc: tjakobi, sw0312.kim, robclark
As like the commit ecc2a097294d ("xf86drm: Fix type-punned pointer
build warning"), this fixes following build warning.
exynos_drm.c: In function 'exynos_handle_event':
exynos_drm.c:420:15: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
e = (struct drm_event *) &buffer[i];
^
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
exynos/exynos_drm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/exynos/exynos_drm.c b/exynos/exynos_drm.c
index b961e52..f6204f1 100644
--- a/exynos/exynos_drm.c
+++ b/exynos/exynos_drm.c
@@ -417,7 +417,7 @@ exynos_handle_event(struct exynos_device *dev, struct exynos_event_context *ctx)
i = 0;
while (i < len) {
- e = (struct drm_event *) &buffer[i];
+ e = (struct drm_event *)(buffer + i);
switch (e->type) {
case DRM_EVENT_VBLANK:
if (evctx->version < 1 ||
--
1.7.4.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH libdrm 2/3] exynos/fimg2d: remove unused-function build warning
[not found] ` <CGME20170331033036epcas5p48e6a32ec3de74fa6f3101476d1c43bef@epcas5p4.samsung.com>
@ 2017-03-31 3:30 ` Seung-Woo Kim
2017-03-31 9:56 ` Tobias Jakobi
0 siblings, 1 reply; 7+ messages in thread
From: Seung-Woo Kim @ 2017-03-31 3:30 UTC (permalink / raw)
To: dri-devel, inki.dae, emil.l.velikov; +Cc: tjakobi, sw0312.kim, robclark
The function g2d_reset() is not anymore used after the commit
e3c97d1a2473 ("exynos/fimg2d: add g2d_validate_xyz() functions"),
so it should be removed.
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
exynos/exynos_fimg2d.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
index 7f1d105..61340c3 100644
--- a/exynos/exynos_fimg2d.c
+++ b/exynos/exynos_fimg2d.c
@@ -293,20 +293,6 @@ static void g2d_set_direction(struct g2d_context *ctx,
}
/*
- * g2d_reset - reset fimg2d hardware.
- *
- * @ctx: a pointer to g2d_context structure.
- *
- */
-static void g2d_reset(struct g2d_context *ctx)
-{
- ctx->cmd_nr = 0;
- ctx->cmd_buf_nr = 0;
-
- g2d_add_cmd(ctx, SOFT_RESET_REG, 0x01);
-}
-
-/*
* g2d_flush - submit all commands and values in user side command buffer
* to command queue aware of fimg2d dma.
*
--
1.7.4.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH libdrm 3/3] tests/exynos: remove unused-function build warning
[not found] ` <CGME20170331033037epcas5p461fb6bc9ee12cfc2247a3ab4481aaf54@epcas5p4.samsung.com>
@ 2017-03-31 3:30 ` Seung-Woo Kim
0 siblings, 0 replies; 7+ messages in thread
From: Seung-Woo Kim @ 2017-03-31 3:30 UTC (permalink / raw)
To: dri-devel, inki.dae, emil.l.velikov; +Cc: tjakobi, sw0312.kim, robclark
The function g2d_blend_test() is blocked to call because of
feature unsafety. This patch blocks with proper feature name
and also blocks the function itself to remove build warning.
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
tests/exynos/exynos_fimg2d_test.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c
index 797fb6e..3495c62 100644
--- a/tests/exynos/exynos_fimg2d_test.c
+++ b/tests/exynos/exynos_fimg2d_test.c
@@ -523,6 +523,7 @@ fail:
return 0;
}
+#if EXYNOS_G2D_USERPTR_TEST
static int g2d_blend_test(struct exynos_device *dev,
struct exynos_bo *src,
struct exynos_bo *dst,
@@ -621,6 +622,7 @@ fail:
return 0;
}
+#endif
static int g2d_checkerboard_test(struct exynos_device *dev,
struct exynos_bo *src,
@@ -864,7 +866,7 @@ int main(int argc, char **argv)
*
* Disable the test for now, until the kernel code has been sanitized.
*/
-#if 0
+#if EXYNOS_G2D_USERPTR_TEST
ret = g2d_blend_test(dev, src, bo, G2D_IMGBUF_USERPTR);
if (ret < 0)
fprintf(stderr, "failed to test blend operation.\n");
--
1.7.4.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH libdrm 2/3] exynos/fimg2d: remove unused-function build warning
2017-03-31 3:30 ` [PATCH libdrm 2/3] exynos/fimg2d: remove unused-function " Seung-Woo Kim
@ 2017-03-31 9:56 ` Tobias Jakobi
0 siblings, 0 replies; 7+ messages in thread
From: Tobias Jakobi @ 2017-03-31 9:56 UTC (permalink / raw)
To: Seung-Woo Kim, dri-devel, inki.dae, emil.l.velikov; +Cc: robclark
Hello Seung-Woo,
looks good to me. Also, g2d_reset() never worked in the first place,
since the kernel driver rejects writes to SOFT_RESET_REG.
Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
With best wishes,
Tobias
Seung-Woo Kim wrote:
> The function g2d_reset() is not anymore used after the commit
> e3c97d1a2473 ("exynos/fimg2d: add g2d_validate_xyz() functions"),
> so it should be removed.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> exynos/exynos_fimg2d.c | 14 --------------
> 1 files changed, 0 insertions(+), 14 deletions(-)
>
> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
> index 7f1d105..61340c3 100644
> --- a/exynos/exynos_fimg2d.c
> +++ b/exynos/exynos_fimg2d.c
> @@ -293,20 +293,6 @@ static void g2d_set_direction(struct g2d_context *ctx,
> }
>
> /*
> - * g2d_reset - reset fimg2d hardware.
> - *
> - * @ctx: a pointer to g2d_context structure.
> - *
> - */
> -static void g2d_reset(struct g2d_context *ctx)
> -{
> - ctx->cmd_nr = 0;
> - ctx->cmd_buf_nr = 0;
> -
> - g2d_add_cmd(ctx, SOFT_RESET_REG, 0x01);
> -}
> -
> -/*
> * g2d_flush - submit all commands and values in user side command buffer
> * to command queue aware of fimg2d dma.
> *
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH libdrm 1/3] exynos: fix type-punned pointer build warning
2017-03-31 3:30 ` [PATCH libdrm 1/3] exynos: fix type-punned pointer build warning Seung-Woo Kim
@ 2017-03-31 9:58 ` Tobias Jakobi
0 siblings, 0 replies; 7+ messages in thread
From: Tobias Jakobi @ 2017-03-31 9:58 UTC (permalink / raw)
To: Seung-Woo Kim, dri-devel, inki.dae, emil.l.velikov; +Cc: robclark
Hello Seung-Woo,
Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
With best wishes,
Tobias
Seung-Woo Kim wrote:
> As like the commit ecc2a097294d ("xf86drm: Fix type-punned pointer
> build warning"), this fixes following build warning.
>
> exynos_drm.c: In function 'exynos_handle_event':
> exynos_drm.c:420:15: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
> e = (struct drm_event *) &buffer[i];
> ^
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> exynos/exynos_drm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/exynos/exynos_drm.c b/exynos/exynos_drm.c
> index b961e52..f6204f1 100644
> --- a/exynos/exynos_drm.c
> +++ b/exynos/exynos_drm.c
> @@ -417,7 +417,7 @@ exynos_handle_event(struct exynos_device *dev, struct exynos_event_context *ctx)
>
> i = 0;
> while (i < len) {
> - e = (struct drm_event *) &buffer[i];
> + e = (struct drm_event *)(buffer + i);
> switch (e->type) {
> case DRM_EVENT_VBLANK:
> if (evctx->version < 1 ||
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH libdrm 0/3] remove build warnings for exynos
2017-03-31 3:30 ` [PATCH libdrm 0/3] remove build warnings for exynos Seung-Woo Kim
` (2 preceding siblings ...)
[not found] ` <CGME20170331033037epcas5p461fb6bc9ee12cfc2247a3ab4481aaf54@epcas5p4.samsung.com>
@ 2017-04-03 16:28 ` Emil Velikov
3 siblings, 0 replies; 7+ messages in thread
From: Emil Velikov @ 2017-04-03 16:28 UTC (permalink / raw)
To: Seung-Woo Kim; +Cc: Tobias Jakobi, Rob Clark, ML dri-devel
On 31 March 2017 at 04:30, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
> For exynos module for libdrm, there are some build warnings, so this patch
> series remove them.
>
R-b and pushed the series.
Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-03 16:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170331033036epcas5p40d5c3f7244c93cf9b3088e27b53ec9db@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 0/3] remove build warnings for exynos Seung-Woo Kim
[not found] ` <CGME20170331033036epcas5p43ab05758c1a16c8b754d65b5d8578c43@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 1/3] exynos: fix type-punned pointer build warning Seung-Woo Kim
2017-03-31 9:58 ` Tobias Jakobi
[not found] ` <CGME20170331033036epcas5p48e6a32ec3de74fa6f3101476d1c43bef@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 2/3] exynos/fimg2d: remove unused-function " Seung-Woo Kim
2017-03-31 9:56 ` Tobias Jakobi
[not found] ` <CGME20170331033037epcas5p461fb6bc9ee12cfc2247a3ab4481aaf54@epcas5p4.samsung.com>
2017-03-31 3:30 ` [PATCH libdrm 3/3] tests/exynos: " Seung-Woo Kim
2017-04-03 16:28 ` [PATCH libdrm 0/3] remove build warnings for exynos Emil Velikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).