* [PATCH v2] gpu: ipu-v3: ipu-dc: Remove unused 'di' variable
@ 2017-09-17 1:03 Fabio Estevam
2017-10-04 10:20 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2017-09-17 1:03 UTC (permalink / raw)
To: p.zabel; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
The 'di' variable is never used inside ipu_dc_enable_channel(),
so just remove it.
This fixes the following build warning with W=1:
drivers/gpu/ipu-v3/ipu-dc.c: In function 'ipu_dc_enable_channel':
drivers/gpu/ipu-v3/ipu-dc.c:252:6: warning: variable 'di' set but not used [-Wunused-but-set-variable]
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Changes since v1:
- Fix a typo in the function name in the commit log.
drivers/gpu/ipu-v3/ipu-dc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
index 7a4b836..49bfe6e 100644
--- a/drivers/gpu/ipu-v3/ipu-dc.c
+++ b/drivers/gpu/ipu-v3/ipu-dc.c
@@ -249,11 +249,8 @@ EXPORT_SYMBOL_GPL(ipu_dc_enable);
void ipu_dc_enable_channel(struct ipu_dc *dc)
{
- int di;
u32 reg;
- di = dc->di;
-
reg = readl(dc->base + DC_WR_CH_CONF);
reg |= DC_WR_CH_CONF_PROG_TYPE_NORMAL;
writel(reg, dc->base + DC_WR_CH_CONF);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] gpu: ipu-v3: ipu-dc: Remove unused 'di' variable
2017-09-17 1:03 [PATCH v2] gpu: ipu-v3: ipu-dc: Remove unused 'di' variable Fabio Estevam
@ 2017-10-04 10:20 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2017-10-04 10:20 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, dri-devel
On Sat, 2017-09-16 at 22:03 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The 'di' variable is never used inside ipu_dc_enable_channel(),
> so just remove it.
>
> This fixes the following build warning with W=1:
>
> drivers/gpu/ipu-v3/ipu-dc.c: In function 'ipu_dc_enable_channel':
> drivers/gpu/ipu-v3/ipu-dc.c:252:6: warning: variable 'di' set but not
> used [-Wunused-but-set-variable]
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Thank you, applied to imx-drm/next.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-04 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-17 1:03 [PATCH v2] gpu: ipu-v3: ipu-dc: Remove unused 'di' variable Fabio Estevam
2017-10-04 10:20 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).