* [PATCH] drm/rockchip: Add implicit fencing support for planes
@ 2018-11-30 10:24 Heiko Stuebner
2018-12-12 14:49 ` Neil Armstrong
2018-12-12 16:10 ` Heiko Stuebner
0 siblings, 2 replies; 3+ messages in thread
From: Heiko Stuebner @ 2018-11-30 10:24 UTC (permalink / raw)
To: dri-devel; +Cc: yuq825
Render like lima will attach a fence to the framebuffer dma_buf,
so the display driver should wait for it to finish before showing
the framebufferto prevent tearing.
Generally tested on rk3188, rk3288, rk3328 and rk3399 and
together with an actual lima-based kmscube on rk3188 and rk3328.
Suggested-by: Qiang Yu <yuq825@gmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index fb70fb486fbf..db8358e6d230 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -18,6 +18,7 @@
#include <drm/drm_crtc.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_flip_work.h>
+#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_plane_helper.h>
#ifdef CONFIG_DRM_ANALOGIX_DP
#include <drm/bridge/analogix_dp.h>
@@ -823,6 +824,7 @@ static const struct drm_plane_helper_funcs plane_helper_funcs = {
.atomic_check = vop_plane_atomic_check,
.atomic_update = vop_plane_atomic_update,
.atomic_disable = vop_plane_atomic_disable,
+ .prepare_fb = drm_gem_fb_prepare_fb,
};
static const struct drm_plane_funcs vop_plane_funcs = {
--
2.18.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/rockchip: Add implicit fencing support for planes
2018-11-30 10:24 [PATCH] drm/rockchip: Add implicit fencing support for planes Heiko Stuebner
@ 2018-12-12 14:49 ` Neil Armstrong
2018-12-12 16:10 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2018-12-12 14:49 UTC (permalink / raw)
To: Heiko Stuebner, dri-devel; +Cc: yuq825
On 30/11/2018 11:24, Heiko Stuebner wrote:
> Render like lima will attach a fence to the framebuffer dma_buf,
> so the display driver should wait for it to finish before showing
> the framebufferto prevent tearing.
>
> Generally tested on rk3188, rk3288, rk3328 and rk3399 and
> together with an actual lima-based kmscube on rk3188 and rk3328.
>
> Suggested-by: Qiang Yu <yuq825@gmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index fb70fb486fbf..db8358e6d230 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -18,6 +18,7 @@
> #include <drm/drm_crtc.h>
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_flip_work.h>
> +#include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_plane_helper.h>
> #ifdef CONFIG_DRM_ANALOGIX_DP
> #include <drm/bridge/analogix_dp.h>
> @@ -823,6 +824,7 @@ static const struct drm_plane_helper_funcs plane_helper_funcs = {
> .atomic_check = vop_plane_atomic_check,
> .atomic_update = vop_plane_atomic_update,
> .atomic_disable = vop_plane_atomic_disable,
> + .prepare_fb = drm_gem_fb_prepare_fb,
> };
>
> static const struct drm_plane_funcs vop_plane_funcs = {
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/rockchip: Add implicit fencing support for planes
2018-11-30 10:24 [PATCH] drm/rockchip: Add implicit fencing support for planes Heiko Stuebner
2018-12-12 14:49 ` Neil Armstrong
@ 2018-12-12 16:10 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2018-12-12 16:10 UTC (permalink / raw)
To: dri-devel; +Cc: yuq825
Am Freitag, 30. November 2018, 11:24:49 CET schrieb Heiko Stuebner:
> Render like lima will attach a fence to the framebuffer dma_buf,
> so the display driver should wait for it to finish before showing
> the framebufferto prevent tearing.
>
> Generally tested on rk3188, rk3288, rk3328 and rk3399 and
> together with an actual lima-based kmscube on rk3188 and rk3328.
>
> Suggested-by: Qiang Yu <yuq825@gmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
applied to drm-misc-next with Neils Reviewed-by
Thanks
Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-12 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-30 10:24 [PATCH] drm/rockchip: Add implicit fencing support for planes Heiko Stuebner
2018-12-12 14:49 ` Neil Armstrong
2018-12-12 16:10 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).