[PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

[PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

[Adam Ford]

Two separate build warnings were reported.  One from an
uninitialized variable, and the other from returning 0
instead of NULL from a pointer.

Fixes: 059c53e877ca ("drm/bridge: imx: add driver for HDMI TX Parallel Video Interface")
Reported-by: nathan@kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402062134.a6CqAt3s-lkp@intel.com/
Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
index a76b7669fe8a..f2a09c879e3d 100644
--- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
+++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
@@ -57,7 +57,7 @@ static void imx8mp_hdmi_pvi_bridge_enable(struct drm_bridge *bridge,
 	const struct drm_display_mode *mode;
 	struct drm_crtc_state *crtc_state;
 	struct drm_connector *connector;
-	u32 bus_flags, val;
+	u32 bus_flags = 0, val;
 
 	connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
 	conn_state = drm_atomic_get_new_connector_state(state, connector);
@@ -110,7 +110,7 @@ imx8mp_hdmi_pvi_bridge_get_input_bus_fmts(struct drm_bridge *bridge,
 	struct drm_bridge_state *next_state;
 
 	if (!next_bridge->funcs->atomic_get_input_bus_fmts)
-		return 0;
+		return NULL;
 
 	next_state = drm_atomic_get_new_bridge_state(crtc_state->state,
 						     next_bridge);
-- 
2.43.0

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

[Neil Armstrong]

On 07/02/2024 01:23, Adam Ford wrote:
> Two separate build warnings were reported.  One from an
> uninitialized variable, and the other from returning 0
> instead of NULL from a pointer.
> 
> Fixes: 059c53e877ca ("drm/bridge: imx: add driver for HDMI TX Parallel Video Interface")
> Reported-by: nathan@kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402062134.a6CqAt3s-lkp@intel.com/
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
> index a76b7669fe8a..f2a09c879e3d 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c
> @@ -57,7 +57,7 @@ static void imx8mp_hdmi_pvi_bridge_enable(struct drm_bridge *bridge,
>   	const struct drm_display_mode *mode;
>   	struct drm_crtc_state *crtc_state;
>   	struct drm_connector *connector;
> -	u32 bus_flags, val;
> +	u32 bus_flags = 0, val;
>   
>   	connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
>   	conn_state = drm_atomic_get_new_connector_state(state, connector);
> @@ -110,7 +110,7 @@ imx8mp_hdmi_pvi_bridge_get_input_bus_fmts(struct drm_bridge *bridge,
>   	struct drm_bridge_state *next_state;
>   
>   	if (!next_bridge->funcs->atomic_get_input_bus_fmts)
> -		return 0;
> +		return NULL;
>   
>   	next_state = drm_atomic_get_new_bridge_state(crtc_state->state,
>   						     next_bridge);

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

[Fabio Estevam]

Hi Adam,

On Tue, Feb 6, 2024 at 9:23 PM Adam Ford <aford173@gmail.com> wrote:
>
> Two separate build warnings were reported.  One from an
> uninitialized variable, and the other from returning 0
> instead of NULL from a pointer.
>
> Fixes: 059c53e877ca ("drm/bridge: imx: add driver for HDMI TX Parallel Video Interface")
> Reported-by: nathan@kernel.org

The Reported-by line format can be improved:

Reported-by: Nathan Chancellor <nathan@kernel.org>

Thanks

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

[Neil Armstrong]

On 07/02/2024 10:22, Fabio Estevam wrote:
> Hi Adam,
> 
> On Tue, Feb 6, 2024 at 9:23 PM Adam Ford <aford173@gmail.com> wrote:
>>
>> Two separate build warnings were reported.  One from an
>> uninitialized variable, and the other from returning 0
>> instead of NULL from a pointer.
>>
>> Fixes: 059c53e877ca ("drm/bridge: imx: add driver for HDMI TX Parallel Video Interface")
>> Reported-by: nathan@kernel.org
> 
> The Reported-by line format can be improved:
> 
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> 
> Thanks

Fixed while applying,

Thanks,
Neil

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

[Neil Armstrong]

Hi,

On Tue, 06 Feb 2024 18:23:04 -0600, Adam Ford wrote:
> Two separate build warnings were reported.  One from an
> uninitialized variable, and the other from returning 0
> instead of NULL from a pointer.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c4ae9fd0de44832cb01d36af14bfc7783472e631

-- 
Neil

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

[Adam Ford]

On Wed, Feb 7, 2024 at 3:24 AM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> On 07/02/2024 10:22, Fabio Estevam wrote:
> > Hi Adam,
> >
> > On Tue, Feb 6, 2024 at 9:23 PM Adam Ford <aford173@gmail.com> wrote:
> >>
> >> Two separate build warnings were reported.  One from an
> >> uninitialized variable, and the other from returning 0
> >> instead of NULL from a pointer.
> >>
> >> Fixes: 059c53e877ca ("drm/bridge: imx: add driver for HDMI TX Parallel Video Interface")
> >> Reported-by: nathan@kernel.org
> >
> > The Reported-by line format can be improved:
> >
Sorry about .that

> > Reported-by: Nathan Chancellor <nathan@kernel.org>
> >
> > Thanks
>
> Fixed while applying,

Thank you!

adam
>
> Thanks,
> Neil