[PATCH] drm/cma: Fix compile fail due to fomat->format typo

[PATCH] drm/cma: Fix compile fail due to fomat->format typo

[ville.syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Apparently my arm .config had reverted to CMA=n at some point, so I
failed to notice that I typoed the code. Fix it up so that the
cma helper will compile again.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Fixes: ca984a998ad3 ("drm/fb_cma_helper: Replace drm_format_info() with fb->format")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index aab4465307ed..591f30ebc42a 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -309,7 +309,7 @@ static void drm_fb_cma_describe(struct drm_framebuffer *fb, struct seq_file *m)
 	seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width, fb->height,
 			(char *)&fb->format->format);
 
-	for (i = 0; i < fb->fomat->num_planes; i++) {
+	for (i = 0; i < fb->format->num_planes; i++) {
 		seq_printf(m, "   %d: offset=%d pitch=%d, obj: ",
 				i, fb->offsets[i], fb->pitches[i]);
 		drm_gem_cma_describe(fb_cma->obj[i], m);
-- 
2.10.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/cma: Fix compile fail due to fomat->format typo

[Laurent Pinchart]

Hi Ville,

Thank you for the patch.

On Thursday 15 Dec 2016 16:29:27 ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Apparently my arm .config had reverted to CMA=n at some point, so I
> failed to notice that I typoed the code. Fix it up so that the
> cma helper will compile again.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Fixes: ca984a998ad3 ("drm/fb_cma_helper: Replace drm_format_info() with
> fb->format")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

The kbuild test bot caught this pretty fast, but it was too late as the patch 
was already in a stable branch of a shared tree. Don't you have a git tree 
covered by the bot that you could push patches to during development ?

> ---
>  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> b/drivers/gpu/drm/drm_fb_cma_helper.c index aab4465307ed..591f30ebc42a
> 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -309,7 +309,7 @@ static void drm_fb_cma_describe(struct drm_framebuffer
> *fb, struct seq_file *m) seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width,
> fb->height,
>  			(char *)&fb->format->format);
> 
> -	for (i = 0; i < fb->fomat->num_planes; i++) {
> +	for (i = 0; i < fb->format->num_planes; i++) {
>  		seq_printf(m, "   %d: offset=%d pitch=%d, obj: ",
>  				i, fb->offsets[i], fb->pitches[i]);
>  		drm_gem_cma_describe(fb_cma->obj[i], m);

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/cma: Fix compile fail due to fomat->format typo

[Ville Syrjälä]

On Thu, Dec 15, 2016 at 04:31:58PM +0200, Laurent Pinchart wrote:
> Hi Ville,
> 
> Thank you for the patch.
> 
> On Thursday 15 Dec 2016 16:29:27 ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Apparently my arm .config had reverted to CMA=n at some point, so I
> > failed to notice that I typoed the code. Fix it up so that the
> > cma helper will compile again.
> > 
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Fixes: ca984a998ad3 ("drm/fb_cma_helper: Replace drm_format_info() with
> > fb->format")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> The kbuild test bot caught this pretty fast, but it was too late as the patch 
> was already in a stable branch of a shared tree. Don't you have a git tree 
> covered by the bot that you could push patches to during development ?

I seem to recall getting 0day reports for my github repo at some point
in the past. But maybe I imagined it.

Fengguang, assuming 0day has bandwidth for it adding my repo [1] to your
list might be nice. I tend to push most non-trivial patch series there
when I post the patches.

[1] git://github.com/vsyrjala/linux.git

> 
> > ---
> >  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> > b/drivers/gpu/drm/drm_fb_cma_helper.c index aab4465307ed..591f30ebc42a
> > 100644
> > --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> > @@ -309,7 +309,7 @@ static void drm_fb_cma_describe(struct drm_framebuffer
> > *fb, struct seq_file *m) seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width,
> > fb->height,
> >  			(char *)&fb->format->format);
> > 
> > -	for (i = 0; i < fb->fomat->num_planes; i++) {
> > +	for (i = 0; i < fb->format->num_planes; i++) {
> >  		seq_printf(m, "   %d: offset=%d pitch=%d, obj: ",
> >  				i, fb->offsets[i], fb->pitches[i]);
> >  		drm_gem_cma_describe(fb_cma->obj[i], m);
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/cma: Fix compile fail due to fomat->format typo

[Ville Syrjälä]

On Thu, Dec 15, 2016 at 04:31:58PM +0200, Laurent Pinchart wrote:
> Hi Ville,
> 
> Thank you for the patch.
> 
> On Thursday 15 Dec 2016 16:29:27 ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Apparently my arm .config had reverted to CMA=n at some point, so I
> > failed to notice that I typoed the code. Fix it up so that the
> > cma helper will compile again.
> > 
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Fixes: ca984a998ad3 ("drm/fb_cma_helper: Replace drm_format_info() with
> > fb->format")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks. Pushed to drm-misc-next.

> 
> The kbuild test bot caught this pretty fast, but it was too late as the patch 
> was already in a stable branch of a shared tree. Don't you have a git tree 
> covered by the bot that you could push patches to during development ?
> 
> > ---
> >  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> > b/drivers/gpu/drm/drm_fb_cma_helper.c index aab4465307ed..591f30ebc42a
> > 100644
> > --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> > @@ -309,7 +309,7 @@ static void drm_fb_cma_describe(struct drm_framebuffer
> > *fb, struct seq_file *m) seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width,
> > fb->height,
> >  			(char *)&fb->format->format);
> > 
> > -	for (i = 0; i < fb->fomat->num_planes; i++) {
> > +	for (i = 0; i < fb->format->num_planes; i++) {
> >  		seq_printf(m, "   %d: offset=%d pitch=%d, obj: ",
> >  				i, fb->offsets[i], fb->pitches[i]);
> >  		drm_gem_cma_describe(fb_cma->obj[i], m);
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/cma: Fix compile fail due to fomat->format typo

[Jani Nikula]

On Thu, 15 Dec 2016, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Ville,
>
> Thank you for the patch.
>
> On Thursday 15 Dec 2016 16:29:27 ville.syrjala@linux.intel.com wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> 
>> Apparently my arm .config had reverted to CMA=n at some point, so I
>> failed to notice that I typoed the code. Fix it up so that the
>> cma helper will compile again.
>> 
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Fixes: ca984a998ad3 ("drm/fb_cma_helper: Replace drm_format_info() with
>> fb->format")
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> The kbuild test bot caught this pretty fast, but it was too late as the patch 
> was already in a stable branch of a shared tree. Don't you have a git tree 
> covered by the bot that you could push patches to during development ?

It was a randconfig result, so even that doesn't guarantee everything is
caught.

BR,
Jani.



>
>> ---
>>  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
>> b/drivers/gpu/drm/drm_fb_cma_helper.c index aab4465307ed..591f30ebc42a
>> 100644
>> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
>> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
>> @@ -309,7 +309,7 @@ static void drm_fb_cma_describe(struct drm_framebuffer
>> *fb, struct seq_file *m) seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width,
>> fb->height,
>>  			(char *)&fb->format->format);
>> 
>> -	for (i = 0; i < fb->fomat->num_planes; i++) {
>> +	for (i = 0; i < fb->format->num_planes; i++) {
>>  		seq_printf(m, "   %d: offset=%d pitch=%d, obj: ",
>>  				i, fb->offsets[i], fb->pitches[i]);
>>  		drm_gem_cma_describe(fb_cma->obj[i], m);

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/cma: Fix compile fail due to fomat->format typo

[Daniel Vetter]

On Thu, Dec 15, 2016 at 04:31:58PM +0200, Laurent Pinchart wrote:
> Hi Ville,
> 
> Thank you for the patch.
> 
> On Thursday 15 Dec 2016 16:29:27 ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Apparently my arm .config had reverted to CMA=n at some point, so I
> > failed to notice that I typoed the code. Fix it up so that the
> > cma helper will compile again.
> > 
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Fixes: ca984a998ad3 ("drm/fb_cma_helper: Replace drm_format_info() with
> > fb->format")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> The kbuild test bot caught this pretty fast, but it was too late as the patch 
> was already in a stable branch of a shared tree. Don't you have a git tree 
> covered by the bot that you could push patches to during development ?

Also there's 3 defconfigs covering drm drivers pretty well, and drm-misc
pushers are supposed to always use those before pushing. Would have caught
this here, because that's how I noticed it.
-Daniel

> 
> > ---
> >  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> > b/drivers/gpu/drm/drm_fb_cma_helper.c index aab4465307ed..591f30ebc42a
> > 100644
> > --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> > @@ -309,7 +309,7 @@ static void drm_fb_cma_describe(struct drm_framebuffer
> > *fb, struct seq_file *m) seq_printf(m, "fb: %dx%d@%4.4s\n", fb->width,
> > fb->height,
> >  			(char *)&fb->format->format);
> > 
> > -	for (i = 0; i < fb->fomat->num_planes; i++) {
> > +	for (i = 0; i < fb->format->num_planes; i++) {
> >  		seq_printf(m, "   %d: offset=%d pitch=%d, obj: ",
> >  				i, fb->offsets[i], fb->pitches[i]);
> >  		drm_gem_cma_describe(fb_cma->obj[i], m);
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/cma: Fix compile fail due to fomat->format typo

[Fengguang Wu]

Hi Ville,

>Fengguang, assuming 0day has bandwidth for it adding my repo [1] to your
>list might be nice. I tend to push most non-trivial patch series there
>when I post the patches.
>
>[1] git://github.com/vsyrjala/linux.git

Sure, bandwidth will never be a limitation. I just added your tree to
the test pool. And sorry for the delay!

Thanks,
Fengguang
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/cma: Fix compile fail due to fomat->format typo

[Ville Syrjälä]

On Wed, Dec 21, 2016 at 11:38:15AM +0800, Fengguang Wu wrote:
> Hi Ville,
> 
> >Fengguang, assuming 0day has bandwidth for it adding my repo [1] to your
> >list might be nice. I tend to push most non-trivial patch series there
> >when I post the patches.
> >
> >[1] git://github.com/vsyrjala/linux.git
> 
> Sure, bandwidth will never be a limitation. I just added your tree to
> the test pool. And sorry for the delay!

Cool Thanks.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel