* [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc
@ 2017-01-31 6:18 Dhinakaran Pandiyan
2017-01-31 8:34 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Dhinakaran Pandiyan @ 2017-01-31 6:18 UTC (permalink / raw)
To: dri-devel; +Cc: Daniel Vetter, intel-gfx, Dhinakaran Pandiyan, Daniel Stone
drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state
but documentation claims otherwise, fix that.
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/drm_atomic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 78b54df..25944ab 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -322,9 +322,8 @@ static s32 __user *get_out_fence_for_crtc(struct drm_atomic_state *state,
* @state: the CRTC whose incoming state to update
* @mode: kernel-internal mode to use for the CRTC, or NULL to disable
*
- * Set a mode (originating from the kernel) on the desired CRTC state. Does
- * not change any other state properties, including enable, active, or
- * mode_changed.
+ * Set a mode (originating from the kernel) on the desired CRTC state and update
+ * the enable property.
*
* RETURNS:
* Zero on success, error code on failure. Cannot return -EDEADLK.
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc
2017-01-31 6:18 [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc Dhinakaran Pandiyan
@ 2017-01-31 8:34 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2017-01-31 8:34 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: Daniel Vetter, intel-gfx, Daniel Stone, dri-devel
On Mon, Jan 30, 2017 at 10:18:38PM -0800, Dhinakaran Pandiyan wrote:
> drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state
> but documentation claims otherwise, fix that.
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Indeed, thanks for the fix, applied to drm-misc.
-Daniel
> ---
> drivers/gpu/drm/drm_atomic.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
> index 78b54df..25944ab 100644
> --- a/drivers/gpu/drm/drm_atomic.c
> +++ b/drivers/gpu/drm/drm_atomic.c
> @@ -322,9 +322,8 @@ static s32 __user *get_out_fence_for_crtc(struct drm_atomic_state *state,
> * @state: the CRTC whose incoming state to update
> * @mode: kernel-internal mode to use for the CRTC, or NULL to disable
> *
> - * Set a mode (originating from the kernel) on the desired CRTC state. Does
> - * not change any other state properties, including enable, active, or
> - * mode_changed.
> + * Set a mode (originating from the kernel) on the desired CRTC state and update
> + * the enable property.
> *
> * RETURNS:
> * Zero on success, error code on failure. Cannot return -EDEADLK.
> --
> 2.7.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-31 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-31 6:18 [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc Dhinakaran Pandiyan
2017-01-31 8:34 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).