* [PATCH] drm/panel: simple: Remove unneeded gpiod NULL check
@ 2017-07-17 0:05 Fabio Estevam
2017-08-18 14:15 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2017-07-17 0:05 UTC (permalink / raw)
To: thierry.reding; +Cc: Fabio Estevam, dri-devel
From: Fabio Estevam <fabio.estevam@nxp.com>
The gpiod API checks for NULL descriptors, so there is no need to
duplicate the check in the driver.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/panel/panel-simple.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 474fa75..8c0d6a6 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -187,8 +187,7 @@ static int panel_simple_unprepare(struct drm_panel *panel)
if (!p->prepared)
return 0;
- if (p->enable_gpio)
- gpiod_set_value_cansleep(p->enable_gpio, 0);
+ gpiod_set_value_cansleep(p->enable_gpio, 0);
regulator_disable(p->supply);
@@ -214,8 +213,7 @@ static int panel_simple_prepare(struct drm_panel *panel)
return err;
}
- if (p->enable_gpio)
- gpiod_set_value_cansleep(p->enable_gpio, 1);
+ gpiod_set_value_cansleep(p->enable_gpio, 1);
if (p->desc->delay.prepare)
msleep(p->desc->delay.prepare);
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/panel: simple: Remove unneeded gpiod NULL check
2017-07-17 0:05 [PATCH] drm/panel: simple: Remove unneeded gpiod NULL check Fabio Estevam
@ 2017-08-18 14:15 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2017-08-18 14:15 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 441 bytes --]
On Sun, Jul 16, 2017 at 09:05:39PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The gpiod API checks for NULL descriptors, so there is no need to
> duplicate the check in the driver.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Applied to drm-misc-next, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-18 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-17 0:05 [PATCH] drm/panel: simple: Remove unneeded gpiod NULL check Fabio Estevam
2017-08-18 14:15 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).