[PATCH] drm: fix typo in drm_gem_get_pages() comment

[PATCH] drm: fix typo in drm_gem_get_pages() comment

[Jordan Crouse]

I spent an embarrassingly long time looking for drm_gem_init_object()
before I realized I was actually looking for drm_gem_object_init().
Fix the typo to keep other poor developers from suffering the same
fate.

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
---
 drivers/gpu/drm/drm_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 7199bba..af62017 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -543,7 +543,7 @@ int drm_gem_create_mmap_offset(struct drm_gem_object *obj)
  * Note that you are not allowed to change gfp-zones during runtime. That is,
  * shmem_read_mapping_page_gfp() must be called with the same gfp_zone(gfp) as
  * set during initialization. If you have special zone constraints, set them
- * after drm_gem_init_object() via mapping_set_gfp_mask(). shmem-core takes care
+ * after drm_gem_object_init() via mapping_set_gfp_mask(). shmem-core takes care
  * to keep pages in the required zone during swap-in.
  */
 struct page **drm_gem_get_pages(struct drm_gem_object *obj)
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: fix typo in drm_gem_get_pages() comment

[Daniel Vetter]

On Tue, Oct 03, 2017 at 09:38:10AM -0600, Jordan Crouse wrote:
> I spent an embarrassingly long time looking for drm_gem_init_object()
> before I realized I was actually looking for drm_gem_object_init().
> Fix the typo to keep other poor developers from suffering the same
> fate.
> 
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>

Yeah would be nice if sphinx would complain a bit louder about symlinks it
can't find ...

Thanks for fixing this, applied.
-Daniel
> ---
>  drivers/gpu/drm/drm_gem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 7199bba..af62017 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -543,7 +543,7 @@ int drm_gem_create_mmap_offset(struct drm_gem_object *obj)
>   * Note that you are not allowed to change gfp-zones during runtime. That is,
>   * shmem_read_mapping_page_gfp() must be called with the same gfp_zone(gfp) as
>   * set during initialization. If you have special zone constraints, set them
> - * after drm_gem_init_object() via mapping_set_gfp_mask(). shmem-core takes care
> + * after drm_gem_object_init() via mapping_set_gfp_mask(). shmem-core takes care
>   * to keep pages in the required zone during swap-in.
>   */
>  struct page **drm_gem_get_pages(struct drm_gem_object *obj)
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH] drm: fix typo in drm_gem_get_pages() comment

[Jani Nikula]

On Wed, 04 Oct 2017, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Oct 03, 2017 at 09:38:10AM -0600, Jordan Crouse wrote:
>> I spent an embarrassingly long time looking for drm_gem_init_object()
>> before I realized I was actually looking for drm_gem_object_init().
>> Fix the typo to keep other poor developers from suffering the same
>> fate.
>> 
>> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
>
> Yeah would be nice if sphinx would complain a bit louder about symlinks it
> can't find ...

But if it did, we'd never have been able to do a gradual conversion to
it!

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel