* [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs
@ 2017-11-14 19:10 Ville Syrjala
2017-11-14 19:10 ` [PATCH 2/3] drm/syncobj: " Ville Syrjala
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Ville Syrjala @ 2017-11-14 19:10 UTC (permalink / raw)
To: dri-devel; +Cc: Daniel Vetter
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Use the correct name for the function argument in the docs.
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_gem_cma_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 88ad88719605..ce67d7d42c66 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -401,7 +401,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_get_unmapped_area);
* drm_gem_cma_print_info() - Print &drm_gem_cma_object info for debugfs
* @p: DRM printer
* @indent: Tab indentation level
- * @gem: GEM object
+ * @obj: GEM object
*
* This function can be used as the &drm_driver->gem_print_info callback.
* It prints paddr and vaddr for use in e.g. debugfs output.
--
2.13.6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] drm/syncobj: Fix kerneldocs
2017-11-14 19:10 [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs Ville Syrjala
@ 2017-11-14 19:10 ` Ville Syrjala
2017-11-14 19:23 ` Marek Olšák
2017-11-15 8:06 ` Christian König
2017-11-14 19:10 ` [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers Ville Syrjala
2017-11-14 20:19 ` [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs Noralf Trønnes
2 siblings, 2 replies; 9+ messages in thread
From: Ville Syrjala @ 2017-11-14 19:10 UTC (permalink / raw)
To: dri-devel; +Cc: Alex Deucher, Dave Airlie, Marek Olšák, Daniel Vetter
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Document the drm_syncobj_get_handle() function parameters.
Cc: Marek Olšák <marek.olsak@amd.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_syncobj.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index 9b733c510cbf..ee2206a67ada 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -302,6 +302,9 @@ EXPORT_SYMBOL(drm_syncobj_create);
/**
* drm_syncobj_get_handle - get a handle from a syncobj
+ * @file_private: drm file private pointer
+ * @syncobj: sync object whose handle to get
+ * @handle: returnd sync object handle
*/
int drm_syncobj_get_handle(struct drm_file *file_private,
struct drm_syncobj *syncobj, u32 *handle)
--
2.13.6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers
2017-11-14 19:10 [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs Ville Syrjala
2017-11-14 19:10 ` [PATCH 2/3] drm/syncobj: " Ville Syrjala
@ 2017-11-14 19:10 ` Ville Syrjala
2017-11-14 19:31 ` Alex Deucher
2017-11-14 20:19 ` [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs Noralf Trønnes
2 siblings, 1 reply; 9+ messages in thread
From: Ville Syrjala @ 2017-11-14 19:10 UTC (permalink / raw)
To: dri-devel; +Cc: Daniel Vetter, Ben Widawsky
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Add the missing kerneldoc for modifiers and modifier_count.
Cc: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
include/drm/drm_plane.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
index fef2786c6cc6..8185e3468a23 100644
--- a/include/drm/drm_plane.h
+++ b/include/drm/drm_plane.h
@@ -474,6 +474,8 @@ enum drm_plane_type {
* @format_types: array of formats supported by this plane
* @format_count: number of formats supported
* @format_default: driver hasn't supplied supported formats for the plane
+ * @modifiers: array of modifiers supported by this plane
+ * @modifier_count: number of modifiers supported
* @old_fb: Temporary tracking of the old fb while a modeset is ongoing. Used by
* drm_mode_set_config_internal() to implement correct refcounting.
* @funcs: helper functions
--
2.13.6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] drm/syncobj: Fix kerneldocs
2017-11-14 19:10 ` [PATCH 2/3] drm/syncobj: " Ville Syrjala
@ 2017-11-14 19:23 ` Marek Olšák
2017-11-15 8:06 ` Christian König
1 sibling, 0 replies; 9+ messages in thread
From: Marek Olšák @ 2017-11-14 19:23 UTC (permalink / raw)
To: Ville Syrjala
Cc: Alex Deucher, Dave Airlie, Marek Olšák, dri-devel,
Daniel Vetter
On Tue, Nov 14, 2017 at 8:10 PM, Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Document the drm_syncobj_get_handle() function parameters.
>
> Cc: Marek Olšák <marek.olsak@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_syncobj.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 9b733c510cbf..ee2206a67ada 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -302,6 +302,9 @@ EXPORT_SYMBOL(drm_syncobj_create);
>
> /**
> * drm_syncobj_get_handle - get a handle from a syncobj
> + * @file_private: drm file private pointer
> + * @syncobj: sync object whose handle to get
> + * @handle: returnd sync object handle
returned
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Marek
> */
> int drm_syncobj_get_handle(struct drm_file *file_private,
> struct drm_syncobj *syncobj, u32 *handle)
> --
> 2.13.6
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers
2017-11-14 19:10 ` [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers Ville Syrjala
@ 2017-11-14 19:31 ` Alex Deucher
2017-11-14 21:05 ` Ville Syrjälä
0 siblings, 1 reply; 9+ messages in thread
From: Alex Deucher @ 2017-11-14 19:31 UTC (permalink / raw)
To: Ville Syrjala; +Cc: Daniel Vetter, Ben Widawsky, Maling list - DRI developers
On Tue, Nov 14, 2017 at 2:10 PM, Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Add the missing kerneldoc for modifiers and modifier_count.
>
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> include/drm/drm_plane.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> index fef2786c6cc6..8185e3468a23 100644
> --- a/include/drm/drm_plane.h
> +++ b/include/drm/drm_plane.h
> @@ -474,6 +474,8 @@ enum drm_plane_type {
> * @format_types: array of formats supported by this plane
> * @format_count: number of formats supported
> * @format_default: driver hasn't supplied supported formats for the plane
> + * @modifiers: array of modifiers supported by this plane
> + * @modifier_count: number of modifiers supported
> * @old_fb: Temporary tracking of the old fb while a modeset is ongoing. Used by
> * drm_mode_set_config_internal() to implement correct refcounting.
> * @funcs: helper functions
> --
> 2.13.6
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs
2017-11-14 19:10 [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs Ville Syrjala
2017-11-14 19:10 ` [PATCH 2/3] drm/syncobj: " Ville Syrjala
2017-11-14 19:10 ` [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers Ville Syrjala
@ 2017-11-14 20:19 ` Noralf Trønnes
2 siblings, 0 replies; 9+ messages in thread
From: Noralf Trønnes @ 2017-11-14 20:19 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: Daniel Vetter
Den 14.11.2017 20.10, skrev Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use the correct name for the function argument in the docs.
>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_gem_cma_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 88ad88719605..ce67d7d42c66 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -401,7 +401,7 @@ EXPORT_SYMBOL_GPL(drm_gem_cma_get_unmapped_area);
> * drm_gem_cma_print_info() - Print &drm_gem_cma_object info for debugfs
> * @p: DRM printer
> * @indent: Tab indentation level
> - * @gem: GEM object
> + * @obj: GEM object
> *
> * This function can be used as the &drm_driver->gem_print_info callback.
> * It prints paddr and vaddr for use in e.g. debugfs output.
Thanks,
Acked-by: Noralf Trønnes <noralf@tronnes.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers
2017-11-14 19:31 ` Alex Deucher
@ 2017-11-14 21:05 ` Ville Syrjälä
2017-11-20 8:03 ` Daniel Vetter
0 siblings, 1 reply; 9+ messages in thread
From: Ville Syrjälä @ 2017-11-14 21:05 UTC (permalink / raw)
To: Alex Deucher; +Cc: Daniel Vetter, Ben Widawsky, Maling list - DRI developers
On Tue, Nov 14, 2017 at 02:31:11PM -0500, Alex Deucher wrote:
> On Tue, Nov 14, 2017 at 2:10 PM, Ville Syrjala
> <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Add the missing kerneldoc for modifiers and modifier_count.
> >
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Series is:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Thanks everyone. Patches 1 and 3 pushed to drm-misc-next.
Looks like patch 2 will have to wait for a drm-next merge.
>
> > ---
> > include/drm/drm_plane.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> > index fef2786c6cc6..8185e3468a23 100644
> > --- a/include/drm/drm_plane.h
> > +++ b/include/drm/drm_plane.h
> > @@ -474,6 +474,8 @@ enum drm_plane_type {
> > * @format_types: array of formats supported by this plane
> > * @format_count: number of formats supported
> > * @format_default: driver hasn't supplied supported formats for the plane
> > + * @modifiers: array of modifiers supported by this plane
> > + * @modifier_count: number of modifiers supported
> > * @old_fb: Temporary tracking of the old fb while a modeset is ongoing. Used by
> > * drm_mode_set_config_internal() to implement correct refcounting.
> > * @funcs: helper functions
> > --
> > 2.13.6
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] drm/syncobj: Fix kerneldocs
2017-11-14 19:10 ` [PATCH 2/3] drm/syncobj: " Ville Syrjala
2017-11-14 19:23 ` Marek Olšák
@ 2017-11-15 8:06 ` Christian König
1 sibling, 0 replies; 9+ messages in thread
From: Christian König @ 2017-11-15 8:06 UTC (permalink / raw)
To: Ville Syrjala, dri-devel
Cc: Alex Deucher, Dave Airlie, Marek Olšák, Daniel Vetter
Am 14.11.2017 um 20:10 schrieb Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Document the drm_syncobj_get_handle() function parameters.
>
> Cc: Marek Olšák <marek.olsak@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
With the typo noted by Marek fixed the patch is Reviewed-by: Christian
König <christian.koenig@amd.com> as well.
> ---
> drivers/gpu/drm/drm_syncobj.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 9b733c510cbf..ee2206a67ada 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -302,6 +302,9 @@ EXPORT_SYMBOL(drm_syncobj_create);
>
> /**
> * drm_syncobj_get_handle - get a handle from a syncobj
> + * @file_private: drm file private pointer
> + * @syncobj: sync object whose handle to get
> + * @handle: returnd sync object handle
> */
> int drm_syncobj_get_handle(struct drm_file *file_private,
> struct drm_syncobj *syncobj, u32 *handle)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers
2017-11-14 21:05 ` Ville Syrjälä
@ 2017-11-20 8:03 ` Daniel Vetter
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2017-11-20 8:03 UTC (permalink / raw)
To: Ville Syrjälä
Cc: Daniel Vetter, Ben Widawsky, Maling list - DRI developers
On Tue, Nov 14, 2017 at 11:05:55PM +0200, Ville Syrjälä wrote:
> On Tue, Nov 14, 2017 at 02:31:11PM -0500, Alex Deucher wrote:
> > On Tue, Nov 14, 2017 at 2:10 PM, Ville Syrjala
> > <ville.syrjala@linux.intel.com> wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Add the missing kerneldoc for modifiers and modifier_count.
> > >
> > > Cc: Ben Widawsky <ben@bwidawsk.net>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Series is:
> > Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> Thanks everyone. Patches 1 and 3 pushed to drm-misc-next.
> Looks like patch 2 will have to wait for a drm-next merge.
Ping Dave to pick it up directly?
-Daniel
>
> >
> > > ---
> > > include/drm/drm_plane.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h
> > > index fef2786c6cc6..8185e3468a23 100644
> > > --- a/include/drm/drm_plane.h
> > > +++ b/include/drm/drm_plane.h
> > > @@ -474,6 +474,8 @@ enum drm_plane_type {
> > > * @format_types: array of formats supported by this plane
> > > * @format_count: number of formats supported
> > > * @format_default: driver hasn't supplied supported formats for the plane
> > > + * @modifiers: array of modifiers supported by this plane
> > > + * @modifier_count: number of modifiers supported
> > > * @old_fb: Temporary tracking of the old fb while a modeset is ongoing. Used by
> > > * drm_mode_set_config_internal() to implement correct refcounting.
> > > * @funcs: helper functions
> > > --
> > > 2.13.6
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Ville Syrjälä
> Intel OTC
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-11-20 8:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 19:10 [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs Ville Syrjala
2017-11-14 19:10 ` [PATCH 2/3] drm/syncobj: " Ville Syrjala
2017-11-14 19:23 ` Marek Olšák
2017-11-15 8:06 ` Christian König
2017-11-14 19:10 ` [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers Ville Syrjala
2017-11-14 19:31 ` Alex Deucher
2017-11-14 21:05 ` Ville Syrjälä
2017-11-20 8:03 ` Daniel Vetter
2017-11-14 20:19 ` [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs Noralf Trønnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).