* [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs
@ 2018-03-22 18:21 Gustavo A. R. Silva
2018-03-22 21:31 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-03-22 18:21 UTC (permalink / raw)
To: Chris Wilson, Zhenyu Wang, Zhi Wang, Jani Nikula,
Joonas Lahtinen, Rodrigo Vivi, David Airlie
Cc: intel-gvt-dev, intel-gfx, dri-devel, linux-kernel, Gustavo A. R. Silva
The checks are misleading and not required [1].
[1] https://lkml.org/lkml/2018/3/19/1792
Addresses-Coverity-ID: 1466017
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/gpu/drm/i915/gvt/scheduler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index 78588ef..b6da223 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -74,7 +74,7 @@ static void sr_oa_regs(struct intel_vgpu_workload *workload,
i915_mmio_reg_offset(EU_PERF_CNTL6),
};
- if (!workload || !reg_state || workload->ring_id != RCS)
+ if (workload->ring_id != RCS)
return;
if (save) {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs
2018-03-22 18:21 [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs Gustavo A. R. Silva
@ 2018-03-22 21:31 ` Chris Wilson
2018-03-23 2:19 ` Zhenyu Wang
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2018-03-22 21:31 UTC (permalink / raw)
To: Zhenyu Wang, Zhi Wang, Jani Nikula, Joonas Lahtinen,
Rodrigo Vivi, David Airlie
Cc: intel-gvt-dev, intel-gfx, dri-devel, linux-kernel, Gustavo A. R. Silva
Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
> The checks are misleading and not required [1].
>
> [1] https://lkml.org/lkml/2018/3/19/1792
>
> Addresses-Coverity-ID: 1466017
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Zhenyu?
-Chris
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs
2018-03-22 21:31 ` Chris Wilson
@ 2018-03-23 2:19 ` Zhenyu Wang
0 siblings, 0 replies; 3+ messages in thread
From: Zhenyu Wang @ 2018-03-23 2:19 UTC (permalink / raw)
To: Chris Wilson
Cc: Gustavo A. R. Silva, David Airlie, intel-gfx, linux-kernel,
dri-devel, Rodrigo Vivi, intel-gvt-dev, Zhi Wang
[-- Attachment #1.1: Type: text/plain, Size: 582 bytes --]
On 2018.03.22 21:31:33 +0000, Chris Wilson wrote:
> Quoting Gustavo A. R. Silva (2018-03-22 18:21:54)
> > The checks are misleading and not required [1].
> >
> > [1] https://lkml.org/lkml/2018/3/19/1792
> >
> > Addresses-Coverity-ID: 1466017
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
Looks good to me, I will pick this up, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-23 2:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-22 18:21 [PATCH] drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs Gustavo A. R. Silva
2018-03-22 21:31 ` Chris Wilson
2018-03-23 2:19 ` Zhenyu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).