* [PATCH] drm/sun41: Fix incorrect return type
@ 2018-07-12 15:50 Sean Paul
2018-07-13 7:01 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Sean Paul @ 2018-07-12 15:50 UTC (permalink / raw)
To: dri-devel; +Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-arm-kernel
We're returning -errno instead of ERR_PTR(-errno).
Fixes: af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling")
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
drivers/gpu/drm/sun4i/sun8i_tcon_top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
index 046f8dd66f90..55fe398d8290 100644
--- a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
+++ b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
@@ -99,7 +99,7 @@ static struct clk_hw *sun8i_tcon_top_register_gate(struct device *dev,
index = of_property_match_string(dev->of_node, "clock-names", parent);
if (index < 0)
- return index;
+ return ERR_PTR(index);
parent_name = of_clk_get_parent_name(dev->of_node, index);
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/sun41: Fix incorrect return type
2018-07-12 15:50 [PATCH] drm/sun41: Fix incorrect return type Sean Paul
@ 2018-07-13 7:01 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2018-07-13 7:01 UTC (permalink / raw)
To: Sean Paul; +Cc: linux-arm-kernel, Chen-Yu Tsai, Jernej Skrabec, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]
Hi Sean,
On Thu, Jul 12, 2018 at 11:50:28AM -0400, Sean Paul wrote:
> We're returning -errno instead of ERR_PTR(-errno).
>
> Fixes: af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling")
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@siol.net>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
I merged a similar patch yesterday, the warning should be gone now.
Thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-13 7:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 15:50 [PATCH] drm/sun41: Fix incorrect return type Sean Paul
2018-07-13 7:01 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).