* [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags @ 2020-03-06 1:42 Manasi Navare 2020-03-06 1:42 ` [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Manasi Navare 2020-03-06 10:30 ` [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Jani Nikula 0 siblings, 2 replies; 8+ messages in thread From: Manasi Navare @ 2020-03-06 1:42 UTC (permalink / raw) To: intel-gfx, dri-devel; +Cc: Manasi Navare, Kazlauskas Nicholas This patch adds defines for the detailed monitor range flags as per the EDID specification. Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Clinton A Taylor <clinton.a.taylor@intel.com> Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> --- include/drm/drm_edid.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index f0b03d401c27..f89c97623845 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -91,6 +91,11 @@ struct detailed_data_string { u8 str[13]; } __attribute__((packed)); +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01 +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 +#define EDID_CVT_SUPPORT_FLAG 0x04 + struct detailed_data_monitor_range { u8 min_vfreq; u8 max_vfreq; -- 2.19.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits 2020-03-06 1:42 [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Manasi Navare @ 2020-03-06 1:42 ` Manasi Navare 2020-03-06 15:02 ` Kazlauskas, Nicholas 2020-03-06 10:30 ` [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Jani Nikula 1 sibling, 1 reply; 8+ messages in thread From: Manasi Navare @ 2020-03-06 1:42 UTC (permalink / raw) To: intel-gfx, dri-devel; +Cc: Manasi Navare, Kazlauskas Nicholas Adaptive Sync is a VESA feature so add a DRM core helper to parse the EDID's detailed descritors to obtain the adaptive sync monitor range. Store this info as part fo drm_display_info so it can be used across all drivers. This part of the code is stripped out of amdgpu's function amdgpu_dm_update_freesync_caps() to make it generic and be used across all DRM drivers v4: * Use is_display_descriptor() (Ville) * Name the monitor range flags (Ville) v3: * Remove the edid parsing restriction for just DP (Nicholas) * Use drm_for_each_detailed_block (Ville) * Make the drm_get_adaptive_sync_range function static (Harry, Jani) v2: * Change vmin and vmax to use u8 (Ville) * Dont store pixel clock since that is just a max dotclock and not related to VRR mode (Manasi) Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Clinton A Taylor <clinton.a.taylor@intel.com> Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> --- drivers/gpu/drm/drm_edid.c | 44 +++++++++++++++++++++++++++++++++++++ include/drm/drm_connector.h | 22 +++++++++++++++++++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ad41764a4ebe..61ed544d9535 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -4938,6 +4938,47 @@ static void drm_parse_cea_ext(struct drm_connector *connector, } } +static +void get_adaptive_sync_range(struct detailed_timing *timing, + void *info_adaptive_sync) +{ + struct drm_adaptive_sync_info *adaptive_sync = info_adaptive_sync; + const struct detailed_non_pixel *data = &timing->data.other_data; + const struct detailed_data_monitor_range *range = &data->data.range; + + if (!is_display_descriptor((const u8 *)timing, EDID_DETAIL_MONITOR_RANGE)) + return; + + /* + * Check for flag range limits only. If flag == 1 then + * no additional timing information provided. + * Default GTF, GTF Secondary curve and CVT are not + * supported + */ + if (range->flags != EDID_RANGE_LIMITS_ONLY_FLAG) + return; + + adaptive_sync->min_vfreq = range->min_vfreq; + adaptive_sync->max_vfreq = range->max_vfreq; +} + +static +void drm_get_adaptive_sync_range(struct drm_connector *connector, + const struct edid *edid) +{ + struct drm_display_info *info = &connector->display_info; + + if (!version_greater(edid, 1, 1)) + return; + + drm_for_each_detailed_block((u8 *)edid, get_adaptive_sync_range, + &info->adaptive_sync); + + DRM_DEBUG_KMS("Adaptive Sync refresh rate range is %d Hz - %d Hz\n", + info->adaptive_sync.min_vfreq, + info->adaptive_sync.max_vfreq); +} + /* A connector has no EDID information, so we've got no EDID to compute quirks from. Reset * all of the values which would have been set from EDID */ @@ -4960,6 +5001,7 @@ drm_reset_display_info(struct drm_connector *connector) memset(&info->hdmi, 0, sizeof(info->hdmi)); info->non_desktop = 0; + memset(&info->adaptive_sync, 0, sizeof(info->adaptive_sync)); } u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid) @@ -4975,6 +5017,8 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP); + drm_get_adaptive_sync_range(connector, edid); + DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop); if (edid->revision < 3) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 0df7a95ca5d9..2b22c0fa42c4 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -254,6 +254,23 @@ enum drm_panel_orientation { DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, }; +/** + * struct drm_adaptive_sync_info - Panel's Adaptive Sync capabilities for + * &drm_display_info + * + * This struct is used to store a Panel's Adaptive Sync capabilities + * as parsed from EDID's detailed monitor range descriptor block. + * + * @min_vfreq: This is the min supported refresh rate in Hz from + * EDID's detailed monitor range. + * @max_vfreq: This is the max supported refresh rate in Hz from + * EDID's detailed monitor range + */ +struct drm_adaptive_sync_info { + u8 min_vfreq; + u8 max_vfreq; +}; + /* * This is a consolidated colorimetry list supported by HDMI and * DP protocol standard. The respective connectors will register @@ -473,6 +490,11 @@ struct drm_display_info { * @non_desktop: Non desktop display (HMD). */ bool non_desktop; + + /** + * @adaptive_sync: Adaptive Sync capabilities of the DP/eDP sink + */ + struct drm_adaptive_sync_info adaptive_sync; }; int drm_display_info_set_bus_formats(struct drm_display_info *info, -- 2.19.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits 2020-03-06 1:42 ` [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Manasi Navare @ 2020-03-06 15:02 ` Kazlauskas, Nicholas 2020-03-06 18:52 ` [Intel-gfx] " Mario Kleiner 0 siblings, 1 reply; 8+ messages in thread From: Kazlauskas, Nicholas @ 2020-03-06 15:02 UTC (permalink / raw) To: Manasi Navare, intel-gfx, dri-devel On 2020-03-05 8:42 p.m., Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this info as part fo drm_display_info so it can be used > across all drivers. > This part of the code is stripped out of amdgpu's function > amdgpu_dm_update_freesync_caps() to make it generic and be used > across all DRM drivers > > v4: > * Use is_display_descriptor() (Ville) > * Name the monitor range flags (Ville) > v3: > * Remove the edid parsing restriction for just DP (Nicholas) > * Use drm_for_each_detailed_block (Ville) > * Make the drm_get_adaptive_sync_range function static (Harry, Jani) > v2: > * Change vmin and vmax to use u8 (Ville) > * Dont store pixel clock since that is just a max dotclock > and not related to VRR mode (Manasi) > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> Looks good to me now. I'm fine with whether we want to rename the flags or not, I don't have much of a preference either way. Series is: Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Regards, Nicholas Kazlauskas > --- > drivers/gpu/drm/drm_edid.c | 44 +++++++++++++++++++++++++++++++++++++ > include/drm/drm_connector.h | 22 +++++++++++++++++++ > 2 files changed, 66 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index ad41764a4ebe..61ed544d9535 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -4938,6 +4938,47 @@ static void drm_parse_cea_ext(struct drm_connector *connector, > } > } > > +static > +void get_adaptive_sync_range(struct detailed_timing *timing, > + void *info_adaptive_sync) > +{ > + struct drm_adaptive_sync_info *adaptive_sync = info_adaptive_sync; > + const struct detailed_non_pixel *data = &timing->data.other_data; > + const struct detailed_data_monitor_range *range = &data->data.range; > + > + if (!is_display_descriptor((const u8 *)timing, EDID_DETAIL_MONITOR_RANGE)) > + return; > + > + /* > + * Check for flag range limits only. If flag == 1 then > + * no additional timing information provided. > + * Default GTF, GTF Secondary curve and CVT are not > + * supported > + */ > + if (range->flags != EDID_RANGE_LIMITS_ONLY_FLAG) > + return; > + > + adaptive_sync->min_vfreq = range->min_vfreq; > + adaptive_sync->max_vfreq = range->max_vfreq; > +} > + > +static > +void drm_get_adaptive_sync_range(struct drm_connector *connector, > + const struct edid *edid) > +{ > + struct drm_display_info *info = &connector->display_info; > + > + if (!version_greater(edid, 1, 1)) > + return; > + > + drm_for_each_detailed_block((u8 *)edid, get_adaptive_sync_range, > + &info->adaptive_sync); > + > + DRM_DEBUG_KMS("Adaptive Sync refresh rate range is %d Hz - %d Hz\n", > + info->adaptive_sync.min_vfreq, > + info->adaptive_sync.max_vfreq); > +} > + > /* A connector has no EDID information, so we've got no EDID to compute quirks from. Reset > * all of the values which would have been set from EDID > */ > @@ -4960,6 +5001,7 @@ drm_reset_display_info(struct drm_connector *connector) > memset(&info->hdmi, 0, sizeof(info->hdmi)); > > info->non_desktop = 0; > + memset(&info->adaptive_sync, 0, sizeof(info->adaptive_sync)); > } > > u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid) > @@ -4975,6 +5017,8 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi > > info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP); > > + drm_get_adaptive_sync_range(connector, edid); > + > DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop); > > if (edid->revision < 3) > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 0df7a95ca5d9..2b22c0fa42c4 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -254,6 +254,23 @@ enum drm_panel_orientation { > DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > }; > > +/** > + * struct drm_adaptive_sync_info - Panel's Adaptive Sync capabilities for > + * &drm_display_info > + * > + * This struct is used to store a Panel's Adaptive Sync capabilities > + * as parsed from EDID's detailed monitor range descriptor block. > + * > + * @min_vfreq: This is the min supported refresh rate in Hz from > + * EDID's detailed monitor range. > + * @max_vfreq: This is the max supported refresh rate in Hz from > + * EDID's detailed monitor range > + */ > +struct drm_adaptive_sync_info { > + u8 min_vfreq; > + u8 max_vfreq; > +}; > + > /* > * This is a consolidated colorimetry list supported by HDMI and > * DP protocol standard. The respective connectors will register > @@ -473,6 +490,11 @@ struct drm_display_info { > * @non_desktop: Non desktop display (HMD). > */ > bool non_desktop; > + > + /** > + * @adaptive_sync: Adaptive Sync capabilities of the DP/eDP sink > + */ > + struct drm_adaptive_sync_info adaptive_sync; > }; > > int drm_display_info_set_bus_formats(struct drm_display_info *info, > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits 2020-03-06 15:02 ` Kazlauskas, Nicholas @ 2020-03-06 18:52 ` Mario Kleiner 0 siblings, 0 replies; 8+ messages in thread From: Mario Kleiner @ 2020-03-06 18:52 UTC (permalink / raw) To: Kazlauskas, Nicholas; +Cc: Manasi Navare, intel-gfx, dri-devel Just as a comment, u8 for max_vfreq in struct drm_adaptive_sync_info might be not very future proof? I just read that ASUS announced a "TUF Gaming VG259QM" monitor which seems to have an adaptive sync range of 48 Hz to 280 Hz, exceeding the max 255 Hz of u8? -mario On Fri, Mar 6, 2020 at 4:02 PM Kazlauskas, Nicholas <nicholas.kazlauskas@amd.com> wrote: > > On 2020-03-05 8:42 p.m., Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > > Store this info as part fo drm_display_info so it can be used > > across all drivers. > > This part of the code is stripped out of amdgpu's function > > amdgpu_dm_update_freesync_caps() to make it generic and be used > > across all DRM drivers > > > > v4: > > * Use is_display_descriptor() (Ville) > > * Name the monitor range flags (Ville) > > v3: > > * Remove the edid parsing restriction for just DP (Nicholas) > > * Use drm_for_each_detailed_block (Ville) > > * Make the drm_get_adaptive_sync_range function static (Harry, Jani) > > v2: > > * Change vmin and vmax to use u8 (Ville) > > * Dont store pixel clock since that is just a max dotclock > > and not related to VRR mode (Manasi) > > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Harry Wentland <harry.wentland@amd.com> > > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> > > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > > Looks good to me now. I'm fine with whether we want to rename the flags > or not, I don't have much of a preference either way. > > Series is: > > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> > > Regards, > Nicholas Kazlauskas > > > --- > > drivers/gpu/drm/drm_edid.c | 44 +++++++++++++++++++++++++++++++++++++ > > include/drm/drm_connector.h | 22 +++++++++++++++++++ > > 2 files changed, 66 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > index ad41764a4ebe..61ed544d9535 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -4938,6 +4938,47 @@ static void drm_parse_cea_ext(struct drm_connector *connector, > > } > > } > > > > +static > > +void get_adaptive_sync_range(struct detailed_timing *timing, > > + void *info_adaptive_sync) > > +{ > > + struct drm_adaptive_sync_info *adaptive_sync = info_adaptive_sync; > > + const struct detailed_non_pixel *data = &timing->data.other_data; > > + const struct detailed_data_monitor_range *range = &data->data.range; > > + > > + if (!is_display_descriptor((const u8 *)timing, EDID_DETAIL_MONITOR_RANGE)) > > + return; > > + > > + /* > > + * Check for flag range limits only. If flag == 1 then > > + * no additional timing information provided. > > + * Default GTF, GTF Secondary curve and CVT are not > > + * supported > > + */ > > + if (range->flags != EDID_RANGE_LIMITS_ONLY_FLAG) > > + return; > > + > > + adaptive_sync->min_vfreq = range->min_vfreq; > > + adaptive_sync->max_vfreq = range->max_vfreq; > > +} > > + > > +static > > +void drm_get_adaptive_sync_range(struct drm_connector *connector, > > + const struct edid *edid) > > +{ > > + struct drm_display_info *info = &connector->display_info; > > + > > + if (!version_greater(edid, 1, 1)) > > + return; > > + > > + drm_for_each_detailed_block((u8 *)edid, get_adaptive_sync_range, > > + &info->adaptive_sync); > > + > > + DRM_DEBUG_KMS("Adaptive Sync refresh rate range is %d Hz - %d Hz\n", > > + info->adaptive_sync.min_vfreq, > > + info->adaptive_sync.max_vfreq); > > +} > > + > > /* A connector has no EDID information, so we've got no EDID to compute quirks from. Reset > > * all of the values which would have been set from EDID > > */ > > @@ -4960,6 +5001,7 @@ drm_reset_display_info(struct drm_connector *connector) > > memset(&info->hdmi, 0, sizeof(info->hdmi)); > > > > info->non_desktop = 0; > > + memset(&info->adaptive_sync, 0, sizeof(info->adaptive_sync)); > > } > > > > u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edid) > > @@ -4975,6 +5017,8 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi > > > > info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP); > > > > + drm_get_adaptive_sync_range(connector, edid); > > + > > DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop); > > > > if (edid->revision < 3) > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > index 0df7a95ca5d9..2b22c0fa42c4 100644 > > --- a/include/drm/drm_connector.h > > +++ b/include/drm/drm_connector.h > > @@ -254,6 +254,23 @@ enum drm_panel_orientation { > > DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, > > }; > > > > +/** > > + * struct drm_adaptive_sync_info - Panel's Adaptive Sync capabilities for > > + * &drm_display_info > > + * > > + * This struct is used to store a Panel's Adaptive Sync capabilities > > + * as parsed from EDID's detailed monitor range descriptor block. > > + * > > + * @min_vfreq: This is the min supported refresh rate in Hz from > > + * EDID's detailed monitor range. > > + * @max_vfreq: This is the max supported refresh rate in Hz from > > + * EDID's detailed monitor range > > + */ > > +struct drm_adaptive_sync_info { > > + u8 min_vfreq; > > + u8 max_vfreq; > > +}; > > + > > /* > > * This is a consolidated colorimetry list supported by HDMI and > > * DP protocol standard. The respective connectors will register > > @@ -473,6 +490,11 @@ struct drm_display_info { > > * @non_desktop: Non desktop display (HMD). > > */ > > bool non_desktop; > > + > > + /** > > + * @adaptive_sync: Adaptive Sync capabilities of the DP/eDP sink > > + */ > > + struct drm_adaptive_sync_info adaptive_sync; > > }; > > > > int drm_display_info_set_bus_formats(struct drm_display_info *info, > > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags 2020-03-06 1:42 [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Manasi Navare 2020-03-06 1:42 ` [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Manasi Navare @ 2020-03-06 10:30 ` Jani Nikula 2020-03-06 18:40 ` Manasi Navare 1 sibling, 1 reply; 8+ messages in thread From: Jani Nikula @ 2020-03-06 10:30 UTC (permalink / raw) To: Manasi Navare, intel-gfx, dri-devel; +Cc: Kazlauskas Nicholas On Thu, 05 Mar 2020, Manasi Navare <manasi.d.navare@intel.com> wrote: > This patch adds defines for the detailed monitor > range flags as per the EDID specification. > > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > --- > include/drm/drm_edid.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index f0b03d401c27..f89c97623845 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -91,6 +91,11 @@ struct detailed_data_string { > u8 str[13]; > } __attribute__((packed)); > > +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > +#define EDID_CVT_SUPPORT_FLAG 0x04 Bikeshed for consideration: drm_edid.h has some macros with DRM_EDID_ prefix, some with EDID_ prefix, and then some with no prefix at all really. Should we start consolidating on something when we add more? BR, Jani. > + > struct detailed_data_monitor_range { > u8 min_vfreq; > u8 max_vfreq; -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags 2020-03-06 10:30 ` [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Jani Nikula @ 2020-03-06 18:40 ` Manasi Navare 2020-03-09 8:35 ` Jani Nikula 0 siblings, 1 reply; 8+ messages in thread From: Manasi Navare @ 2020-03-06 18:40 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx, Kazlauskas Nicholas, dri-devel On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > On Thu, 05 Mar 2020, Manasi Navare <manasi.d.navare@intel.com> wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Harry Wentland <harry.wentland@amd.com> > > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> > > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > > --- > > include/drm/drm_edid.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > > index f0b03d401c27..f89c97623845 100644 > > --- a/include/drm/drm_edid.h > > +++ b/include/drm/drm_edid.h > > @@ -91,6 +91,11 @@ struct detailed_data_string { > > u8 str[13]; > > } __attribute__((packed)); > > > > +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > > +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > > +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > > +#define EDID_CVT_SUPPORT_FLAG 0x04 > > Bikeshed for consideration: > > drm_edid.h has some macros with DRM_EDID_ prefix, some with EDID_ > prefix, and then some with no prefix at all really. Should we start > consolidating on something when we add more? > Yes Jani I did notice the same thing and didnt know which convention to continue to follow but I noticed that majority of the defines were just EDID_ so just used that for these new defines. Is there a particular way you wish to consolidate this and use a specific convention for #defines? I can atleast change these new defines based on a preferred convention and then separate patches to change the rest in .h and corresponding usages in .c files. Regards Manasi > BR, > Jani. > > > > + > > struct detailed_data_monitor_range { > > u8 min_vfreq; > > u8 max_vfreq; > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags 2020-03-06 18:40 ` Manasi Navare @ 2020-03-09 8:35 ` Jani Nikula 2020-03-09 20:34 ` Manasi Navare 0 siblings, 1 reply; 8+ messages in thread From: Jani Nikula @ 2020-03-09 8:35 UTC (permalink / raw) To: Manasi Navare; +Cc: intel-gfx, Kazlauskas Nicholas, dri-devel On Fri, 06 Mar 2020, Manasi Navare <manasi.d.navare@intel.com> wrote: > On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: >> On Thu, 05 Mar 2020, Manasi Navare <manasi.d.navare@intel.com> wrote: >> > This patch adds defines for the detailed monitor >> > range flags as per the EDID specification. >> > >> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> >> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> >> > Cc: Harry Wentland <harry.wentland@amd.com> >> > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> >> > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> >> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> >> > --- >> > include/drm/drm_edid.h | 5 +++++ >> > 1 file changed, 5 insertions(+) >> > >> > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h >> > index f0b03d401c27..f89c97623845 100644 >> > --- a/include/drm/drm_edid.h >> > +++ b/include/drm/drm_edid.h >> > @@ -91,6 +91,11 @@ struct detailed_data_string { >> > u8 str[13]; >> > } __attribute__((packed)); >> > >> > +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 >> > +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01 >> > +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 >> > +#define EDID_CVT_SUPPORT_FLAG 0x04 >> >> Bikeshed for consideration: >> >> drm_edid.h has some macros with DRM_EDID_ prefix, some with EDID_ >> prefix, and then some with no prefix at all really. Should we start >> consolidating on something when we add more? >> > > Yes Jani I did notice the same thing and didnt know which convention > to continue to follow but I noticed that majority of the defines were > just EDID_ so just used that for these new defines. Ah, look again, DRM_EDID_ trumps EDID_ 51 to 15. > Is there a particular way you wish to consolidate this and use a specific > convention for #defines? > > I can atleast change these new defines based on a preferred convention and then > separate patches to change the rest in .h and corresponding usages in .c files. I'd suggest DRM_EDID_ for new ones, perhaps eventually rename old ones. BR, Jani. > > Regards > Manasi > >> BR, >> Jani. >> >> >> > + >> > struct detailed_data_monitor_range { >> > u8 min_vfreq; >> > u8 max_vfreq; >> >> -- >> Jani Nikula, Intel Open Source Graphics Center -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags 2020-03-09 8:35 ` Jani Nikula @ 2020-03-09 20:34 ` Manasi Navare 0 siblings, 0 replies; 8+ messages in thread From: Manasi Navare @ 2020-03-09 20:34 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx, Kazlauskas Nicholas, dri-devel On Mon, Mar 09, 2020 at 10:35:52AM +0200, Jani Nikula wrote: > On Fri, 06 Mar 2020, Manasi Navare <manasi.d.navare@intel.com> wrote: > > On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > >> On Thu, 05 Mar 2020, Manasi Navare <manasi.d.navare@intel.com> wrote: > >> > This patch adds defines for the detailed monitor > >> > range flags as per the EDID specification. > >> > > >> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > >> > Cc: Harry Wentland <harry.wentland@amd.com> > >> > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> > >> > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> > >> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > >> > --- > >> > include/drm/drm_edid.h | 5 +++++ > >> > 1 file changed, 5 insertions(+) > >> > > >> > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > >> > index f0b03d401c27..f89c97623845 100644 > >> > --- a/include/drm/drm_edid.h > >> > +++ b/include/drm/drm_edid.h > >> > @@ -91,6 +91,11 @@ struct detailed_data_string { > >> > u8 str[13]; > >> > } __attribute__((packed)); > >> > > >> > +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > >> > +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > >> > +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > >> > +#define EDID_CVT_SUPPORT_FLAG 0x04 > >> > >> Bikeshed for consideration: > >> > >> drm_edid.h has some macros with DRM_EDID_ prefix, some with EDID_ > >> prefix, and then some with no prefix at all really. Should we start > >> consolidating on something when we add more? > >> > > > > Yes Jani I did notice the same thing and didnt know which convention > > to continue to follow but I noticed that majority of the defines were > > just EDID_ so just used that for these new defines. > > Ah, look again, DRM_EDID_ trumps EDID_ 51 to 15. > > > Is there a particular way you wish to consolidate this and use a specific > > convention for #defines? > > > > I can atleast change these new defines based on a preferred convention and then > > separate patches to change the rest in .h and corresponding usages in .c files. > > I'd suggest DRM_EDID_ for new ones, perhaps eventually rename old ones. Okay cool, I will rename this to be DRM_EDID_ and then work on renaming others later Thanks for pointing this out. Regards Manasi > > BR, > Jani. > > > > > > Regards > > Manasi > > > >> BR, > >> Jani. > >> > >> > >> > + > >> > struct detailed_data_monitor_range { > >> > u8 min_vfreq; > >> > u8 max_vfreq; > >> > >> -- > >> Jani Nikula, Intel Open Source Graphics Center > > -- > Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-09 20:33 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-06 1:42 [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Manasi Navare 2020-03-06 1:42 ` [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Manasi Navare 2020-03-06 15:02 ` Kazlauskas, Nicholas 2020-03-06 18:52 ` [Intel-gfx] " Mario Kleiner 2020-03-06 10:30 ` [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Jani Nikula 2020-03-06 18:40 ` Manasi Navare 2020-03-09 8:35 ` Jani Nikula 2020-03-09 20:34 ` Manasi Navare
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).