* [PATCH] drm/panfrost: Remove unused variables in panfrost_job_close()
@ 2020-11-01 17:38 Boris Brezillon
2020-11-02 8:39 ` Steven Price
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2020-11-01 17:38 UTC (permalink / raw)
To: Rob Herring, Tomeu Vizoso, Alyssa Rosenzweig, Steven Price, Robin Murphy
Cc: Boris Brezillon, dri-devel
Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on
open/close") left unused variables behind, thus generating a warning
at compilation time. Remove those variables.
Fixes: a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
My bad, I didn't notice this warning when rebasing Steven's patch on
top of drm-misc-next :-/
---
drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
index 14c11293791e..d58e5fe12cab 100644
--- a/drivers/gpu/drm/panfrost/panfrost_job.c
+++ b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -634,8 +634,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
{
- struct panfrost_device *pfdev = panfrost_priv->pfdev;
- struct panfrost_job_slot *js = pfdev->js;
int i;
for (i = 0; i < NUM_JOB_SLOTS; i++)
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panfrost: Remove unused variables in panfrost_job_close()
2020-11-01 17:38 [PATCH] drm/panfrost: Remove unused variables in panfrost_job_close() Boris Brezillon
@ 2020-11-02 8:39 ` Steven Price
2020-11-03 8:46 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Steven Price @ 2020-11-02 8:39 UTC (permalink / raw)
To: Boris Brezillon, Rob Herring, Tomeu Vizoso, Alyssa Rosenzweig,
Robin Murphy
Cc: dri-devel
On 01/11/2020 17:38, Boris Brezillon wrote:
> Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on
> open/close") left unused variables behind, thus generating a warning
> at compilation time. Remove those variables.
>
> Fixes: a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close")
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> My bad, I didn't notice this warning when rebasing Steven's patch on
> top of drm-misc-next :-/
Partly my fault - I think I forgot to rebase the patch on drm-misc-next
before posting. Thanks for fixing it.
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 14c11293791e..d58e5fe12cab 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -634,8 +634,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
>
> void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
> {
> - struct panfrost_device *pfdev = panfrost_priv->pfdev;
> - struct panfrost_job_slot *js = pfdev->js;
> int i;
>
> for (i = 0; i < NUM_JOB_SLOTS; i++)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panfrost: Remove unused variables in panfrost_job_close()
2020-11-02 8:39 ` Steven Price
@ 2020-11-03 8:46 ` Boris Brezillon
0 siblings, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2020-11-03 8:46 UTC (permalink / raw)
To: Steven Price; +Cc: dri-devel, Rob Herring, Robin Murphy, Alyssa Rosenzweig
On Mon, 2 Nov 2020 08:39:29 +0000
Steven Price <steven.price@arm.com> wrote:
> On 01/11/2020 17:38, Boris Brezillon wrote:
> > Commit a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on
> > open/close") left unused variables behind, thus generating a warning
> > at compilation time. Remove those variables.
> >
> > Fixes: a17d609e3e21 ("drm/panfrost: Don't corrupt the queue mutex on open/close")
> > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
>
> Reviewed-by: Steven Price <steven.price@arm.com>
Queued to drm-misc-next.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-03 8:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 17:38 [PATCH] drm/panfrost: Remove unused variables in panfrost_job_close() Boris Brezillon
2020-11-02 8:39 ` Steven Price
2020-11-03 8:46 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).