* [PATCH 2/2] drm/omap: hdmi5: fix reference leak in hdmi_runtime_get
@ 2020-11-06 8:12 Zhang Qilong
0 siblings, 0 replies; only message in thread
From: Zhang Qilong @ 2020-11-06 8:12 UTC (permalink / raw)
To: tomi.valkeinen, airlied, daniel; +Cc: dri-devel
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in hdmi_runtime_get, so we should fix it.
Fixes: c44991ce21bef ("drm: omapdrm: hdmi5: Allocate the omap_hdmi data structure dynamically")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/gpu/drm/omapdrm/dss/hdmi5.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
index b738d9750686..26ffbd1bd1cc 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
@@ -45,8 +45,10 @@ static int hdmi_runtime_get(struct omap_hdmi *hdmi)
r = pm_runtime_get_sync(&hdmi->pdev->dev);
WARN_ON(r < 0);
- if (r < 0)
+ if (r < 0) {
+ pm_runtime_put_noidle(&hdmi->pdev->dev);
return r;
+ }
return 0;
}
--
2.25.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-06 8:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 8:12 [PATCH 2/2] drm/omap: hdmi5: fix reference leak in hdmi_runtime_get Zhang Qilong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).