* [PATCH] drm/virtio: fix prime export for vram objects
@ 2021-01-07 21:07 Chia-I Wu
2021-01-08 1:47 ` Gurchetan Singh
2021-01-12 8:51 ` Anthoine Bourgeois
0 siblings, 2 replies; 3+ messages in thread
From: Chia-I Wu @ 2021-01-07 21:07 UTC (permalink / raw)
To: dri-devel; +Cc: Gerd Hoffmann, Thomas Zimmermann, Gurchetan Singh
commit 16845c5d5409 ("drm/virtio: implement blob resources: implement
vram object") and commit c6069a02fa55 ("drm/virtgpu: Set PRIME export
function in struct drm_gem_object_funcs") landed from different trees,
resulting in prime export never working for vram objects.
Cc: Gurchetan Singh <gurchetansingh@chromium.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
---
drivers/gpu/drm/virtio/virtgpu_vram.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vram.c b/drivers/gpu/drm/virtio/virtgpu_vram.c
index d6f215c4ff8d..5cc34e7330fa 100644
--- a/drivers/gpu/drm/virtio/virtgpu_vram.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vram.c
@@ -69,6 +69,7 @@ static const struct drm_gem_object_funcs virtio_gpu_vram_funcs = {
.close = virtio_gpu_gem_object_close,
.free = virtio_gpu_vram_free,
.mmap = virtio_gpu_vram_mmap,
+ .export = virtgpu_gem_prime_export,
};
bool virtio_gpu_is_vram(struct virtio_gpu_object *bo)
--
2.29.2.729.g45daf8777d-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/virtio: fix prime export for vram objects
2021-01-07 21:07 [PATCH] drm/virtio: fix prime export for vram objects Chia-I Wu
@ 2021-01-08 1:47 ` Gurchetan Singh
2021-01-12 8:51 ` Anthoine Bourgeois
1 sibling, 0 replies; 3+ messages in thread
From: Gurchetan Singh @ 2021-01-08 1:47 UTC (permalink / raw)
To: Chia-I Wu; +Cc: Thomas Zimmermann, ML dri-devel, Gerd Hoffmann
[-- Attachment #1.1: Type: text/plain, Size: 1277 bytes --]
On Thu, Jan 7, 2021 at 1:07 PM Chia-I Wu <olvaffe@gmail.com> wrote:
> commit 16845c5d5409 ("drm/virtio: implement blob resources: implement
> vram object") and commit c6069a02fa55 ("drm/virtgpu: Set PRIME export
> function in struct drm_gem_object_funcs") landed from different trees,
> resulting in prime export never working for vram objects.
>
> Cc: Gurchetan Singh <gurchetansingh@chromium.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_vram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vram.c
> b/drivers/gpu/drm/virtio/virtgpu_vram.c
> index d6f215c4ff8d..5cc34e7330fa 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vram.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vram.c
> @@ -69,6 +69,7 @@ static const struct drm_gem_object_funcs
> virtio_gpu_vram_funcs = {
> .close = virtio_gpu_gem_object_close,
> .free = virtio_gpu_vram_free,
> .mmap = virtio_gpu_vram_mmap,
> + .export = virtgpu_gem_prime_export,
> };
>
> bool virtio_gpu_is_vram(struct virtio_gpu_object *bo)
> --
> 2.29.2.729.g45daf8777d-goog
>
>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
[-- Attachment #1.2: Type: text/html, Size: 2120 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/virtio: fix prime export for vram objects
2021-01-07 21:07 [PATCH] drm/virtio: fix prime export for vram objects Chia-I Wu
2021-01-08 1:47 ` Gurchetan Singh
@ 2021-01-12 8:51 ` Anthoine Bourgeois
1 sibling, 0 replies; 3+ messages in thread
From: Anthoine Bourgeois @ 2021-01-12 8:51 UTC (permalink / raw)
To: Chia-I Wu; +Cc: Thomas Zimmermann, Gerd Hoffmann, dri-devel, Gurchetan Singh
On Thu, Jan 07, 2021 at 01:07:43PM -0800, Chia-I Wu wrote:
>commit 16845c5d5409 ("drm/virtio: implement blob resources: implement
>vram object") and commit c6069a02fa55 ("drm/virtgpu: Set PRIME export
>function in struct drm_gem_object_funcs") landed from different trees,
>resulting in prime export never working for vram objects.
>
>Cc: Gurchetan Singh <gurchetansingh@chromium.org>
>Cc: Thomas Zimmermann <tzimmermann@suse.de>
>Cc: Gerd Hoffmann <kraxel@redhat.com>
>Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
>---
> drivers/gpu/drm/virtio/virtgpu_vram.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/gpu/drm/virtio/virtgpu_vram.c b/drivers/gpu/drm/virtio/virtgpu_vram.c
>index d6f215c4ff8d..5cc34e7330fa 100644
>--- a/drivers/gpu/drm/virtio/virtgpu_vram.c
>+++ b/drivers/gpu/drm/virtio/virtgpu_vram.c
>@@ -69,6 +69,7 @@ static const struct drm_gem_object_funcs virtio_gpu_vram_funcs = {
> .close = virtio_gpu_gem_object_close,
> .free = virtio_gpu_vram_free,
> .mmap = virtio_gpu_vram_mmap,
>+ .export = virtgpu_gem_prime_export,
> };
>
> bool virtio_gpu_is_vram(struct virtio_gpu_object *bo)
>--
>2.29.2.729.g45daf8777d-goog
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-12 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 21:07 [PATCH] drm/virtio: fix prime export for vram objects Chia-I Wu
2021-01-08 1:47 ` Gurchetan Singh
2021-01-12 8:51 ` Anthoine Bourgeois
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).