* [PATCH] drm/hisilicon: remove redundant when devm_kzalloc failed
@ 2021-02-02 12:10 Bernard Zhao
0 siblings, 0 replies; only message in thread
From: Bernard Zhao @ 2021-02-02 12:10 UTC (permalink / raw)
To: Xinliang Liu, Tian Tao, John Stultz, Xinwei Kong, Chen Feng,
David Airlie, Daniel Vetter, Laurent Pinchart, Tomi Valkeinen,
Sam Ravnborg, Boris Brezillon, Bernard Zhao, Thomas Zimmermann,
dri-devel, linux-kernel
Cc: opensource.kernel
Line 852 DRM_ERROR is redundant because memory alloc already
prints an error when failed.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index 00e87c290796..8491d8267f07 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -852,10 +852,9 @@ static int dsi_probe(struct platform_device *pdev)
int ret;
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
- if (!data) {
- DRM_ERROR("failed to allocate dsi data.\n");
+ if (!data)
return -ENOMEM;
- }
+
dsi = &data->dsi;
ctx = &data->ctx;
dsi->ctx = ctx;
--
2.29.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-03 8:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 12:10 [PATCH] drm/hisilicon: remove redundant when devm_kzalloc failed Bernard Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).