* [PATCH] drm/virtio: set non-cross device blob uuid_state
@ 2021-08-11 4:04 David Stevens
2021-08-12 13:07 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: David Stevens @ 2021-08-11 4:04 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: dri-devel, David Stevens
Blob resources without the cross device flag don't have a uuid to share
with other virtio devices. When exporting such blobs, set uuid_state to
STATE_ERR so that virtgpu_virtio_get_uuid doesn't hang.
Signed-off-by: David Stevens <stevensd@chromium.org>
---
drivers/gpu/drm/virtio/virtgpu_prime.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/virtio/virtgpu_prime.c b/drivers/gpu/drm/virtio/virtgpu_prime.c
index 807a27a16365..e45dbf14b307 100644
--- a/drivers/gpu/drm/virtio/virtgpu_prime.c
+++ b/drivers/gpu/drm/virtio/virtgpu_prime.c
@@ -98,6 +98,8 @@ struct dma_buf *virtgpu_gem_prime_export(struct drm_gem_object *obj,
} else {
bo->uuid_state = STATE_ERR;
}
+ } else if (!(bo->blob_flags & VIRTGPU_BLOB_FLAG_USE_CROSS_DEVICE)) {
+ bo->uuid_state = STATE_ERR;
}
exp_info.ops = &virtgpu_dmabuf_ops.ops;
--
2.32.0.605.g8dce9f2422-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/virtio: set non-cross device blob uuid_state
2021-08-11 4:04 [PATCH] drm/virtio: set non-cross device blob uuid_state David Stevens
@ 2021-08-12 13:07 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2021-08-12 13:07 UTC (permalink / raw)
To: David Stevens; +Cc: dri-devel
On Wed, Aug 11, 2021 at 01:04:01PM +0900, David Stevens wrote:
> Blob resources without the cross device flag don't have a uuid to share
> with other virtio devices. When exporting such blobs, set uuid_state to
> STATE_ERR so that virtgpu_virtio_get_uuid doesn't hang.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
Pushed to drm-misc-next.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-12 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 4:04 [PATCH] drm/virtio: set non-cross device blob uuid_state David Stevens
2021-08-12 13:07 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).