[PATCH] drm/virtio: set fb_modifiers_not_supported

[PATCH] drm/virtio: set fb_modifiers_not_supported

[Chia-I Wu]

Without this, the drm core advertises LINEAR modifier which is
incorrect.

Also userspace virgl does not support modifiers.  For example, it causes
chrome on ozone/drm to fail with "Failed to create scanout buffer".

Fixes: 2af104290da5 ("drm: introduce fb_modifiers_not_supported flag in mode_config")
Suggested-by: Shao-Chuan Lee <shaochuan@chromium.org>
Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
---
 drivers/gpu/drm/virtio/virtgpu_display.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index 5c7f198c0712..9ea7611a9e0f 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -349,6 +349,8 @@ int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev)
 	vgdev->ddev->mode_config.max_width = XRES_MAX;
 	vgdev->ddev->mode_config.max_height = YRES_MAX;
 
+	vgdev->ddev->mode_config.fb_modifiers_not_supported = true;
+
 	for (i = 0 ; i < vgdev->num_scanouts; ++i)
 		vgdev_output_init(vgdev, i);
 
-- 
2.37.2.789.g6183377224-goog

Re: [PATCH] drm/virtio: set fb_modifiers_not_supported

[Daniel Stone]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

On Wed, 31 Aug 2022 at 20:06, Chia-I Wu <olvaffe@gmail.com> wrote:

> Without this, the drm core advertises LINEAR modifier which is
> incorrect.
>
> Also userspace virgl does not support modifiers.  For example, it causes
> chrome on ozone/drm to fail with "Failed to create scanout buffer".
>
> Fixes: 2af104290da5 ("drm: introduce fb_modifiers_not_supported flag in
> mode_config")
> Suggested-by: Shao-Chuan Lee <shaochuan@chromium.org>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>


 Reviewed-by: Daniel Stone <daniels@collabora.com>

[-- Attachment #2: Type: text/html, Size: 1041 bytes --]

Re: [PATCH] drm/virtio: set fb_modifiers_not_supported

[Gerd Hoffmann]

On Wed, Aug 31, 2022 at 12:06:01PM -0700, Chia-I Wu wrote:
> Without this, the drm core advertises LINEAR modifier which is
> incorrect.
> 
> Also userspace virgl does not support modifiers.  For example, it causes
> chrome on ozone/drm to fail with "Failed to create scanout buffer".
> 
> Fixes: 2af104290da5 ("drm: introduce fb_modifiers_not_supported flag in mode_config")
> Suggested-by: Shao-Chuan Lee <shaochuan@chromium.org>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>

Pushed to drm-misc-next.

thanks,
  Gerd