* [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()
@ 2024-01-28 15:49 Sean Young
2024-01-28 16:43 ` Uwe Kleine-König
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Sean Young @ 2024-01-28 15:49 UTC (permalink / raw)
To: Flavio Suligoi, Lee Jones, Daniel Thompson, Jingoo Han,
Helge Deller, Uwe Kleine-König
Cc: linux-pwm, linux-fbdev, dri-devel, Sean Young, linux-kernel
pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename
pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user
in the tree.
Signed-off-by: Sean Young <sean@mess.org>
---
drivers/video/backlight/mp3309c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/mp3309c.c b/drivers/video/backlight/mp3309c.c
index 34d71259fac1d..b0d9aef6942b3 100644
--- a/drivers/video/backlight/mp3309c.c
+++ b/drivers/video/backlight/mp3309c.c
@@ -131,7 +131,7 @@ static int mp3309c_bl_update_status(struct backlight_device *bl)
chip->pdata->levels[brightness],
chip->pdata->levels[chip->pdata->max_brightness]);
pwmstate.enabled = true;
- ret = pwm_apply_state(chip->pwmd, &pwmstate);
+ ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate);
if (ret)
return ret;
@@ -393,7 +393,7 @@ static int mp3309c_probe(struct i2c_client *client)
chip->pdata->default_brightness,
chip->pdata->max_brightness);
pwmstate.enabled = true;
- ret = pwm_apply_state(chip->pwmd, &pwmstate);
+ ret = pwm_apply_might_sleep(chip->pwmd, &pwmstate);
if (ret)
return dev_err_probe(chip->dev, ret,
"error setting pwm device\n");
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()
2024-01-28 15:49 [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep() Sean Young
@ 2024-01-28 16:43 ` Uwe Kleine-König
2024-01-31 14:42 ` Daniel Thompson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2024-01-28 16:43 UTC (permalink / raw)
To: Sean Young
Cc: linux-pwm, Daniel Thompson, Jingoo Han, Helge Deller, Lee Jones,
linux-fbdev, dri-devel, linux-kernel, Flavio Suligoi
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Hello Sean,
On Sun, Jan 28, 2024 at 03:49:04PM +0000, Sean Young wrote:
> pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename
> pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user
> in the tree.
>
> Signed-off-by: Sean Young <sean@mess.org>
The "problem" here is that the mp3309c driver didn't exist yet in commit
c748a6d77c06a, so it relies on the pwm_apply_state compatibility stub.
I would mention that in the commit log.
Otherwise the change looks fine.
thanks for catching and addressing this issue
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()
2024-01-28 15:49 [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep() Sean Young
2024-01-28 16:43 ` Uwe Kleine-König
@ 2024-01-31 14:42 ` Daniel Thompson
2024-01-31 16:00 ` Flavio Suligoi
2024-02-08 10:35 ` (subset) " Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Thompson @ 2024-01-31 14:42 UTC (permalink / raw)
To: Sean Young
Cc: linux-pwm, linux-fbdev, Jingoo Han, Helge Deller, Lee Jones,
linux-kernel, dri-devel, Uwe Kleine-König, Flavio Suligoi
On Sun, Jan 28, 2024 at 03:49:04PM +0000, Sean Young wrote:
> pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename
> pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user
> in the tree.
>
> Signed-off-by: Sean Young <sean@mess.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()
2024-01-28 15:49 [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep() Sean Young
2024-01-28 16:43 ` Uwe Kleine-König
2024-01-31 14:42 ` Daniel Thompson
@ 2024-01-31 16:00 ` Flavio Suligoi
2024-02-08 10:35 ` (subset) " Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Flavio Suligoi @ 2024-01-31 16:00 UTC (permalink / raw)
To: Sean Young, Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Uwe Kleine-König
Cc: linux-pwm, linux-fbdev, linux-kernel, dri-devel
Hi Sean,
I've just tested your change on my board that uses the mp3309c.
All ok, thanks!
...
> Subject: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()
>
> pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm:
> Rename
> pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user in the
> tree.
>
> Signed-off-by: Sean Young <sean@mess.org>
> ---
Tested-by: Flavio Suligoi <f.suligoi@asem.it>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (subset) [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()
2024-01-28 15:49 [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep() Sean Young
` (2 preceding siblings ...)
2024-01-31 16:00 ` Flavio Suligoi
@ 2024-02-08 10:35 ` Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2024-02-08 10:35 UTC (permalink / raw)
To: Flavio Suligoi, Lee Jones, Daniel Thompson, Jingoo Han,
Helge Deller, Uwe Kleine-König, Sean Young
Cc: dri-devel, linux-fbdev, linux-kernel, linux-pwm
On Sun, 28 Jan 2024 15:49:04 +0000, Sean Young wrote:
> pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename
> pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user
> in the tree.
>
>
Applied, thanks!
[1/1] backlight: mp3309c: Use pwm_apply_might_sleep()
commit: 7feb4ec8ec900daf29602bcdf7c04178c63205ac
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-08 10:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-28 15:49 [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep() Sean Young
2024-01-28 16:43 ` Uwe Kleine-König
2024-01-31 14:42 ` Daniel Thompson
2024-01-31 16:00 ` Flavio Suligoi
2024-02-08 10:35 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).