[PATCH 0/3] Add GAMMA 12-bit LUT support for MT8188

[PATCH 0/3] Add GAMMA 12-bit LUT support for MT8188

[Jason-JH.Lin]

From: Jason-jh Lin <jason-jh.lin@mediatek.corp-partner.google.com>

Since MT8195 supports GAMMA 12-bit LUT after the landing of [1] series,
we can now add support for MT8188.

[1] MediaTek DDP GAMMA - 12-bit LUT support
- https://patchwork.kernel.org/project/linux-mediatek/list/?series=792516

Jason-JH.Lin (3):
  dt-bindings: display: mediatek: gamma: Change MT8195 to single enum
    group
  dt-bindings: display: mediatek: gamma: Add support for MT8188
  drm/mediatek: Add gamma support for MT8195

 .../bindings/display/mediatek/mediatek,gamma.yaml           | 6 +++++-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c                      | 2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.18.0

[PATCH 1/3] dt-bindings: display: mediatek: gamma: Change MT8195 to single enum group

[Jason-JH.Lin]

Since MT8195 gamma has multiple bank for 12 bits LUT and it is
different from any other SoC LUT setting.

So we move MT8195 compatible from the one of items to the
single enum group.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
index c6641acd75d6..3e6cb8f48bcc 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
@@ -24,6 +24,7 @@ properties:
       - enum:
           - mediatek,mt8173-disp-gamma
           - mediatek,mt8183-disp-gamma
+          - mediatek,mt8195-disp-gamma
       - items:
           - enum:
               - mediatek,mt6795-disp-gamma
@@ -33,7 +34,6 @@ properties:
               - mediatek,mt8186-disp-gamma
               - mediatek,mt8188-disp-gamma
               - mediatek,mt8192-disp-gamma
-              - mediatek,mt8195-disp-gamma
           - const: mediatek,mt8183-disp-gamma
 
   reg:
-- 
2.18.0

[PATCH 2/3] dt-bindings: display: mediatek: gamma: Add support for MT8188

[Jason-JH.Lin]

The gamma LUT setting of MT8188 and MT8195 are the same, so we create
a one of items for MT8188 to reuse the driver data settings of MT8195.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
index 3e6cb8f48bcc..90c454eea06f 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
@@ -29,6 +29,10 @@ properties:
           - enum:
               - mediatek,mt6795-disp-gamma
           - const: mediatek,mt8173-disp-gamma
+      - items:
+          - enum:
+              - mediatek,mt8188-disp-gamma
+          - const: mediatek,mt8195-disp-gamma
       - items:
           - enum:
               - mediatek,mt8186-disp-gamma
-- 
2.18.0

[PATCH 3/3] drm/mediatek: Add gamma support for MT8195

[Jason-JH.Lin]

Since MT8195 compatible is in the single enum group, we have to add its
compatible into mediatek-drm component binding table to ensure that
it can be bound as a ddp_comp.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 14a1e0157cc4..93303bff8f34 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -707,6 +707,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
 	  .data = (void *)MTK_DISP_GAMMA, },
 	{ .compatible = "mediatek,mt8183-disp-gamma",
 	  .data = (void *)MTK_DISP_GAMMA, },
+	{ .compatible = "mediatek,mt8195-disp-gamma",
+	  .data = (void *)MTK_DISP_GAMMA, },
 	{ .compatible = "mediatek,mt8195-disp-merge",
 	  .data = (void *)MTK_DISP_MERGE },
 	{ .compatible = "mediatek,mt2701-disp-mutex",
-- 
2.18.0

Re: [PATCH 2/3] dt-bindings: display: mediatek: gamma: Add support for MT8188

[Krzysztof Kozlowski]

On 29/02/2024 03:35, Jason-JH.Lin wrote:
> The gamma LUT setting of MT8188 and MT8195 are the same, so we create
> a one of items for MT8188 to reuse the driver data settings of MT8195.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
>  .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> index 3e6cb8f48bcc..90c454eea06f 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> @@ -29,6 +29,10 @@ properties:
>            - enum:
>                - mediatek,mt6795-disp-gamma
>            - const: mediatek,mt8173-disp-gamma
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-disp-gamma
> +          - const: mediatek,mt8195-disp-gamma
>        - items:
>            - enum:
>                - mediatek,mt8186-disp-gamma

Please keep this ordered by fallback compatible, so your list with 8195
fallback should go below the list here.

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: display: mediatek: gamma: Change MT8195 to single enum group

[Krzysztof Kozlowski]

On 29/02/2024 03:35, Jason-JH.Lin wrote:
> Since MT8195 gamma has multiple bank for 12 bits LUT and it is
> different from any other SoC LUT setting.
> 
> So we move MT8195 compatible from the one of items to the
> single enum group.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: display: mediatek: gamma: Change MT8195 to single enum group

[AngeloGioacchino Del Regno]

Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
> Since MT8195 gamma has multiple bank for 12 bits LUT and it is
> different from any other SoC LUT setting.
> 
> So we move MT8195 compatible from the one of items to the
> single enum group.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
>   .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> index c6641acd75d6..3e6cb8f48bcc 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml
> @@ -24,6 +24,7 @@ properties:
>         - enum:
>             - mediatek,mt8173-disp-gamma
>             - mediatek,mt8183-disp-gamma
> +          - mediatek,mt8195-disp-gamma
>         - items:
>             - enum:
>                 - mediatek,mt6795-disp-gamma
> @@ -33,7 +34,6 @@ properties:
>                 - mediatek,mt8186-disp-gamma
>                 - mediatek,mt8188-disp-gamma
>                 - mediatek,mt8192-disp-gamma
> -              - mediatek,mt8195-disp-gamma

While I agree on allowing mt8195-disp-gamma to have its own separated compatible
as the IP is actually different from the one in MT8183, you can't do it like that,
or dtbs_check will fail validation for the mt8195 devicetree.

That one declares...

gamma0: gamma@1c006000 {
	compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma";

...Please always run dtbs_check when performing bindings modifications.

Cheers,
Angelo

>             - const: mediatek,mt8183-disp-gamma
>   
>     reg:

Re: [PATCH 2/3] dt-bindings: display: mediatek: gamma: Add support for MT8188

[AngeloGioacchino Del Regno]

Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
> The gamma LUT setting of MT8188 and MT8195 are the same, so we create
> a one of items for MT8188 to reuse the driver data settings of MT8195.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH 3/3] drm/mediatek: Add gamma support for MT8195

[AngeloGioacchino Del Regno]

Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
> Since MT8195 compatible is in the single enum group, we have to add its
> compatible into mediatek-drm component binding table to ensure that
> it can be bound as a ddp_comp.
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogiaocchino.delregno@collabora.com>

Re: [PATCH 2/3] dt-bindings: display: mediatek: gamma: Add support for MT8188

[Jason-JH Lin (林睿祥)]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

Hi Krzysztof,

Thanks for the reviews.

On Thu, 2024-02-29 at 09:27 +0100, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 29/02/2024 03:35, Jason-JH.Lin wrote:
> > The gamma LUT setting of MT8188 and MT8195 are the same, so we
> create
> > a one of items for MT8188 to reuse the driver data settings of
> MT8195.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml  | 4
> ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> > index 3e6cb8f48bcc..90c454eea06f 100644
> > ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> > +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> > @@ -29,6 +29,10 @@ properties:
> >            - enum:
> >                - mediatek,mt6795-disp-gamma
> >            - const: mediatek,mt8173-disp-gamma
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt8188-disp-gamma
> > +          - const: mediatek,mt8195-disp-gamma
> >        - items:
> >            - enum:
> >                - mediatek,mt8186-disp-gamma
> 
> Please keep this ordered by fallback compatible, so your list with
> 8195
> fallback should go below the list here.
> 
OK, I'll move it here.

Regards,
Jason-JH.Lin

> Best regards,
> Krzysztof
> 

[-- Attachment #2: Type: text/html, Size: 3991 bytes --]

Re: [PATCH 1/3] dt-bindings: display: mediatek: gamma: Change MT8195 to single enum group

[Jason-JH Lin (林睿祥)]

[-- Attachment #1: Type: text/plain, Size: 2508 bytes --]

Hi Angelo,

Thanks for the reviews.

On Thu, 2024-02-29 at 09:47 +0100, AngeloGioacchino Del Regno wrote:
> Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
> > Since MT8195 gamma has multiple bank for 12 bits LUT and it is
> > different from any other SoC LUT setting.
> > 
> > So we move MT8195 compatible from the one of items to the
> > single enum group.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---
> >   .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml    |
> > 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > index c6641acd75d6..3e6cb8f48bcc 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > @@ -24,6 +24,7 @@ properties:
> >         - enum:
> >             - mediatek,mt8173-disp-gamma
> >             - mediatek,mt8183-disp-gamma
> > +          - mediatek,mt8195-disp-gamma
> >         - items:
> >             - enum:
> >                 - mediatek,mt6795-disp-gamma
> > @@ -33,7 +34,6 @@ properties:
> >                 - mediatek,mt8186-disp-gamma
> >                 - mediatek,mt8188-disp-gamma
> >                 - mediatek,mt8192-disp-gamma
> > -              - mediatek,mt8195-disp-gamma
> 
> While I agree on allowing mt8195-disp-gamma to have its own separated
> compatible
> as the IP is actually different from the one in MT8183, you can't do
> it like that,
> or dtbs_check will fail validation for the mt8195 devicetree.
> 
OK, I'll keep mt8195 here to fix the validation.

> That one declares...
> 
> gamma0: gamma@1c006000 {
> 	compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-
> disp-gamma";
> 
> ...Please always run dtbs_check when performing bindings
> modifications.
> 
I'm sorry about that.
I found that I have never run dtbs_check successfully because
the dtbs_check did not appear in my environment after I ran
dt_binding_check...

Finally, I found that using "make dt_binding_check dtbs_check" in the
same cmd line works!
So I'll always do this before sending bindings modification.

Regards,
Jason-JH.Lin

> Cheers,
> Angelo
> 
> >             - const: mediatek,mt8183-disp-gamma
> >   
> >     reg:
> 
> 

[-- Attachment #2: Type: text/html, Size: 5609 bytes --]