* [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c
@ 2017-12-12 11:38 Markus Heiser
2017-12-12 12:05 ` Michal Wajdeczko
0 siblings, 1 reply; 5+ messages in thread
From: Markus Heiser @ 2017-12-12 11:38 UTC (permalink / raw)
To: joonas.lahtinen, chris, sagar.a.kamble, michal.wajdeczko,
jani.nikula, rodrigo.vivi, airlied, daniel.vetter, seanpaul,
corbet
Cc: Markus Heiser, intel-gfx, dri-devel, linux-doc, linux-kernel
With commit d9e2e0143c the 'GuC-specific firmware loader' doc
section was removed from intel_guc_loader.c without a
replacement. So lets remove it from the Kernel-doc::
.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
:doc: GuC-specific firmware loader
With commit e8668bbcb0 intel_guc_loader.c was renamed to to
intel_guc_fw.c and to name just one, intel_guc_init_hw() was
renamed to intel_guc_fw_upload(). Since we get errors in the
Sphinx build like:
- Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
Change the kernel-doc directive from intel_guc_loader.c to
intel_guc_fw.c
Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
---
Documentation/gpu/i915.rst | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst
index 2e7ee03..e94d3ac 100644
--- a/Documentation/gpu/i915.rst
+++ b/Documentation/gpu/i915.rst
@@ -341,10 +341,7 @@ GuC
GuC-specific firmware loader
----------------------------
-.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
- :doc: GuC-specific firmware loader
-
-.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
+.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_fw.c
:internal:
GuC-based command submission
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c
2017-12-12 11:38 [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c Markus Heiser
@ 2017-12-12 12:05 ` Michal Wajdeczko
2017-12-12 12:11 ` Markus Heiser
0 siblings, 1 reply; 5+ messages in thread
From: Michal Wajdeczko @ 2017-12-12 12:05 UTC (permalink / raw)
To: joonas.lahtinen, chris, sagar.a.kamble, jani.nikula,
rodrigo.vivi, airlied, daniel.vetter, seanpaul, corbet,
Markus Heiser
Cc: intel-gfx, linux-kernel, dri-devel, linux-doc
On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser
<markus.heiser@darmarit.de> wrote:
> With commit d9e2e0143c the 'GuC-specific firmware loader' doc
> section was removed from intel_guc_loader.c without a
> replacement. So lets remove it from the Kernel-doc::
>
> .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
> :doc: GuC-specific firmware loader
>
> With commit e8668bbcb0 intel_guc_loader.c was renamed to to
> intel_guc_fw.c and to name just one, intel_guc_init_hw() was
> renamed to intel_guc_fw_upload(). Since we get errors in the
> Sphinx build like:
>
> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
>
> Change the kernel-doc directive from intel_guc_loader.c to
> intel_guc_fw.c
>
> Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
> ---
Thanks for your patch, but similar fix is already merged here [1]
Michal
[1]
https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c
2017-12-12 12:05 ` Michal Wajdeczko
@ 2017-12-12 12:11 ` Markus Heiser
2017-12-12 15:23 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Markus Heiser @ 2017-12-12 12:11 UTC (permalink / raw)
To: Michal Wajdeczko, Randy Dunlap
Cc: joonas.lahtinen, Chris Wilson, sagar.a.kamble, jani.nikula,
rodrigo.vivi, airlied, daniel.vetter, seanpaul, Jonathan Corbet,
intel-gfx, dri-devel, Linux Doc Mailing List, linux-kernel
> Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko <michal.wajdeczko@intel.com>:
>
> On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser <markus.heiser@darmarit.de> wrote:
>
>> With commit d9e2e0143c the 'GuC-specific firmware loader' doc
>> section was removed from intel_guc_loader.c without a
>> replacement. So lets remove it from the Kernel-doc::
>>
>> .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
>> :doc: GuC-specific firmware loader
>>
>> With commit e8668bbcb0 intel_guc_loader.c was renamed to to
>> intel_guc_fw.c and to name just one, intel_guc_init_hw() was
>> renamed to intel_guc_fw_upload(). Since we get errors in the
>> Sphinx build like:
>>
>> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
>>
>> Change the kernel-doc directive from intel_guc_loader.c to
>> intel_guc_fw.c
>>
>> Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
>> ---
>
> Thanks for your patch, but similar fix is already merged here [1]
>
> Michal
>
> [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader"
fix in that patch (doc section was removed in d9e2e0143c). Can you or
someone else from @intel fix this also?
Thanks!
-- Markus --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-doc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c
2017-12-12 12:11 ` Markus Heiser
@ 2017-12-12 15:23 ` Daniel Vetter
2017-12-12 15:43 ` Markus Heiser
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2017-12-12 15:23 UTC (permalink / raw)
To: Markus Heiser
Cc: Randy Dunlap, Jonathan Corbet, airlied, intel-gfx,
joonas.lahtinen, Linux Doc Mailing List, linux-kernel, dri-devel,
rodrigo.vivi, daniel.vetter, sagar.a.kamble, Michal Wajdeczko
On Tue, Dec 12, 2017 at 01:11:43PM +0100, Markus Heiser wrote:
>
> > Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko <michal.wajdeczko@intel.com>:
> >
> > On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser <markus.heiser@darmarit.de> wrote:
> >
> >> With commit d9e2e0143c the 'GuC-specific firmware loader' doc
> >> section was removed from intel_guc_loader.c without a
> >> replacement. So lets remove it from the Kernel-doc::
> >>
> >> .. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
> >> :doc: GuC-specific firmware loader
> >>
> >> With commit e8668bbcb0 intel_guc_loader.c was renamed to to
> >> intel_guc_fw.c and to name just one, intel_guc_init_hw() was
> >> renamed to intel_guc_fw_upload(). Since we get errors in the
> >> Sphinx build like:
> >>
> >> - Error: Cannot open file ./drivers/gpu/drm/i915/intel_guc_loader.c
> >>
> >> Change the kernel-doc directive from intel_guc_loader.c to
> >> intel_guc_fw.c
> >>
> >> Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
> >> ---
> >
> > Thanks for your patch, but similar fix is already merged here [1]
> >
> > Michal
> >
> > [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
>
>
> Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader"
> fix in that patch (doc section was removed in d9e2e0143c). Can you or
> someone else from @intel fix this also?
I've rebased the patch from you to only take that remaining part.
Thanks for fixing this.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c
2017-12-12 15:23 ` Daniel Vetter
@ 2017-12-12 15:43 ` Markus Heiser
0 siblings, 0 replies; 5+ messages in thread
From: Markus Heiser @ 2017-12-12 15:43 UTC (permalink / raw)
To: Daniel Vetter
Cc: Randy Dunlap, Jonathan Corbet, airlied, intel-gfx,
joonas.lahtinen, Linux Doc Mailing List, linux-kernel, dri-devel,
rodrigo.vivi, daniel.vetter, sagar.a.kamble, Michal Wajdeczko
> Am 12.12.2017 um 16:23 schrieb Daniel Vetter <daniel@ffwll.ch>:
>
>>> Thanks for your patch, but similar fix is already merged here [1]
>>>
>>> Michal
>>>
>>> [1] https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7
>>
>>
>> Thanks for pointing out. I miss the ":doc: GuC-specific firmware loader"
>> fix in that patch (doc section was removed in d9e2e0143c). Can you or
>> someone else from @intel fix this also?
>
> I've rebased the patch from you to only take that remaining part.
>
> Thanks for fixing this.
> -Daniel
Thanks for picking this up [1].
[1] https://cgit.freedesktop.org/drm/drm-intel/commit/?id=0132a1a5
-- Markus --
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-12 15:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 11:38 [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c Markus Heiser
2017-12-12 12:05 ` Michal Wajdeczko
2017-12-12 12:11 ` Markus Heiser
2017-12-12 15:23 ` Daniel Vetter
2017-12-12 15:43 ` Markus Heiser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).