* [PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic()
@ 2017-12-05 18:00 ` SF Markus Elfring
2018-03-28 14:19 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-12-05 18:00 UTC (permalink / raw)
To: linux-fbdev, linux-parisc, dri-devel, Bartlomiej Zolnierkiewicz,
Helge Deller, James E. J. Bottomley
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 5 Dec 2017 18:45:42 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/video/console/sticore.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/console/sticore.c b/drivers/video/console/sticore.c
index d1d3796773aa..08b822656846 100644
--- a/drivers/video/console/sticore.c
+++ b/drivers/video/console/sticore.c
@@ -827,10 +827,8 @@ static struct sti_struct *sti_try_rom_generic(unsigned long address,
}
sti = kzalloc(sizeof(*sti), GFP_KERNEL);
- if (!sti) {
- printk(KERN_ERR "Not enough memory !\n");
+ if (!sti)
return NULL;
- }
spin_lock_init(&sti->lock);
--
2.15.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic()
2017-12-05 18:00 ` [PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic() SF Markus Elfring
@ 2018-03-28 14:19 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-03-28 14:19 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-fbdev, linux-parisc, Helge Deller, kernel-janitors,
James E. J. Bottomley, dri-devel, LKML
On Tuesday, December 05, 2017 07:00:22 PM SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 5 Dec 2017 18:45:42 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch queued for 4.17, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-28 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171205180033epcas4p3cb5142e079695c72736e1f27489466d3@epcas4p3.samsung.com>
2017-12-05 18:00 ` [PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic() SF Markus Elfring
2018-03-28 14:19 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).