* [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
@ 2018-12-11 23:56 Lyude Paul
[not found] ` <20181211235622.22859-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Lyude Paul @ 2018-12-11 23:56 UTC (permalink / raw)
To: nouveau
Cc: dri-devel, stable, Ben Skeggs, David Airlie, Daniel Vetter,
Sean Paul, Ilia Mirkin, linux-kernel
Noticed this while working on redoing the reference counting scheme in
the DP MST helpers. Nouveau doesn't attempt to call
drm_dp_mst_topology_mgr_destroy() at all, which leaves it leaking all of
the resources for drm_dp_mst_topology_mgr and it's children mstbs+ports.
Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream")
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: <stable@vger.kernel.org> # v4.10+
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index d153ea2a08ac..a634b3d0b6a1 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -1254,6 +1254,7 @@ nv50_mstm_del(struct nv50_mstm **pmstm)
{
struct nv50_mstm *mstm = *pmstm;
if (mstm) {
+ drm_dp_mst_topology_mgr_destroy(&mstm->mgr);
kfree(*pmstm);
*pmstm = NULL;
}
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
[not found] ` <20181211235622.22859-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2018-12-12 5:46 ` Sasha Levin
2018-12-12 17:40 ` Lyude Paul
0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2018-12-12 5:46 UTC (permalink / raw)
To: Sasha Levin, Lyude Paul, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: stable-u79uwXL29TY76Z2rM5mHXA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Hi,
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag,
fixing commit: f479c0ba4a17 drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream.
The bot has tested the following trees: v4.19.8, v4.14.87,
v4.19.8: Build OK!
v4.14.87: Failed to apply! Possible dependencies:
Unable to calculate
How should we proceed with this patch?
--
Thanks,
Sasha
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
2018-12-12 5:46 ` Sasha Levin
@ 2018-12-12 17:40 ` Lyude Paul
0 siblings, 0 replies; 3+ messages in thread
From: Lyude Paul @ 2018-12-12 17:40 UTC (permalink / raw)
To: Sasha Levin, nouveau; +Cc: dri-devel, stable
v4.19.8, it's ok to skip v4.14 for this
On Wed, 2018-12-12 at 05:46 +0000, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: f479c0ba4a17 drm/nouveau/kms/nv50: initial support for DP 1.2
> multi-stream.
>
> The bot has tested the following trees: v4.19.8, v4.14.87,
>
> v4.19.8: Build OK!
> v4.14.87: Failed to apply! Possible dependencies:
> Unable to calculate
>
>
> How should we proceed with this patch?
>
> --
> Thanks,
> Sasha
--
Cheers,
Lyude Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-12 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 23:56 [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del() Lyude Paul
[not found] ` <20181211235622.22859-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-12 5:46 ` Sasha Levin
2018-12-12 17:40 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).