[PATCH] drm/fbdev-dma: Fix documented default preferred_bpp value

[PATCH] drm/fbdev-dma: Fix documented default preferred_bpp value

[Geert Uytterhoeven]

As of commit 6c80a93be62d398e ("drm/fb-helper: Initialize fb-helper's
preferred BPP in prepare function"), the preferred_bpp parameter of
drm_fb_helper_prepare() defaults to 32 instead of
drm_mode_config.preferred_depth.  Hence this also applies to
drm_fbdev_dma_setup(), which just passes its own preferred_bpp
parameter.

Fixes: b79fe9abd58bab73 ("drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/drm_fbdev_dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
index d86773fa8ab00f49..76aa52b38a13ed63 100644
--- a/drivers/gpu/drm/drm_fbdev_dma.c
+++ b/drivers/gpu/drm/drm_fbdev_dma.c
@@ -217,7 +217,7 @@ static const struct drm_client_funcs drm_fbdev_dma_client_funcs = {
  * drm_fbdev_dma_setup() - Setup fbdev emulation for GEM DMA helpers
  * @dev: DRM device
  * @preferred_bpp: Preferred bits per pixel for the device.
- *                 @dev->mode_config.preferred_depth is used if this is zero.
+ *                 32 is used if this is zero.
  *
  * This function sets up fbdev emulation for GEM DMA drivers that support
  * dumb buffers with a virtual address and that can be mmap'ed.
-- 
2.34.1

Re: [PATCH] drm/fbdev-dma: Fix documented default preferred_bpp value

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1773 bytes --]

Hi

Am 06.07.23 um 17:30 schrieb Geert Uytterhoeven:
> As of commit 6c80a93be62d398e ("drm/fb-helper: Initialize fb-helper's
> preferred BPP in prepare function"), the preferred_bpp parameter of
> drm_fb_helper_prepare() defaults to 32 instead of
> drm_mode_config.preferred_depth.  Hence this also applies to
> drm_fbdev_dma_setup(), which just passes its own preferred_bpp
> parameter.
> 
> Fixes: b79fe9abd58bab73 ("drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Thanks a lot. I'll add it to -misc-next.

Best regards
Thomas

> ---
>   drivers/gpu/drm/drm_fbdev_dma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
> index d86773fa8ab00f49..76aa52b38a13ed63 100644
> --- a/drivers/gpu/drm/drm_fbdev_dma.c
> +++ b/drivers/gpu/drm/drm_fbdev_dma.c
> @@ -217,7 +217,7 @@ static const struct drm_client_funcs drm_fbdev_dma_client_funcs = {
>    * drm_fbdev_dma_setup() - Setup fbdev emulation for GEM DMA helpers
>    * @dev: DRM device
>    * @preferred_bpp: Preferred bits per pixel for the device.
> - *                 @dev->mode_config.preferred_depth is used if this is zero.
> + *                 32 is used if this is zero.
>    *
>    * This function sets up fbdev emulation for GEM DMA drivers that support
>    * dumb buffers with a virtual address and that can be mmap'ed.

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]