* [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs
@ 2018-12-11 21:03 Liu, Leo
[not found] ` <20181211210318.10807-1-leo.liu-5C7GfCeVMHo@public.gmane.org>
2018-12-11 21:11 ` Deucher, Alexander
0 siblings, 2 replies; 3+ messages in thread
From: Liu, Leo @ 2018-12-11 21:03 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Liu, Leo
Just make them properly i.e. put 0 to the Nop reg
Signed-off-by: Leo Liu <leo.liu@amd.com>
---
tests/amdgpu/vcn_tests.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c
index d9f05af8..859ec496 100644
--- a/tests/amdgpu/vcn_tests.c
+++ b/tests/amdgpu/vcn_tests.c
@@ -268,8 +268,10 @@ static void amdgpu_cs_vcn_dec_create(void)
ib_cpu[len++] = msg_buf.addr >> 32;
ib_cpu[len++] = 0x81C3;
ib_cpu[len++] = 0;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x81ff;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
@@ -336,8 +338,10 @@ static void amdgpu_cs_vcn_dec_decode(void)
ib_cpu[len++] = 0x81C6;
ib_cpu[len++] = 0x1;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x80000000;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
@@ -373,8 +377,10 @@ static void amdgpu_cs_vcn_dec_destroy(void)
ib_cpu[len++] = msg_buf.addr >> 32;
ib_cpu[len++] = 0x81C3;
ib_cpu[len++] = 0;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x80000000;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs
[not found] ` <20181211210318.10807-1-leo.liu-5C7GfCeVMHo@public.gmane.org>
@ 2018-12-11 21:06 ` Zhang, Boyuan
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Boyuan @ 2018-12-11 21:06 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Liu, Leo
Patch is
Reviewed-by: Boyuan Zhang <boyuan.zhang@amd.com>
Regards,
Boyuan
-----Original Message-----
From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Liu, Leo
Sent: December-11-18 4:04 PM
To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: Liu, Leo
Subject: [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs
Just make them properly i.e. put 0 to the Nop reg
Signed-off-by: Leo Liu <leo.liu@amd.com>
---
tests/amdgpu/vcn_tests.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c
index d9f05af8..859ec496 100644
--- a/tests/amdgpu/vcn_tests.c
+++ b/tests/amdgpu/vcn_tests.c
@@ -268,8 +268,10 @@ static void amdgpu_cs_vcn_dec_create(void)
ib_cpu[len++] = msg_buf.addr >> 32;
ib_cpu[len++] = 0x81C3;
ib_cpu[len++] = 0;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x81ff;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
@@ -336,8 +338,10 @@ static void amdgpu_cs_vcn_dec_decode(void)
ib_cpu[len++] = 0x81C6;
ib_cpu[len++] = 0x1;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x80000000;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
@@ -373,8 +377,10 @@ static void amdgpu_cs_vcn_dec_destroy(void)
ib_cpu[len++] = msg_buf.addr >> 32;
ib_cpu[len++] = 0x81C3;
ib_cpu[len++] = 0;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x80000000;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs
2018-12-11 21:03 [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs Liu, Leo
[not found] ` <20181211210318.10807-1-leo.liu-5C7GfCeVMHo@public.gmane.org>
@ 2018-12-11 21:11 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2018-12-11 21:11 UTC (permalink / raw)
To: Liu, Leo, amd-gfx, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 2632 bytes --]
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Liu, Leo <Leo.Liu@amd.com>
Sent: Tuesday, December 11, 2018 4:03 PM
To: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Cc: Liu, Leo
Subject: [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs
Just make them properly i.e. put 0 to the Nop reg
Signed-off-by: Leo Liu <leo.liu@amd.com>
---
tests/amdgpu/vcn_tests.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c
index d9f05af8..859ec496 100644
--- a/tests/amdgpu/vcn_tests.c
+++ b/tests/amdgpu/vcn_tests.c
@@ -268,8 +268,10 @@ static void amdgpu_cs_vcn_dec_create(void)
ib_cpu[len++] = msg_buf.addr >> 32;
ib_cpu[len++] = 0x81C3;
ib_cpu[len++] = 0;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x81ff;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
@@ -336,8 +338,10 @@ static void amdgpu_cs_vcn_dec_decode(void)
ib_cpu[len++] = 0x81C6;
ib_cpu[len++] = 0x1;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x80000000;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
@@ -373,8 +377,10 @@ static void amdgpu_cs_vcn_dec_destroy(void)
ib_cpu[len++] = msg_buf.addr >> 32;
ib_cpu[len++] = 0x81C3;
ib_cpu[len++] = 0;
- for (; len % 16; ++len)
- ib_cpu[len] = 0x80000000;
+ for (; len % 16; ) {
+ ib_cpu[len++] = 0x81ff;
+ ib_cpu[len++] = 0;
+ }
r = submit(len, AMDGPU_HW_IP_VCN_DEC);
CU_ASSERT_EQUAL(r, 0);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
To see the collection of prior postings to the list, visit the amd-gfx Archives.. Using amd-gfx: To post a message to all the list members, send email to amd-gfx@lists.freedesktop.org. You can subscribe to the list, or change your existing subscription, in the sections below.
[-- Attachment #1.2: Type: text/html, Size: 7410 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-11 21:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 21:03 [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs Liu, Leo
[not found] ` <20181211210318.10807-1-leo.liu-5C7GfCeVMHo@public.gmane.org>
2018-12-11 21:06 ` Zhang, Boyuan
2018-12-11 21:11 ` Deucher, Alexander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).