From: Karol Herbst <kherbst@redhat.com>
To: James Jones <jajones@nvidia.com>
Cc: Thierry Reding <treding@nvidia.com>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [git pull] drm for 5.8-rc1
Date: Wed, 12 Aug 2020 14:24:25 +0200 [thread overview]
Message-ID: <CACO55tvF0dOQ=myUpccmfHc+hCVQZoXQnCA0iHeXQo3B=UaD0Q@mail.gmail.com> (raw)
In-Reply-To: <CACO55ts2AHgDNZKBvoU8NZf26V8BJDGkKiapY=1xaUQ1DrC8SA@mail.gmail.com>
On Wed, Aug 12, 2020 at 12:43 PM Karol Herbst <kherbst@redhat.com> wrote:
>
> On Wed, Aug 12, 2020 at 12:27 PM Karol Herbst <kherbst@redhat.com> wrote:
> >
> > On Wed, Aug 12, 2020 at 2:19 AM James Jones <jajones@nvidia.com> wrote:
> > >
> > > Sorry for the slow reply here as well. I've been in the process of
> > > rebasing and reworking the userspace patches. I'm not clear my changes
> > > will address the Jetson Nano issue, but if you'd like to try them, the
> > > latest userspace changes are available here:
> > >
> > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3724
> > >
> > > And the tegra-drm kernel patches are here:
> > >
> > >
> > > https://patchwork.ozlabs.org/project/linux-tegra/patch/20191217005205.2573-1-jajones@nvidia.com/
> > >
> > > Those + the kernel changes addressed in this thread are everything I had
> > > outstanding.
> > >
> >
> > I don't know if that's caused by your changes or not, but now the
> > assert I hit is a different one pointing out that
> > nvc0_miptree_select_best_modifier fails in a certain case and returns
> > MOD_INVALID... anyway, it seems like with your patches applied it's
> > now way easier to debug and figure out what's going wrong, so maybe I
> > can figure it out now :)
> >
>
> collected some information which might help to track it down.
>
> src/gallium/frontends/dri/dri2.c:648 is the assert hit: assert(*zsbuf)
>
> templ is {reference = {count = 0}, width0 = 300, height0 = 300, depth0
> = 1, array_size = 1, format = PIPE_FORMAT_Z24X8_UNORM, target =
> PIPE_TEXTURE_2D, last_level = 0, nr_samples = 0, nr_storage_samples =
> 0, usage = 0, bind = 1, flags = 0, next = 0x0, screen = 0x0}
>
> inside tegra_screen_resource_create modifier says
> DRM_FORMAT_MOD_INVALID as template->bind is 1
>
> and nvc0_miptree_select_best_modifier returns DRM_FORMAT_MOD_INVALID,
> so the call just returns NULL leading to the assert.
>
> Btw, this is on Xorg-1.20.8-1.fc32.aarch64 with glxgears.
>
So I digged a bit deeper and here is what tripps it of:
when the context gets made current, the normal framebuffer validation
and render buffer allocation is done, but we end up inside
tegra_screen_resource_create at some point with PIPE_BIND_SCANOUT set
in template->bind. Now the tegra driver forces the
DRM_FORMAT_MOD_LINEAR modifier and calls into
resource_create_with_modifiers.
If it wouldn't do that, nouveau would allocate a tiled buffer, with
that it's linear and we at some point end up with an assert about a
depth_stencil buffer being there even though it shouldn't. If I always
use DRM_FORMAT_MOD_INVALID in tegra_screen_resource_create, things
just work.
That's kind of the cause I pinpointed the issue down to. But I have no
idea what's supposed to happen and what the actual bug is.
> > > Thanks,
> > > -James
> > >
> > > On 8/4/20 1:58 AM, Karol Herbst wrote:
> > > > Hi James,
> > > >
> > > > I don't know if you knew, but on the Jetson nano we had the issue for
> > > > quite some time, that GLX/EGL through mesa on X was broken due to some
> > > > fix in mesa related to modifiers.
> > > >
> > > > And I was wondering if the overall state just caused the issue we saw
> > > > here and wanted to know what branches/patches I needed for the various
> > > > projects to see if the work you have been doing since the last
> > > > upstream nouveau regression would be of any help here?
> > > >
> > > > Mind pointing me towards everything I'd need to check that?
> > > >
> > > > I'd really like to fix this, but didn't have the time to investigate
> > > > what the core problem here was, but I think it's very likely that a
> > > > fixed/improved modifier support could actually fix it as well.
> > > > Alternately I'd like to move to kmsro in mesa as this fixes it as
> > > > well, but that could just be by coincidence and would break other
> > > > devices..
> > > >
> > > > Thanks
> > > >
> > > > On Tue, Jul 14, 2020 at 4:32 PM James Jones <jajones@nvidia.com> wrote:
> > > >>
> > > >> Still testing. I'll get a Sign-off version out this week unless I find
> > > >> a problem.
> > > >>
> > > >> Thanks,
> > > >> -James
> > > >>
> > > >> On 7/12/20 6:37 PM, Dave Airlie wrote:
> > > >>> How are we going with a fix for this regression I can commit?
> > > >>>
> > > >>> Dave.
> > > >>>
> > > >> _______________________________________________
> > > >> dri-devel mailing list
> > > >> dri-devel@lists.freedesktop.org
> > > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > >>
> > > >
> > >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-12 12:24 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 6:06 [git pull] drm for 5.8-rc1 Dave Airlie
2020-06-02 21:21 ` Linus Torvalds
2020-06-02 21:22 ` Linus Torvalds
2020-06-02 21:56 ` Linus Torvalds
2020-06-03 7:18 ` Thomas Zimmermann
2020-06-03 7:43 ` Daniel Vetter
2020-06-02 22:14 ` Linus Torvalds
2020-06-02 23:03 ` Dave Airlie
2020-06-02 22:20 ` pr-tracker-bot
2020-06-03 20:13 ` Jason Gunthorpe
2020-06-04 8:10 ` Christian König
2020-06-30 23:08 ` Kirill A. Shutemov
2020-07-01 4:40 ` James Jones
2020-07-01 7:57 ` Kirill A. Shutemov
2020-07-01 7:59 ` Kirill A. Shutemov
2020-07-01 19:45 ` James Jones
2020-07-02 7:36 ` Daniel Vetter
2020-07-02 7:59 ` Pekka Paalanen
2020-07-02 8:22 ` Daniel Stone
2020-07-02 21:14 ` James Jones
2020-07-03 6:01 ` James Jones
2020-07-03 7:16 ` Daniel Vetter
2020-07-13 1:37 ` Dave Airlie
2020-07-14 14:31 ` James Jones
2020-08-04 8:58 ` Karol Herbst
2020-08-12 0:19 ` James Jones
2020-08-12 10:27 ` Karol Herbst
2020-08-12 10:43 ` Karol Herbst
2020-08-12 12:24 ` Karol Herbst [this message]
2020-08-12 12:37 ` Ilia Mirkin
2020-08-12 17:03 ` James Jones
2020-08-12 17:10 ` Karol Herbst
2020-08-12 17:19 ` James Jones
2020-08-12 17:40 ` Alyssa Rosenzweig
2020-08-12 18:24 ` James Jones
2020-08-12 18:51 ` Karol Herbst
2020-08-13 13:00 ` Karol Herbst
2020-08-13 15:39 ` Karol Herbst
2020-08-13 17:19 ` Karol Herbst
2020-08-13 17:45 ` James Jones
2020-08-13 17:48 ` Karol Herbst
2020-08-14 13:57 ` Thierry Reding
2020-08-14 13:59 ` Karol Herbst
2020-08-14 14:10 ` Thierry Reding
2020-08-14 14:05 ` Thierry Reding
2020-08-14 14:44 ` Karol Herbst
2020-08-14 15:34 ` Thierry Reding
2020-08-14 15:40 ` Karol Herbst
2020-08-14 16:06 ` Thierry Reding
2020-08-14 16:12 ` Karol Herbst
2020-08-14 16:22 ` Thierry Reding
2020-08-14 17:17 ` Daniel Stone
2020-08-14 17:25 ` Daniel Vetter
2020-08-18 14:37 ` Thierry Reding
2020-09-01 7:13 ` Daniel Vetter
2020-09-01 10:42 ` Daniel Stone
2020-09-01 10:59 ` Karol Herbst
2020-09-01 14:42 ` James Jones
2020-08-14 14:08 ` Thierry Reding
2020-08-14 14:45 ` Karol Herbst
2020-08-14 15:24 ` Thierry Reding
2020-08-14 15:43 ` Karol Herbst
2020-08-14 13:54 ` Thierry Reding
2020-08-14 13:40 ` Thierry Reding
2020-08-14 13:56 ` Karol Herbst
2020-08-12 15:05 ` Thierry Reding
2020-08-12 15:20 ` Karol Herbst
2020-08-12 15:49 ` Karol Herbst
2020-07-01 11:24 ` Karol Herbst
2020-07-01 15:51 ` James Jones
2020-07-01 16:01 ` Daniel Vetter
2020-07-01 17:04 ` Karol Herbst
2020-07-01 17:37 ` James Jones
2020-07-01 18:08 ` Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACO55tvF0dOQ=myUpccmfHc+hCVQZoXQnCA0iHeXQo3B=UaD0Q@mail.gmail.com' \
--to=kherbst@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jajones@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).