* [PATCH 1/2] drm/panel: use 'select' for Ili9341 panel driver helpers
@ 2022-08-23 0:42 Randy Dunlap
2022-08-26 11:42 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-08-23 0:42 UTC (permalink / raw)
To: linux-kernel
Cc: David Airlie, Dillon Min, Randy Dunlap, dri-devel,
Noralf Trønnes, Thierry Reding, Thomas Zimmermann,
Sam Ravnborg
Use 'select' instead of 'depends on' for DRM helpers for the
Ilitek ILI9341 panel driver.
This is what is done in the vast majority of other cases and
this makes it possible to fix a build error with drm_mipi_dbi.
Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dillon Min <dillon.minfei@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
drivers/gpu/drm/panel/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -165,8 +165,8 @@ config DRM_PANEL_ILITEK_IL9322
config DRM_PANEL_ILITEK_ILI9341
tristate "Ilitek ILI9341 240x320 QVGA panels"
depends on OF && SPI
- depends on DRM_KMS_HELPER
- depends on DRM_GEM_DMA_HELPER
+ select DRM_KMS_HELPER
+ select DRM_GEM_DMA_HELPER
depends on BACKLIGHT_CLASS_DEVICE
select DRM_MIPI_DBI
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] drm/panel: use 'select' for Ili9341 panel driver helpers
2022-08-23 0:42 [PATCH 1/2] drm/panel: use 'select' for Ili9341 panel driver helpers Randy Dunlap
@ 2022-08-26 11:42 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-08-26 11:42 UTC (permalink / raw)
To: Randy Dunlap
Cc: Noralf Trønnes, David Airlie, Dillon Min, linux-kernel,
dri-devel, Thierry Reding, Thomas Zimmermann, Sam Ravnborg
On Tue, Aug 23, 2022 at 2:42 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Use 'select' instead of 'depends on' for DRM helpers for the
> Ilitek ILI9341 panel driver.
> This is what is done in the vast majority of other cases and
> this makes it possible to fix a build error with drm_mipi_dbi.
>
> Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dillon Min <dillon.minfei@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Patch applied to drm-misc-next
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-26 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 0:42 [PATCH 1/2] drm/panel: use 'select' for Ili9341 panel driver helpers Randy Dunlap
2022-08-26 11:42 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).