* [PATCH v2] drm/radeon: don't evict if not initialized
@ 2021-03-21 15:19 Tong Zhang
2021-03-22 7:40 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Tong Zhang @ 2021-03-21 15:19 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Daniel Vetter,
amd-gfx, dri-devel, linux-kernel
Cc: Tong Zhang
TTM_PL_VRAM may not initialized at all when calling
radeon_bo_evict_vram(). We need to check before doing eviction.
[ 2.160837] BUG: kernel NULL pointer dereference, address: 0000000000000020
[ 2.161212] #PF: supervisor read access in kernel mode
[ 2.161490] #PF: error_code(0x0000) - not-present page
[ 2.161767] PGD 0 P4D 0
[ 2.163088] RIP: 0010:ttm_resource_manager_evict_all+0x70/0x1c0 [ttm]
[ 2.168506] Call Trace:
[ 2.168641] radeon_bo_evict_vram+0x1c/0x20 [radeon]
[ 2.168936] radeon_device_fini+0x28/0xf9 [radeon]
[ 2.169224] radeon_driver_unload_kms+0x44/0xa0 [radeon]
[ 2.169534] radeon_driver_load_kms+0x174/0x210 [radeon]
[ 2.169843] drm_dev_register+0xd9/0x1c0 [drm]
[ 2.170104] radeon_pci_probe+0x117/0x1a0 [radeon]
Suggested-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
v2: coding style fix
drivers/gpu/drm/radeon/radeon_object.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
index 9b81786782de..499ce55e34cc 100644
--- a/drivers/gpu/drm/radeon/radeon_object.c
+++ b/drivers/gpu/drm/radeon/radeon_object.c
@@ -384,6 +384,8 @@ int radeon_bo_evict_vram(struct radeon_device *rdev)
}
#endif
man = ttm_manager_type(bdev, TTM_PL_VRAM);
+ if (!man)
+ return 0;
return ttm_resource_manager_evict_all(bdev, man);
}
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/radeon: don't evict if not initialized
2021-03-21 15:19 [PATCH v2] drm/radeon: don't evict if not initialized Tong Zhang
@ 2021-03-22 7:40 ` Christian König
2021-03-23 14:45 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2021-03-22 7:40 UTC (permalink / raw)
To: Tong Zhang, Alex Deucher, David Airlie, Daniel Vetter, amd-gfx,
dri-devel, linux-kernel
Am 21.03.21 um 16:19 schrieb Tong Zhang:
> TTM_PL_VRAM may not initialized at all when calling
> radeon_bo_evict_vram(). We need to check before doing eviction.
>
> [ 2.160837] BUG: kernel NULL pointer dereference, address: 0000000000000020
> [ 2.161212] #PF: supervisor read access in kernel mode
> [ 2.161490] #PF: error_code(0x0000) - not-present page
> [ 2.161767] PGD 0 P4D 0
> [ 2.163088] RIP: 0010:ttm_resource_manager_evict_all+0x70/0x1c0 [ttm]
> [ 2.168506] Call Trace:
> [ 2.168641] radeon_bo_evict_vram+0x1c/0x20 [radeon]
> [ 2.168936] radeon_device_fini+0x28/0xf9 [radeon]
> [ 2.169224] radeon_driver_unload_kms+0x44/0xa0 [radeon]
> [ 2.169534] radeon_driver_load_kms+0x174/0x210 [radeon]
> [ 2.169843] drm_dev_register+0xd9/0x1c0 [drm]
> [ 2.170104] radeon_pci_probe+0x117/0x1a0 [radeon]
>
> Suggested-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> v2: coding style fix
>
> drivers/gpu/drm/radeon/radeon_object.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 9b81786782de..499ce55e34cc 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -384,6 +384,8 @@ int radeon_bo_evict_vram(struct radeon_device *rdev)
> }
> #endif
> man = ttm_manager_type(bdev, TTM_PL_VRAM);
> + if (!man)
> + return 0;
> return ttm_resource_manager_evict_all(bdev, man);
> }
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/radeon: don't evict if not initialized
2021-03-22 7:40 ` Christian König
@ 2021-03-23 14:45 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-03-23 14:45 UTC (permalink / raw)
To: Christian König
Cc: David Airlie, Tong Zhang, LKML, Maling list - DRI developers,
amd-gfx list, Alex Deucher
Applied. Thanks!
Alex
On Mon, Mar 22, 2021 at 3:40 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 21.03.21 um 16:19 schrieb Tong Zhang:
> > TTM_PL_VRAM may not initialized at all when calling
> > radeon_bo_evict_vram(). We need to check before doing eviction.
> >
> > [ 2.160837] BUG: kernel NULL pointer dereference, address: 0000000000000020
> > [ 2.161212] #PF: supervisor read access in kernel mode
> > [ 2.161490] #PF: error_code(0x0000) - not-present page
> > [ 2.161767] PGD 0 P4D 0
> > [ 2.163088] RIP: 0010:ttm_resource_manager_evict_all+0x70/0x1c0 [ttm]
> > [ 2.168506] Call Trace:
> > [ 2.168641] radeon_bo_evict_vram+0x1c/0x20 [radeon]
> > [ 2.168936] radeon_device_fini+0x28/0xf9 [radeon]
> > [ 2.169224] radeon_driver_unload_kms+0x44/0xa0 [radeon]
> > [ 2.169534] radeon_driver_load_kms+0x174/0x210 [radeon]
> > [ 2.169843] drm_dev_register+0xd9/0x1c0 [drm]
> > [ 2.170104] radeon_pci_probe+0x117/0x1a0 [radeon]
> >
> > Suggested-by: Christian König <christian.koenig@amd.com>
> > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > v2: coding style fix
> >
> > drivers/gpu/drm/radeon/radeon_object.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> > index 9b81786782de..499ce55e34cc 100644
> > --- a/drivers/gpu/drm/radeon/radeon_object.c
> > +++ b/drivers/gpu/drm/radeon/radeon_object.c
> > @@ -384,6 +384,8 @@ int radeon_bo_evict_vram(struct radeon_device *rdev)
> > }
> > #endif
> > man = ttm_manager_type(bdev, TTM_PL_VRAM);
> > + if (!man)
> > + return 0;
> > return ttm_resource_manager_evict_all(bdev, man);
> > }
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-23 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-21 15:19 [PATCH v2] drm/radeon: don't evict if not initialized Tong Zhang
2021-03-22 7:40 ` Christian König
2021-03-23 14:45 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).