* [PATCH] drm: amd: Fix trailing semicolons
@ 2018-01-17 18:50 Luis de Bethencourt
[not found] ` <20180117185020.25169-1-luisbg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2018-01-17 18:50 UTC (permalink / raw)
To: linux-kernel
Cc: Joe Perches, Alex Deucher, Christian Konig, David Airlie,
Harry Wentland, Tony Cheng, Wenjing Liu, Ding Wang, Sylvia Tsai,
Hersen Wu, Rex Zhu, Eric Huang, Huang Rui, Dan Carpenter,
amd-gfx, dri-devel, Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation.
Removing the two instances of them since they don't do anything.
Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 61e8c3e02d16..33d91e4474ea 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(
uint32_t retries_ch_eq;
enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;
union lane_align_status_updated dpcd_lane_status_updated = {{0}};
- union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};;
+ union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};
hw_tr_pattern = get_supported_tp(link);
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index fa9d1615a2cc..b98a7a8a22b5 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)
if(hwmgr->smumgr_funcs->start_smu(pp_handle->hwmgr)) {
pr_err("smc start failed\n");
hwmgr->smumgr_funcs->smu_fini(pp_handle->hwmgr);
- return -EINVAL;;
+ return -EINVAL;
}
if (ret == PP_DPM_DISABLED)
goto exit;
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: amd: Fix trailing semicolons
[not found] ` <20180117185020.25169-1-luisbg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2018-01-30 19:23 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2018-01-30 19:23 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: Tony Cheng, Sylvia Tsai, David Airlie, Rex Zhu, Wenjing Liu,
LKML, amd-gfx list, Christian Konig, Eric Huang, Huang Rui,
Hersen Wu, Maling list - DRI developers, Alex Deucher,
Joe Perches, Harry Wentland, Ding Wang, Dan Carpenter
On Wed, Jan 17, 2018 at 1:50 PM, Luis de Bethencourt <luisbg@kernel.org> wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing the two instances of them since they don't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
Applied. thanks!
Alex
> ---
>
> Hi,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
> drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 61e8c3e02d16..33d91e4474ea 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(
> uint32_t retries_ch_eq;
> enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;
> union lane_align_status_updated dpcd_lane_status_updated = {{0}};
> - union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};;
> + union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX] = {{{0}}};
>
> hw_tr_pattern = get_supported_tp(link);
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index fa9d1615a2cc..b98a7a8a22b5 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)
> if(hwmgr->smumgr_funcs->start_smu(pp_handle->hwmgr)) {
> pr_err("smc start failed\n");
> hwmgr->smumgr_funcs->smu_fini(pp_handle->hwmgr);
> - return -EINVAL;;
> + return -EINVAL;
> }
> if (ret == PP_DPM_DISABLED)
> goto exit;
> --
> 2.15.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-30 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17 18:50 [PATCH] drm: amd: Fix trailing semicolons Luis de Bethencourt
[not found] ` <20180117185020.25169-1-luisbg-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-30 19:23 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).