* [PATCH] etnaviv: fix whitespace errors
@ 2019-07-31 21:29 Christian Gmeiner
2019-08-01 9:22 ` Philipp Zabel
0 siblings, 1 reply; 3+ messages in thread
From: Christian Gmeiner @ 2019-07-31 21:29 UTC (permalink / raw)
To: dri-devel; +Cc: etnaviv
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
index 4227a4006c34..06e6d3ee1c34 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
@@ -15,8 +15,8 @@ struct etnaviv_pm_signal {
u32 data;
u32 (*sample)(struct etnaviv_gpu *gpu,
- const struct etnaviv_pm_domain *domain,
- const struct etnaviv_pm_signal *signal);
+ const struct etnaviv_pm_domain *domain,
+ const struct etnaviv_pm_signal *signal);
};
struct etnaviv_pm_domain {
--
2.21.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] etnaviv: fix whitespace errors
2019-07-31 21:29 [PATCH] etnaviv: fix whitespace errors Christian Gmeiner
@ 2019-08-01 9:22 ` Philipp Zabel
2019-08-02 11:28 ` Christian Gmeiner
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Zabel @ 2019-08-01 9:22 UTC (permalink / raw)
To: Christian Gmeiner, dri-devel; +Cc: etnaviv
Hi Christian,
On Wed, 2019-07-31 at 23:29 +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> index 4227a4006c34..06e6d3ee1c34 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> @@ -15,8 +15,8 @@ struct etnaviv_pm_signal {
> u32 data;
>
> u32 (*sample)(struct etnaviv_gpu *gpu,
> - const struct etnaviv_pm_domain *domain,
> - const struct etnaviv_pm_signal *signal);
> + const struct etnaviv_pm_domain *domain,
> + const struct etnaviv_pm_signal *signal);
That silences a checkpatch error, but now the alignment to the
opening parenthesis is gone.
How about using two tabs and six spaces instead?
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] etnaviv: fix whitespace errors
2019-08-01 9:22 ` Philipp Zabel
@ 2019-08-02 11:28 ` Christian Gmeiner
0 siblings, 0 replies; 3+ messages in thread
From: Christian Gmeiner @ 2019-08-02 11:28 UTC (permalink / raw)
To: Philipp Zabel; +Cc: The etnaviv authors, DRI mailing list
Hi Philipp
Am Do., 1. Aug. 2019 um 11:22 Uhr schrieb Philipp Zabel
<p.zabel@pengutronix.de>:
>
> Hi Christian,
>
> On Wed, 2019-07-31 at 23:29 +0200, Christian Gmeiner wrote:
> > Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > ---
> > drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> > index 4227a4006c34..06e6d3ee1c34 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c
> > @@ -15,8 +15,8 @@ struct etnaviv_pm_signal {
> > u32 data;
> >
> > u32 (*sample)(struct etnaviv_gpu *gpu,
> > - const struct etnaviv_pm_domain *domain,
> > - const struct etnaviv_pm_signal *signal);
> > + const struct etnaviv_pm_domain *domain,
> > + const struct etnaviv_pm_signal *signal);
>
> That silences a checkpatch error, but now the alignment to the
> opening parenthesis is gone.
> How about using two tabs and six spaces instead?
>
Works for me - I think my git config was the problem here.
[core]
pager = less -x1,5
I removed this now and looks git diff looks better now.
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-02 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 21:29 [PATCH] etnaviv: fix whitespace errors Christian Gmeiner
2019-08-01 9:22 ` Philipp Zabel
2019-08-02 11:28 ` Christian Gmeiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).