dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/ttm: drop unusued function declaration
@ 2020-07-28  4:51 Dave Airlie
  2020-07-28  7:49 ` Christian König
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Airlie @ 2020-07-28  4:51 UTC (permalink / raw)
  To: dri-devel; +Cc: christian.koenig

From: Dave Airlie <airlied@redhat.com>

This was removed in
f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove TTM_MEMTYPE_FLAG_CMA

but the the declaration was left dangling.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 include/drm/ttm/ttm_bo_driver.h | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
index 71b195e78c7c..5a37f1cc057e 100644
--- a/include/drm/ttm/ttm_bo_driver.h
+++ b/include/drm/ttm/ttm_bo_driver.h
@@ -525,17 +525,6 @@ ttm_flag_masked(uint32_t *old, uint32_t new, uint32_t mask)
  * ttm_bo.c
  */
 
-/**
- * ttm_mem_reg_is_pci
- *
- * @bdev: Pointer to a struct ttm_bo_device.
- * @mem: A valid struct ttm_mem_reg.
- *
- * Returns true if the memory described by @mem is PCI memory,
- * false otherwise.
- */
-bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, struct ttm_mem_reg *mem);
-
 /**
  * ttm_bo_mem_space
  *
-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/ttm: drop unusued function declaration
  2020-07-28  4:51 [PATCH] drm/ttm: drop unusued function declaration Dave Airlie
@ 2020-07-28  7:49 ` Christian König
  2020-07-29  0:04   ` Dave Airlie
  0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2020-07-28  7:49 UTC (permalink / raw)
  To: Dave Airlie, dri-devel

Am 28.07.20 um 06:51 schrieb Dave Airlie:
> From: Dave Airlie <airlied@redhat.com>
>
> This was removed in
> f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove TTM_MEMTYPE_FLAG_CMA
>
> but the the declaration was left dangling.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   include/drm/ttm/ttm_bo_driver.h | 11 -----------
>   1 file changed, 11 deletions(-)
>
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 71b195e78c7c..5a37f1cc057e 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -525,17 +525,6 @@ ttm_flag_masked(uint32_t *old, uint32_t new, uint32_t mask)
>    * ttm_bo.c
>    */
>   
> -/**
> - * ttm_mem_reg_is_pci
> - *
> - * @bdev: Pointer to a struct ttm_bo_device.
> - * @mem: A valid struct ttm_mem_reg.
> - *
> - * Returns true if the memory described by @mem is PCI memory,
> - * false otherwise.
> - */
> -bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, struct ttm_mem_reg *mem);
> -
>   /**
>    * ttm_bo_mem_space
>    *

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/ttm: drop unusued function declaration
  2020-07-28  7:49 ` Christian König
@ 2020-07-29  0:04   ` Dave Airlie
  0 siblings, 0 replies; 3+ messages in thread
From: Dave Airlie @ 2020-07-29  0:04 UTC (permalink / raw)
  To: Christian König; +Cc: dri-devel

On Tue, 28 Jul 2020 at 17:49, Christian König <christian.koenig@amd.com> wrote:
>
> Am 28.07.20 um 06:51 schrieb Dave Airlie:
> > From: Dave Airlie <airlied@redhat.com>
> >
> > This was removed in
> > f5a9a9383f279de9da63296cb623a6418a66196b drm/ttm: remove TTM_MEMTYPE_FLAG_CMA
> >
> > but the the declaration was left dangling.
> >
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>

I've just pushed this, the unbind and swapout all to drm-next.

Though we should probably in future just have you merge them via misc.

Dave.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-29  0:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28  4:51 [PATCH] drm/ttm: drop unusued function declaration Dave Airlie
2020-07-28  7:49 ` Christian König
2020-07-29  0:04   ` Dave Airlie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).