* [BUG] gpu: drm: possible ABBA deadlock in drm_gem_prime_fd_to_handle() and drm_gem_prime_handle_to_fd()
@ 2021-12-09 3:32 Jia-Ju Bai
0 siblings, 0 replies; only message in thread
From: Jia-Ju Bai @ 2021-12-09 3:32 UTC (permalink / raw)
To: maarten.lankhorst, Maxime Ripard, tzimmermann, airlied, daniel
Cc: linux-kernel, dri-devel
Hello,
My static analysis tool reports a possible ABBA deadlock in the drm
driver in Linux 5.10:
drm_gem_prime_fd_to_handle()
mutex_lock(&dev->object_name_lock); --> Line 313 (Lock A)
drm_gem_handle_delete()
drm_gem_object_release_handle()
drm_gem_remove_prime_handles()
mutex_lock(&filp->prime.lock); --> Line 16 (Lock B)
drm_gem_prime_handle_to_fd()
mutex_lock(&file_priv->prime.lock); --> Line 433 (Lock B)
mutex_lock(&dev->object_name_lock); --> Line 466 (Lock A)
When drm_gem_prime_fd_to_handle() and drm_gem_prime_handle_to_fd() are
concurrently executed, the deadlock can occur.
I am not quite sure whether this possible deadlock is real and how to
fix it if it is real.
Any feedback would be appreciated, thanks :)
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Best wishes,
Jia-Ju Bai
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-12-09 16:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 3:32 [BUG] gpu: drm: possible ABBA deadlock in drm_gem_prime_fd_to_handle() and drm_gem_prime_handle_to_fd() Jia-Ju Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).