[Bug 196337] New: Re-enable GFX PG breaks Carrizo

* [Bug 196337] New: Re-enable GFX PG breaks Carrizo
@ 2017-07-12  8:48 bugzilla-daemon
  2017-07-17 18:49 ` [Bug 196337] [amdgpu][carrizo] " bugzilla-daemon
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: bugzilla-daemon @ 2017-07-12  8:48 UTC (permalink / raw)
  To: dri-devel

https://bugzilla.kernel.org/show_bug.cgi?id=196337

            Bug ID: 196337
           Summary: Re-enable GFX PG breaks Carrizo
           Product: Drivers
           Version: 2.5
    Kernel Version: 4.12.0-09301-g3b06b1a7448e
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: johannes.hirte@datenkhaos.de
        Regression: No

With the current drm updates, my system immediately reboots when X starts.
Bisecting pointet me first at 

2dc80b00652f2a08f3f1a01e668e3c7ad716f55f is the first bad commit
commit 2dc80b00652f2a08f3f1a01e668e3c7ad716f55f
Author: Shirish S <shirish.s@amd.com>
Date:   Thu May 25 10:05:25 2017 +0530

    drm/amdgpu: optimize amdgpu driver load & resume time

    amdgpu_device_resume() & amdgpu_device_init() have a high
    time consuming call of amdgpu_late_init() which sets the
    clock_gating state of all IP blocks and is blocking.
    This patch defers only this setting of clock gating state
    operation to post resume of amdgpu driver but ideally before
    the UI comes up or in some cases post ui as well.

    With this change the resume time of amdgpu_device comes down
    from 1.299s to 0.199s which further helps in reducing the overall
    system resume time.

    V1: made the optimization applicable during driver load as well.

    TEST:(For ChromiumOS on STONEY only)
    * UI comes up
    * amdgpu_late_init() call gets called consistently and no errors reported.

    Signed-off-by: Shirish S <shirish.s@amd.com>
    Reviewed-by: Huang Rui <ray.huang@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

:040000 040000 a7c011a1238a16f134e62f7f891660218387f834
66059629924642e897de024bea19d28856e6ae44 M      drivers

The commit before doesn't work either, but hangs on console with a white cursor
when X starts. With a second bisect I came to

commit 4fdca894bb3be01829bb620b6157cafee9f956a6
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Fri Mar 17 15:27:06 2017 -0400

    Revert "drm/amd/amdgpu: Disable GFX_PG on Carrizo until compute issues
solved"

    Re-enable GFX PG.  It's working properly with MEC now that KIQ is
    enabled.

    Reviewed-by: Samuel  Li <samuel.li@amd.com>

    This reverts commit e9ef19aa1bdeac380662a112f1d03a7c3477527f.

Reverting this on (disabling GFX PG again) made my system work again.

System is a HP ProBook 645 G2 with an AMD PRO A10-8700B.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread