* [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table
@ 2020-11-06 7:03 Viresh Kumar
2020-11-06 7:03 ` [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument Viresh Kumar
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Viresh Kumar @ 2020-11-06 7:03 UTC (permalink / raw)
To: Alyssa Rosenzweig, Andy Gross, Bjorn Andersson, Chanwoo Choi,
Daniel Vetter, David Airlie, Ilia Lin, Krzysztof Kozlowski,
Kukjin Kim, Kyungmin Park, MyungJoo Ham, Nishanth Menon,
Qiang Yu, Rafael J. Wysocki, Rob Herring, Stanimir Varbanov,
Stephen Boyd, Steven Price, Tomeu Vizoso, Viresh Kumar,
Viresh Kumar
Cc: linux-samsung-soc, Vincent Guittot, lima, linux-pm,
linux-arm-msm, linux-kernel, dri-devel, digetx, linux-arm-kernel,
linux-media
Hello,
This patchset updates the dev_pm_opp_put_*() helpers to accept a NULL
pointer for the OPP table, in order to allow the callers to drop the
unnecessary checks they had to carry.
All these must get merged upstream through the OPP tree as there is a
hard dependency on the first patch here. Thanks.
Viresh Kumar (7):
opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table
cpufreq: dt: dev_pm_opp_put_regulators() accepts NULL argument
cpufreq: qcom-cpufreq-nvmem: dev_pm_opp_put_*() accepts NULL argument
devfreq: exynos: dev_pm_opp_put_*() accepts NULL argument
drm/lima: dev_pm_opp_put_*() accepts NULL argument
drm/panfrost: dev_pm_opp_put_*() accepts NULL argument
media: venus: dev_pm_opp_put_*() accepts NULL argument
drivers/cpufreq/cpufreq-dt.c | 6 ++----
drivers/cpufreq/qcom-cpufreq-nvmem.c | 15 ++++++---------
drivers/devfreq/exynos-bus.c | 12 ++++--------
drivers/gpu/drm/lima/lima_devfreq.c | 13 ++++---------
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----
drivers/media/platform/qcom/venus/pm_helpers.c | 3 +--
drivers/opp/core.c | 18 ++++++++++++++++++
7 files changed, 37 insertions(+), 36 deletions(-)
--
2.25.0.rc1.19.g042ed3e048af
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument
2020-11-06 7:03 [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table Viresh Kumar
@ 2020-11-06 7:03 ` Viresh Kumar
2020-11-16 0:42 ` Qiang Yu
2020-11-06 7:03 ` [PATCH 6/7] drm/panfrost: " Viresh Kumar
2020-11-08 9:25 ` [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table Ilia Lin
2 siblings, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2020-11-06 7:03 UTC (permalink / raw)
To: Qiang Yu, David Airlie, Daniel Vetter
Cc: Nishanth Menon, Vincent Guittot, lima, linux-pm, Stephen Boyd,
Viresh Kumar, Rafael Wysocki, linux-kernel, dri-devel, digetx
The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
there is no need for us to carry the extra check. Drop them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/gpu/drm/lima/lima_devfreq.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c
index bbe02817721b..e7b7b8dfd792 100644
--- a/drivers/gpu/drm/lima/lima_devfreq.c
+++ b/drivers/gpu/drm/lima/lima_devfreq.c
@@ -110,15 +110,10 @@ void lima_devfreq_fini(struct lima_device *ldev)
devfreq->opp_of_table_added = false;
}
- if (devfreq->regulators_opp_table) {
- dev_pm_opp_put_regulators(devfreq->regulators_opp_table);
- devfreq->regulators_opp_table = NULL;
- }
-
- if (devfreq->clkname_opp_table) {
- dev_pm_opp_put_clkname(devfreq->clkname_opp_table);
- devfreq->clkname_opp_table = NULL;
- }
+ dev_pm_opp_put_regulators(devfreq->regulators_opp_table);
+ dev_pm_opp_put_clkname(devfreq->clkname_opp_table);
+ devfreq->regulators_opp_table = NULL;
+ devfreq->clkname_opp_table = NULL;
}
int lima_devfreq_init(struct lima_device *ldev)
--
2.25.0.rc1.19.g042ed3e048af
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 6/7] drm/panfrost: dev_pm_opp_put_*() accepts NULL argument
2020-11-06 7:03 [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table Viresh Kumar
2020-11-06 7:03 ` [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument Viresh Kumar
@ 2020-11-06 7:03 ` Viresh Kumar
2020-11-09 9:17 ` Steven Price
2020-11-08 9:25 ` [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table Ilia Lin
2 siblings, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2020-11-06 7:03 UTC (permalink / raw)
To: Rob Herring, Tomeu Vizoso, Steven Price, Alyssa Rosenzweig,
David Airlie, Daniel Vetter
Cc: Nishanth Menon, Vincent Guittot, linux-pm, Stephen Boyd,
Viresh Kumar, Rafael Wysocki, linux-kernel, dri-devel, digetx
The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
there is no need for us to carry the extra check. Drop them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
index 8ab025d0035f..97b5abc7c188 100644
--- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
+++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
@@ -170,10 +170,8 @@ void panfrost_devfreq_fini(struct panfrost_device *pfdev)
pfdevfreq->opp_of_table_added = false;
}
- if (pfdevfreq->regulators_opp_table) {
- dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);
- pfdevfreq->regulators_opp_table = NULL;
- }
+ dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);
+ pfdevfreq->regulators_opp_table = NULL;
}
void panfrost_devfreq_resume(struct panfrost_device *pfdev)
--
2.25.0.rc1.19.g042ed3e048af
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table
2020-11-06 7:03 [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table Viresh Kumar
2020-11-06 7:03 ` [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument Viresh Kumar
2020-11-06 7:03 ` [PATCH 6/7] drm/panfrost: " Viresh Kumar
@ 2020-11-08 9:25 ` Ilia Lin
2 siblings, 0 replies; 6+ messages in thread
From: Ilia Lin @ 2020-11-08 9:25 UTC (permalink / raw)
To: Viresh Kumar
Cc: Nishanth Menon, David Airlie, Stanimir Varbanov, dri-devel,
Bjorn Andersson, MyungJoo Ham, digetx, linux-samsung-soc,
Vincent Guittot, lima, Viresh Kumar, Krzysztof Kozlowski,
Steven Price, Chanwoo Choi, Ilia Lin, Kukjin Kim,
Alyssa Rosenzweig, linux-media,
open list:QUALCOMM CPUFREQ DRIVER MSM8996/APQ8096,
open list:ARM/QUALCOMM SUPPORT, linux-arm-kernel, Tomeu Vizoso,
Stephen Boyd, Rafael J. Wysocki, Andy Gross, open list,
Kyungmin Park, Qiang Yu
Reviewed-by: Ilia Lin <ilia.lin@kernel.org>
On Fri, Nov 6, 2020 at 9:05 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> Hello,
>
> This patchset updates the dev_pm_opp_put_*() helpers to accept a NULL
> pointer for the OPP table, in order to allow the callers to drop the
> unnecessary checks they had to carry.
>
> All these must get merged upstream through the OPP tree as there is a
> hard dependency on the first patch here. Thanks.
>
> Viresh Kumar (7):
> opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table
> cpufreq: dt: dev_pm_opp_put_regulators() accepts NULL argument
> cpufreq: qcom-cpufreq-nvmem: dev_pm_opp_put_*() accepts NULL argument
> devfreq: exynos: dev_pm_opp_put_*() accepts NULL argument
> drm/lima: dev_pm_opp_put_*() accepts NULL argument
> drm/panfrost: dev_pm_opp_put_*() accepts NULL argument
> media: venus: dev_pm_opp_put_*() accepts NULL argument
>
> drivers/cpufreq/cpufreq-dt.c | 6 ++----
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 15 ++++++---------
> drivers/devfreq/exynos-bus.c | 12 ++++--------
> drivers/gpu/drm/lima/lima_devfreq.c | 13 ++++---------
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----
> drivers/media/platform/qcom/venus/pm_helpers.c | 3 +--
> drivers/opp/core.c | 18 ++++++++++++++++++
> 7 files changed, 37 insertions(+), 36 deletions(-)
>
> --
> 2.25.0.rc1.19.g042ed3e048af
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/7] drm/panfrost: dev_pm_opp_put_*() accepts NULL argument
2020-11-06 7:03 ` [PATCH 6/7] drm/panfrost: " Viresh Kumar
@ 2020-11-09 9:17 ` Steven Price
0 siblings, 0 replies; 6+ messages in thread
From: Steven Price @ 2020-11-09 9:17 UTC (permalink / raw)
To: Viresh Kumar, Rob Herring, Tomeu Vizoso, Alyssa Rosenzweig,
David Airlie, Daniel Vetter
Cc: Nishanth Menon, Vincent Guittot, linux-pm, Stephen Boyd,
Rafael Wysocki, linux-kernel, dri-devel, digetx
On 06/11/2020 07:03, Viresh Kumar wrote:
> The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
> there is no need for us to carry the extra check. Drop them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> index 8ab025d0035f..97b5abc7c188 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> @@ -170,10 +170,8 @@ void panfrost_devfreq_fini(struct panfrost_device *pfdev)
> pfdevfreq->opp_of_table_added = false;
> }
>
> - if (pfdevfreq->regulators_opp_table) {
> - dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);
> - pfdevfreq->regulators_opp_table = NULL;
> - }
> + dev_pm_opp_put_regulators(pfdevfreq->regulators_opp_table);
> + pfdevfreq->regulators_opp_table = NULL;
> }
>
> void panfrost_devfreq_resume(struct panfrost_device *pfdev)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument
2020-11-06 7:03 ` [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument Viresh Kumar
@ 2020-11-16 0:42 ` Qiang Yu
0 siblings, 0 replies; 6+ messages in thread
From: Qiang Yu @ 2020-11-16 0:42 UTC (permalink / raw)
To: Viresh Kumar
Cc: Nishanth Menon, Vincent Guittot, lima, linux-pm, David Airlie,
Rafael Wysocki, Linux Kernel Mailing List, dri-devel,
Stephen Boyd, digetx
Looks good for me, patch is:
Reviewed-by: Qiang Yu <yuq825@gmail.com>
Regards,
Qiang
On Fri, Nov 6, 2020 at 3:05 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> The dev_pm_opp_put_*() APIs now accepts a NULL opp_table pointer and so
> there is no need for us to carry the extra check. Drop them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/gpu/drm/lima/lima_devfreq.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c
> index bbe02817721b..e7b7b8dfd792 100644
> --- a/drivers/gpu/drm/lima/lima_devfreq.c
> +++ b/drivers/gpu/drm/lima/lima_devfreq.c
> @@ -110,15 +110,10 @@ void lima_devfreq_fini(struct lima_device *ldev)
> devfreq->opp_of_table_added = false;
> }
>
> - if (devfreq->regulators_opp_table) {
> - dev_pm_opp_put_regulators(devfreq->regulators_opp_table);
> - devfreq->regulators_opp_table = NULL;
> - }
> -
> - if (devfreq->clkname_opp_table) {
> - dev_pm_opp_put_clkname(devfreq->clkname_opp_table);
> - devfreq->clkname_opp_table = NULL;
> - }
> + dev_pm_opp_put_regulators(devfreq->regulators_opp_table);
> + dev_pm_opp_put_clkname(devfreq->clkname_opp_table);
> + devfreq->regulators_opp_table = NULL;
> + devfreq->clkname_opp_table = NULL;
> }
>
> int lima_devfreq_init(struct lima_device *ldev)
> --
> 2.25.0.rc1.19.g042ed3e048af
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-16 0:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 7:03 [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table Viresh Kumar
2020-11-06 7:03 ` [PATCH 5/7] drm/lima: dev_pm_opp_put_*() accepts NULL argument Viresh Kumar
2020-11-16 0:42 ` Qiang Yu
2020-11-06 7:03 ` [PATCH 6/7] drm/panfrost: " Viresh Kumar
2020-11-09 9:17 ` Steven Price
2020-11-08 9:25 ` [PATCH 0/7] opp: Allow dev_pm_opp_put_*() APIs to accept NULL opp_table Ilia Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).