* [PATCH] drm/tegra: remove useless if check before kfree
@ 2022-04-13 6:46 Bernard Zhao
2022-04-13 7:22 ` Mikko Perttunen
0 siblings, 1 reply; 2+ messages in thread
From: Bernard Zhao @ 2022-04-13 6:46 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Daniel Vetter, Jonathan Hunter,
dri-devel, linux-tegra, linux-kernel
Cc: bernard, Bernard Zhao
This patch remove useless if check before kfree.
Signed-off-by: Bernard Zhao <zhaojunkui2008@126.com>
---
drivers/gpu/drm/tegra/submit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
index 6d6dd8c35475..54ac31bc80f6 100644
--- a/drivers/gpu/drm/tegra/submit.c
+++ b/drivers/gpu/drm/tegra/submit.c
@@ -639,8 +639,7 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
kfree(job_data->used_mappings);
}
- if (job_data)
- kfree(job_data);
+ kfree(job_data);
put_bo:
gather_bo_put(&bo->base);
unlock:
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tegra: remove useless if check before kfree
2022-04-13 6:46 [PATCH] drm/tegra: remove useless if check before kfree Bernard Zhao
@ 2022-04-13 7:22 ` Mikko Perttunen
0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2022-04-13 7:22 UTC (permalink / raw)
To: Bernard Zhao, Thierry Reding, David Airlie, Daniel Vetter,
Jonathan Hunter, dri-devel, linux-tegra, linux-kernel
Cc: bernard
On 4/13/22 09:46, Bernard Zhao wrote:
> This patch remove useless if check before kfree.
>
> Signed-off-by: Bernard Zhao <zhaojunkui2008@126.com>
> ---
> drivers/gpu/drm/tegra/submit.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
> index 6d6dd8c35475..54ac31bc80f6 100644
> --- a/drivers/gpu/drm/tegra/submit.c
> +++ b/drivers/gpu/drm/tegra/submit.c
> @@ -639,8 +639,7 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
> kfree(job_data->used_mappings);
> }
>
> - if (job_data)
> - kfree(job_data);
> + kfree(job_data);
> put_bo:
> gather_bo_put(&bo->base);
> unlock:
(Same comment as for other patch.)
I personally dislike leaving the NULL checks off with calls to kfree.
With the NULL check there, while reading the code it is obvious that the
intention is that the value can be either a valid pointer or NULL. IMHO
with C's type system/conventions we need this kind of contextual
information to understand the code easily and avoid bugs.
Mikko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-13 7:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 6:46 [PATCH] drm/tegra: remove useless if check before kfree Bernard Zhao
2022-04-13 7:22 ` Mikko Perttunen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).