* [PATCH] drm: mxsfb: Implement drm_panel handling
@ 2017-02-01 17:19 Fabio Estevam
2017-02-01 17:22 ` Thierry Reding
2017-02-07 21:44 ` Marek Vasut
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2017-02-01 17:19 UTC (permalink / raw)
To: airlied; +Cc: marex, breno.lima, Fabio Estevam, dri-devel
Currently when the 'power-supply' regulator is passed via device tree
it does not actually work since drm_panel_prepare()/drm_panel_enable()
are never called.
Quoting Thierry Reding: "It should really call drm_panel_prepare() and
drm_panel_enable() while switching on the display pipeline and
drm_panel_disable(), followed by drm_panel_unprepare() while switching
off the display pipeline."
So do as suggested, so that the 'power-supply' regulator can be functional.
Reported-by: Breno Lima <breno.lima@nxp.com>
Suggested-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 955441f..766538f8 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -102,14 +102,18 @@ static void mxsfb_pipe_enable(struct drm_simple_display_pipe *pipe,
{
struct mxsfb_drm_private *mxsfb = drm_pipe_to_mxsfb_drm_private(pipe);
+ drm_panel_prepare(mxsfb->panel);
mxsfb_crtc_enable(mxsfb);
+ drm_panel_enable(mxsfb->panel);
}
static void mxsfb_pipe_disable(struct drm_simple_display_pipe *pipe)
{
struct mxsfb_drm_private *mxsfb = drm_pipe_to_mxsfb_drm_private(pipe);
+ drm_panel_disable(mxsfb->panel);
mxsfb_crtc_disable(mxsfb);
+ drm_panel_unprepare(mxsfb->panel);
}
static void mxsfb_pipe_update(struct drm_simple_display_pipe *pipe,
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: mxsfb: Implement drm_panel handling
2017-02-01 17:19 [PATCH] drm: mxsfb: Implement drm_panel handling Fabio Estevam
@ 2017-02-01 17:22 ` Thierry Reding
2017-02-01 19:05 ` Breno Matheus Lima
2017-02-07 21:44 ` Marek Vasut
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2017-02-01 17:22 UTC (permalink / raw)
To: Fabio Estevam; +Cc: marex, breno.lima, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 872 bytes --]
On Wed, Feb 01, 2017 at 03:19:47PM -0200, Fabio Estevam wrote:
> Currently when the 'power-supply' regulator is passed via device tree
> it does not actually work since drm_panel_prepare()/drm_panel_enable()
> are never called.
>
> Quoting Thierry Reding: "It should really call drm_panel_prepare() and
> drm_panel_enable() while switching on the display pipeline and
> drm_panel_disable(), followed by drm_panel_unprepare() while switching
> off the display pipeline."
>
> So do as suggested, so that the 'power-supply' regulator can be functional.
>
> Reported-by: Breno Lima <breno.lima@nxp.com>
> Suggested-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: mxsfb: Implement drm_panel handling
2017-02-01 17:22 ` Thierry Reding
@ 2017-02-01 19:05 ` Breno Matheus Lima
0 siblings, 0 replies; 4+ messages in thread
From: Breno Matheus Lima @ 2017-02-01 19:05 UTC (permalink / raw)
To: Thierry Reding, Fabio Estevam; +Cc: marex, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1217 bytes --]
Tested-by: Breno Lima <breno.lima@nxp.com>
________________________________
From: Thierry Reding <thierry.reding@gmail.com>
Sent: Wednesday, February 1, 2017 3:22 PM
To: Fabio Estevam
Cc: airlied@linux.ie; marex@denx.de; dri-devel@lists.freedesktop.org; Breno Matheus Lima
Subject: Re: [PATCH] drm: mxsfb: Implement drm_panel handling
On Wed, Feb 01, 2017 at 03:19:47PM -0200, Fabio Estevam wrote:
> Currently when the 'power-supply' regulator is passed via device tree
> it does not actually work since drm_panel_prepare()/drm_panel_enable()
> are never called.
>
> Quoting Thierry Reding: "It should really call drm_panel_prepare() and
> drm_panel_enable() while switching on the display pipeline and
> drm_panel_disable(), followed by drm_panel_unprepare() while switching
> off the display pipeline."
>
> So do as suggested, so that the 'power-supply' regulator can be functional.
>
> Reported-by: Breno Lima <breno.lima@nxp.com>
> Suggested-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: Type: text/html, Size: 2243 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: mxsfb: Implement drm_panel handling
2017-02-01 17:19 [PATCH] drm: mxsfb: Implement drm_panel handling Fabio Estevam
2017-02-01 17:22 ` Thierry Reding
@ 2017-02-07 21:44 ` Marek Vasut
1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2017-02-07 21:44 UTC (permalink / raw)
To: Fabio Estevam, airlied; +Cc: breno.lima, dri-devel
On 02/01/2017 06:19 PM, Fabio Estevam wrote:
> Currently when the 'power-supply' regulator is passed via device tree
> it does not actually work since drm_panel_prepare()/drm_panel_enable()
> are never called.
>
> Quoting Thierry Reding: "It should really call drm_panel_prepare() and
> drm_panel_enable() while switching on the display pipeline and
> drm_panel_disable(), followed by drm_panel_unprepare() while switching
> off the display pipeline."
>
> So do as suggested, so that the 'power-supply' regulator can be functional.
>
> Reported-by: Breno Lima <breno.lima@nxp.com>
> Suggested-by: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Tested-by: Marek Vasut <marex@denx.de>
--
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-07 21:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-01 17:19 [PATCH] drm: mxsfb: Implement drm_panel handling Fabio Estevam
2017-02-01 17:22 ` Thierry Reding
2017-02-01 19:05 ` Breno Matheus Lima
2017-02-07 21:44 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).