* [PATCH] staging: rtl8723bs: Disable procfs debugging by default
@ 2019-07-18 9:25 Kai-Heng Feng
2019-07-25 7:55 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2019-07-18 9:25 UTC (permalink / raw)
To: gregkh; +Cc: devel, Kai-Heng Feng, linux-kernel
The procfs provides many useful information for debugging, but it may be
too much for normal usage, routines like proc_get_sec_info() reports
various security related information.
So disable it by defaultl.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/staging/rtl8723bs/include/autoconf.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h
index 196aca3aed7b..8f4c1e734473 100644
--- a/drivers/staging/rtl8723bs/include/autoconf.h
+++ b/drivers/staging/rtl8723bs/include/autoconf.h
@@ -57,9 +57,5 @@
#define DBG 0 /* for ODM & BTCOEX debug */
#endif /* !DEBUG */
-#ifdef CONFIG_PROC_FS
-#define PROC_DEBUG
-#endif
-
/* define DBG_XMIT_BUF */
/* define DBG_XMIT_BUF_EXT */
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: Disable procfs debugging by default
2019-07-18 9:25 [PATCH] staging: rtl8723bs: Disable procfs debugging by default Kai-Heng Feng
@ 2019-07-25 7:55 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-07-25 7:55 UTC (permalink / raw)
To: Kai-Heng Feng; +Cc: devel, linux-kernel
On Thu, Jul 18, 2019 at 05:25:22PM +0800, Kai-Heng Feng wrote:
> The procfs provides many useful information for debugging, but it may be
> too much for normal usage, routines like proc_get_sec_info() reports
> various security related information.
>
> So disable it by defaultl.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> drivers/staging/rtl8723bs/include/autoconf.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/autoconf.h b/drivers/staging/rtl8723bs/include/autoconf.h
> index 196aca3aed7b..8f4c1e734473 100644
> --- a/drivers/staging/rtl8723bs/include/autoconf.h
> +++ b/drivers/staging/rtl8723bs/include/autoconf.h
> @@ -57,9 +57,5 @@
> #define DBG 0 /* for ODM & BTCOEX debug */
> #endif /* !DEBUG */
>
> -#ifdef CONFIG_PROC_FS
> -#define PROC_DEBUG
> -#endif
What? Why? If you are going to do this, then rip out all of the code
as well.
And are you _sure_ you want to do this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-25 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 9:25 [PATCH] staging: rtl8723bs: Disable procfs debugging by default Kai-Heng Feng
2019-07-25 7:55 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).