Re: [PATCH] staging/ks7010: Fix coding style problems [Version 2]

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3424 bytes --]

Hi Leon,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git ff63261978ee1f00758f447d63276a6f180a81dc
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/be523ea1038288a8b2c8e5cf10bb2e6a02830a0a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Leon-Krieg/staging-ks7010-Fix-coding-style-problems-Version-2/20210817-020702
        git checkout be523ea1038288a8b2c8e5cf10bb2e6a02830a0a
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/staging/ks7010/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/compiler_types.h:65,
                    from <command-line>:
   drivers/staging/ks7010/ks_wlan_net.c: In function 'ks_wlan_set_freq':
>> include/linux/compiler_attributes.h:210:41: error: invalid use of attribute 'fallthrough'
     210 | # define fallthrough                    __attribute__((__fallthrough__))
         |                                         ^~~~~~~~~~~~~
   drivers/staging/ks7010/ks_wlan_net.c:191:17: note: in expansion of macro 'fallthrough'
     191 |                 fallthrough;
         |                 ^~~~~~~~~~~


vim +/fallthrough +210 include/linux/compiler_attributes.h

294f69e662d1570 Joe Perches   2019-10-05  197  
294f69e662d1570 Joe Perches   2019-10-05  198  /*
294f69e662d1570 Joe Perches   2019-10-05  199   * Add the pseudo keyword 'fallthrough' so case statement blocks
294f69e662d1570 Joe Perches   2019-10-05  200   * must end with any of these keywords:
294f69e662d1570 Joe Perches   2019-10-05  201   *   break;
294f69e662d1570 Joe Perches   2019-10-05  202   *   fallthrough;
ca0760e7d79e2bb Wei Ming Chen 2021-05-06  203   *   continue;
294f69e662d1570 Joe Perches   2019-10-05  204   *   goto <label>;
294f69e662d1570 Joe Perches   2019-10-05  205   *   return [expression];
294f69e662d1570 Joe Perches   2019-10-05  206   *
294f69e662d1570 Joe Perches   2019-10-05  207   *  gcc: https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html#Statement-Attributes
294f69e662d1570 Joe Perches   2019-10-05  208   */
294f69e662d1570 Joe Perches   2019-10-05  209  #if __has_attribute(__fallthrough__)
294f69e662d1570 Joe Perches   2019-10-05 @210  # define fallthrough                    __attribute__((__fallthrough__))
294f69e662d1570 Joe Perches   2019-10-05  211  #else
294f69e662d1570 Joe Perches   2019-10-05  212  # define fallthrough                    do {} while (0)  /* fallthrough */
a3f8a30f3f0079c Miguel Ojeda  2018-08-30  213  #endif
a3f8a30f3f0079c Miguel Ojeda  2018-08-30  214  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60706 bytes --]

[-- Attachment #3: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel