From: Dan Carpenter <dan.carpenter@oracle.com>
To: Leon Krieg <info@madcow.dev>
Cc: gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] staging/ks7010: Fix coding style problems [Version 2]
Date: Mon, 23 Aug 2021 18:32:33 +0300 [thread overview]
Message-ID: <20210823153233.GK1931@kadam> (raw)
In-Reply-To: <20210816180447.GA17851@mad-cln-mothership-1.local>
Google for how to format a v2 patch.
On Mon, Aug 16, 2021 at 08:04:47PM +0200, Leon Krieg wrote:
> By doing some last-second wording changes directly in the diff I've
> screwed up and managed to use spaces instead of tabs for the Kconfig file.
> This is embarrassing!
>
I love adding backstory to my commit messages and but this is a bit
much. :P Just say "Use tabs instead of spaces". Add the backstory
under the --- cut off line if necessary.
Also it doesn't just change the Kconfig file. There are a lot of
unrelated changes as well.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2021-08-23 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:04 [PATCH] staging/ks7010: Fix coding style problems [Version 2] Leon Krieg
2021-08-16 19:18 ` Greg KH
2021-08-16 21:11 ` kernel test robot
2021-08-16 22:00 ` kernel test robot
2021-08-23 15:32 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823153233.GK1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=info@madcow.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).