From: Shreeya Patel <shreeya.patel23498@gmail.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
Joe Perches <joe@perches.com>,
Larry.Finger@lwfinger.net
Subject: Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: Add space around operators
Date: Mon, 23 Mar 2020 15:40:50 +0530 [thread overview]
Message-ID: <24a7d4a5b2595326f61082cbe5220ed73e9c27e9.camel@gmail.com> (raw)
In-Reply-To: <20200323020425.62dbeebb@elisabeth>
On Mon, 2020-03-23 at 02:04 +0100, Stefano Brivio wrote:
> Hi Shreeya,
>
> On Mon, 23 Mar 2020 04:48:08 +0530
> Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
>
> > On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> > > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:
> >
> > Hi Greg and Joe,
> >
> > > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel
> > > > wrote:
> > > > > Add space around operators for improving the code
> > > > > readability.
> > > > > Reported by checkpatch.pl
> > > > >
> > > > > git diff -w shows no difference.
> > > > > diff of the .o files before and after the changes shows no
> > > > > difference.
> > > >
> > > > There is no need to have these two lines on every changelog
> > > > comment
> > > > in
> > > > this series :(
> > >
> > >
> >
> > Yes I get that.
> >
> > > In my opinion, there's no need for a series here.
> > >
> > > Whitespace only changes _should_ be done all at once.
> > >
> > > Whitespace changes _could_ have changed string constants.
> > >
> > > So noting that the patch in only whitespace and that
> > > there isn't a difference in object files is useful as
> > > it shows any change has been compiled and tested.
> > >
> >
> > Joe, I feel the same thing, there is no need of a patch series
> > for it but I was given a suggestion that it becomes difficult for
> > the
> > reviewers to review the patch so it is good to send a patchset
> > instead.
>
> In this case, reviewing the 224 lines you're touching in one shot
> feels
> the same as reviewing them over 11 patches, as the change is always
> of
> the same type. Maybe a single patch is actually even a bit quicker to
> review.
>
> Are you sure the suggestion was referring to this, and it wasn't
> about
> different type of changes in the same patch?
>
Yes I am sure about it. But anyway I will send a single patch for these
changes now.
Thanks Stefano :)
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-23 10:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 22:19 [Outreachy kernel] [PATCH 00/11] Staging: rtl8188eu: hal: Add space around operators Shreeya Patel
2020-03-21 22:21 ` [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com: " Shreeya Patel
2020-03-22 11:27 ` Greg KH
2020-03-22 15:09 ` Joe Perches
2020-03-22 23:18 ` Shreeya Patel
2020-03-23 1:04 ` Stefano Brivio
2020-03-23 10:10 ` Shreeya Patel [this message]
2020-03-21 22:22 ` [Outreachy kernel] [PATCH 02/11] Staging: rtl8188eu: odm: " Shreeya Patel
2020-03-21 22:23 ` [Outreachy kernel] [PATCH 03/11] Staging: rtl8188eu: odm_hwconfig: " Shreeya Patel
2020-03-21 22:24 ` [Outreachy kernel] [PATCH 04/11] Staging: rtl8188eu: phy: " Shreeya Patel
2020-03-21 22:25 ` [Outreachy kernel] [PATCH 05/11] Staging: rtl8188eu: pwrseqcmd: " Shreeya Patel
2020-03-21 22:25 ` [Outreachy kernel] [PATCH 06/11] Staging: rtl8188eu: rf: " Shreeya Patel
2020-03-21 22:26 ` [Outreachy kernel] [PATCH 07/11] Staging: rtl8188eu: rf_cfg: " Shreeya Patel
2020-03-21 22:27 ` [Outreachy kernel] [PATCH 08/11] Staging: rtl8188eu: rtl8188e_cmd: " Shreeya Patel
2020-03-21 22:28 ` [Outreachy kernel] [PATCH 09/11] Staging: rtl8188eu: rtl8188e_hal_init: " Shreeya Patel
2020-03-21 22:29 ` [Outreachy kernel] [PATCH 10/11] Staging: rtl8188eu: rtl8188e_rxdesc: " Shreeya Patel
2020-03-21 22:30 ` [Outreachy kernel] [PATCH 11/11] Staging: rtl8188eu: rtl8188eu_xmit: " Shreeya Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a7d4a5b2595326f61082cbe5220ed73e9c27e9.camel@gmail.com \
--to=shreeya.patel23498@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).