From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Bitwise or the conversion colour specifier together
Date: Thu, 24 Dec 2020 11:34:59 +0530 [thread overview]
Message-ID: <f6daaf1e-beab-4b9c-c6de-5e0fabe5e16e@intel.com> (raw)
In-Reply-To: <87a6u4okvl.fsf@intel.com>
Thanks Chris to catch this.
This definitely should be bitwise Operator, as mentioned by Jani is
right thing to do.
The PCON which I had access to, had the F/W which was using 303Ch
(previously proposed) for color conversion capability, instead of what
is latest mentioned in the spec ie. 83h.
While testing, I had to skip this line of code, and hardcoded to older
register ie. 303Ch.
I Will get this patch tested and update.
Thanks & Regards,
Ankit
On 12/23/2020 4:21 PM, Jani Nikula wrote:
> On Wed, 23 Dec 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> drivers/gpu/drm/i915/display/intel_dp.c:6922 intel_dp_update_420() warn: should this be a bitwise op?
>> drivers/gpu/drm/i915/display/intel_dp.c:6922 intel_dp_update_420() warn: should this be a bitwise op?
>> drivers/gpu/drm/i915/display/intel_dp.c:6923 intel_dp_update_420() warn: should this be a bitwise op?
>>
>> Inside drm_dp_downstream_rgb_to_ycbcr_conversion(), that paramter
>> 'color_spc' is used as return port_cap[3] & color_spc, implying that it
>> is indeed a mask and not a boolean value.
> So this one belongs in topic/dp-hdmi-2.1-pcon branch.
>
> Purely based on the context this is the right thing to do, so:
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Ankit, please test the patch in case it uncovers some other
> issues. It'll impact the RGB to YCbCr conversion.
>
> BR,
> Jani.
>
>
>> Fixes: 522508b665df ("drm/i915/display: Let PCON convert from RGB to YCbCr if it can")
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Uma Shankar <uma.shankar@intel.com>
>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index 8b4b2ea52859..157a850a83a7 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -6918,8 +6918,8 @@ intel_dp_update_420(struct intel_dp *intel_dp)
>> intel_dp->downstream_ports);
>> rgb_to_ycbcr = drm_dp_downstream_rgb_to_ycbcr_conversion(intel_dp->dpcd,
>> intel_dp->downstream_ports,
>> - DP_DS_HDMI_BT601_RGB_YCBCR_CONV ||
>> - DP_DS_HDMI_BT709_RGB_YCBCR_CONV ||
>> + DP_DS_HDMI_BT601_RGB_YCBCR_CONV |
>> + DP_DS_HDMI_BT709_RGB_YCBCR_CONV |
>> DP_DS_HDMI_BT2020_RGB_YCBCR_CONV);
>>
>> if (INTEL_GEN(i915) >= 11) {
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-24 6:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 10:39 [Intel-gfx] [PATCH] drm/i915/display: Bitwise or the conversion colour specifier together Chris Wilson
2020-12-23 10:51 ` Jani Nikula
2020-12-24 6:04 ` Nautiyal, Ankit K [this message]
2021-01-08 13:15 ` Jani Nikula
2021-01-13 11:52 ` Jani Nikula
2021-01-15 7:24 ` Nautiyal, Ankit K
2021-01-15 8:22 ` Chris Wilson
2020-12-23 13:44 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-12-23 14:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6daaf1e-beab-4b9c-c6de-5e0fabe5e16e@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.